From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C0E2C001DD for ; Mon, 3 Jul 2023 20:07:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED396280035; Mon, 3 Jul 2023 16:07:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8434280030; Mon, 3 Jul 2023 16:07:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2570280035; Mon, 3 Jul 2023 16:07:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BF000280030 for ; Mon, 3 Jul 2023 16:07:54 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 91BAD1C7DD5 for ; Mon, 3 Jul 2023 20:07:54 +0000 (UTC) X-FDA: 80971386468.30.E2B9E4C Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by imf28.hostedemail.com (Postfix) with ESMTP id E5287C0019 for ; Mon, 3 Jul 2023 20:07:50 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=nazf7Cnb; spf=pass (imf28.hostedemail.com: domain of rientjes@google.com designates 209.85.166.171 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688414871; a=rsa-sha256; cv=none; b=r+41xYjQ8sVzZx/2XimDglHFQlxBDD33b79fbSoQdvXpsWix98wmoXr3a3sqa7z8AJqKTt RkfxytTv0uEbaDbtIVmQKQszwFXZbmNbKaxmCUKRF2XR747q48T2oV2xOVpbpokqkaIQkI it/DHwSDT0LWPe7GmGVUSIr2/IrUc2g= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=nazf7Cnb; spf=pass (imf28.hostedemail.com: domain of rientjes@google.com designates 209.85.166.171 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688414871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jNZBCQ1ON8fJUbn+ixPhHY0VTglMPFtl4s4xHz4gKhE=; b=TjMp3vxfZ+K/QCQuYR8hfDc0Jy7/Eu5ForByxoVwYYCk20ptgKqGIq4wNDoYN9ICsuATXE lL2QDSPzlg0ic+h3y12MnEsp1HBJZ6pu4FXlVNsYm5AmN7gfFvAtNYTp1Zf8BlrHom4kJv g5gdUk6ngjW1WTZ45Fbvfv1HkFl1dH4= Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-345bc4a438fso310305ab.1 for ; Mon, 03 Jul 2023 13:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688414871; x=1691006871; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=jNZBCQ1ON8fJUbn+ixPhHY0VTglMPFtl4s4xHz4gKhE=; b=nazf7Cnb4Dc+QhoMOvoY3Dg7tTe97SWnmDrgjWohK+APXH4ck0gu/t2TryRqF3AY8u 06QgAfhJet+oiQQyu2C/5Ih/xsV3L319u4kYPjCNQv5n6H6lMYJGxexjHSzGRuu84uiT kZH9LZejiZcNPKQbmkwlShFn3kEWRl0XralbcFUXn2nUnSlrKeS+kLwnudNOfIAiYbCn ZEg8oVdxRy0YhuS31F/FVfUa26yxL2FhrZqMI67nxldFeBiRD3TM55BUH/CCDuit2EFU DS/+EXdwYSQFJtRSViVow4TqO87qCqaLBe+Q4VX3B2rZUSl3Fur0ldQ7DAkvP+bhOsA3 nbFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688414871; x=1691006871; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jNZBCQ1ON8fJUbn+ixPhHY0VTglMPFtl4s4xHz4gKhE=; b=byG1ptuZ8+06wR2kUuq0h69wpRn1zl+r1BtdurYuusvma+N7L+3HtS24Zxe+axrKhJ S6lN2ChUfBQh1NW8z5tofe6D1b+1iY1SGsGuL+beQTEQ3CazBlM/iKHeMa7LyQ9fpb6r JFu9jS1rqWVmeAiZOvFKJZ4HY5yqqVnQOgqZ8m7ZmAiSfzg/BbuBZIVb2/RH6t+oj7Ke wxgBS/cDFjZf/1PD8Aix2rlamCgKHHucDGesTBEd1kL41VzsDO3hea3ZIVAZLS09qcqe s7OSeQ2HrzYo+hw1kBbs6bHpomNsWqv1ur/L1OF6/00HYN+YZiPHqT4plJHVRQHJGsHQ j9YA== X-Gm-Message-State: ABy/qLaHR7mnNHKDYaslpgDeNT3UAMw6A3RdnymSE9lkZcCtn2ncx+7D S5qAYtgCRQH9sO1OXEP0fWYIVQ== X-Google-Smtp-Source: APBJJlE+Acz9vVPT9kWfj3kzTUcDrrDuofcYSHawQueVa0qLKaeF0nl3MKr50rq6AZPNnpr3lGyFkw== X-Received: by 2002:a05:6e02:1709:b0:340:502b:1487 with SMTP id u9-20020a056e02170900b00340502b1487mr16651ill.12.1688414870636; Mon, 03 Jul 2023 13:07:50 -0700 (PDT) Received: from [2620:0:1008:15:17fc:1b56:71df:89b7] ([2620:0:1008:15:17fc:1b56:71df:89b7]) by smtp.gmail.com with ESMTPSA id e24-20020a656898000000b0054f9936accesm12177617pgt.55.2023.07.03.13.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 13:07:50 -0700 (PDT) Date: Mon, 3 Jul 2023 13:07:48 -0700 (PDT) From: David Rientjes To: Suren Baghdasaryan cc: Andrew Morton , jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, Vlastimil Babka , hannes@cmpxchg.org, mgorman@techsingularity.net, Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , Peter Zijlstra , Laurent Dufour , paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org Subject: Re: [PATCH 1/1] mm: disable CONFIG_PER_VMA_LOCK by default until its fixed In-Reply-To: <20230703182150.2193578-1-surenb@google.com> Message-ID: <54cd9ffb-8f4b-003f-c2d6-3b6b0d2cb7d9@google.com> References: <20230703182150.2193578-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E5287C0019 X-Stat-Signature: 643j85cfyghszs5aiqxpafh9qb7oke9x X-Rspam-User: X-HE-Tag: 1688414870-226322 X-HE-Meta: U2FsdGVkX1+kHwQlhv7WpjJJptM1+Q0M0R9yKOVOaZz6/46WGusIxcuQ9K+jfOjB+65PF1Z0g+4+2S0EiB6xdMTQusxmWPmZTPeJHDHUTu3rzpx2JUAGQxz2b6akE8hrX2yzAk6ZOdKKw7l07WLsipwSFwtSDeHQcqm9JFUDcwfW7u7efSmLrkc6rhzICIutwR3ve9A9iupSYx8uJ8L8Dqvj67Rce3hbWcxX8xi2yNO/rLHU+KS++Fm6LqUcaOLnwSz/ZAZ/2FlLdnKkWmsjuO5rbw/5PpS5mF/oGiaOcC/ftBOT0N3/sEpV7UzG68/pMcu21gH0ucjUrw4WIT3tLsRkT2Q47qjTpVIo3W7xn5+dE6gaxUN4EqDNKnlszkP25bkPlUoOy/rlp91Q+KMVEAlP+h6ODzdbbeRQ8Ib2EwVIel5ikXI02dlnEvOnGHrmqBe1zq8LAiagmLEvR4JMDzCKOc1YMOCiO+3+iLXYV1NzXLG+gYPuRYo5WS2zJ6b9yVom9NeFgjXQbk4LGwgWM7eAWrvYFKBPMueeaPjZbT1XsPcUUNLyaqvxIi5/5ZUWTGIrDjYOICd639XU4Qf8rDvLMnKUUh/nHqGeob0WxWdFLUIX7nkqa4YcRccwmKyVk/Q51phAQFWC3nR3U5VuaSdqcwpn/zZZDv7NvAaL5xkkfBxhay7d9jdcAvZI5zsciMakD/T7PIWgq5oToDJrLXm3hntMOt5vYqpz+PKOoLVlFwNGuyZM+Vnq7y2mkxqbUI0aZf3cVpjkIHPOyLrciWl8/5jdNYL2zUDaZmBpAheUDEvSpXaff2l/ddBgoCV2iQEUjZZghMmvHQKeIRnhmcRlBhBP/CVC79+sQbxh5Fjlqaf4txCJWNzzXJCQTWTIo5f+8qJe4wBV2uabtRi2aQn6RkM7TMnO0NSt+Zs0JBFW81dlM9wDpfEw+f6vH7XAhMn5VQgaklBUegH/GNF pjGtEmPM UTFbLNzoGzqVt0bsPbHcBq3qU/1Ro6KPk80Ef3GtusNbCQhf+vHr1n6o65FjEPllROByXVW7ha1qV3U9mAa+twKt01ihacBG6uTKD0Mc8aaaj6NKIT0ZXtsrc0UHIrWmxgrcBksA9v9b1/H9wBuh3SbD2QqQwZsAWu/Bk8xB8ubK8e0BFvIeA6tgYsAfkE8obG7hj6KNLfnd5KoGh/oIlNbh/xpWxmic3bbkK7OrxzayqGYodUyvJG/Da2Oa/xb6Z34HGYW1Z9Af8M1s95rUadbqzYcPFevLNo7dcXozAmYT+QiKyACskftuWMpMWbqkzmzqfk78afrHdpb49xdKI1XsBO9GX0SzM/29i/Qyb2zEbR7mzBEvVxfKXrT/dCydg8jJr7wDAkp8FIIIjDm6LNSqB3ckwP1fjGvrcHbL/zdryGEtw4nRc0NdpFKbXPtylol+h8jO+RwVPd0WcUiyHKiYD5qNSmHaqbYA3giuniLc4atmWvuuFpsLUetr9XsxG9jzDwGDNBKTJBq9lPo6AqLHMMtireoxcYA2JwF6A3h5axPVCxJCqpRVE69ffcq0xnxfrohurrQvuY44oGON2crXGcw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 3 Jul 2023, Suren Baghdasaryan wrote: > A memory corruption was reported in [1] with bisection pointing to the > patch [2] enabling per-VMA locks for x86. > Disable per-VMA locks config to prevent this issue while the problem is > being investigated. This is expected to be a temporary measure. > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=217624 > [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@google.com > > Reported-by: Jiri Slaby > Reported-by: Jacob Young > Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling first") > Signed-off-by: Suren Baghdasaryan Acked-by: David Rientjes Thanks for the heads up! The bisect commit [2] is a no-op with CONFIG_PER_VMA_LOCK disabled, this looks good. Nit: in that patch the "done" label could have been a: "done: __maybe_unused" to a avoid the #ifdef :P > --- > mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 09130434e30d..de94b2497600 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1224,7 +1224,7 @@ config ARCH_SUPPORTS_PER_VMA_LOCK > def_bool n > > config PER_VMA_LOCK > - def_bool y > + bool "Enable per-vma locking during page fault handling." > depends on ARCH_SUPPORTS_PER_VMA_LOCK && MMU && SMP > help > Allow per-vma locking during page fault handling. > -- > 2.41.0.255.g8b1d071c50-goog > >