From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4947CC63793 for ; Thu, 22 Jul 2021 06:53:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D3C1861279 for ; Thu, 22 Jul 2021 06:53:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3C1861279 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1C3346B006C; Thu, 22 Jul 2021 02:53:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14BD86B0071; Thu, 22 Jul 2021 02:53:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 012886B0072; Thu, 22 Jul 2021 02:52:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id D8BAD6B006C for ; Thu, 22 Jul 2021 02:52:59 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 80C3F180AD81F for ; Thu, 22 Jul 2021 06:52:59 +0000 (UTC) X-FDA: 78389306478.23.55F7F8D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 19B25502A88F for ; Thu, 22 Jul 2021 06:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626936778; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ax6HkWFA5BWwvTOf3UZ5KXstCPRBEySKl51WxciY7is=; b=OqQsximrS50BtujpRP2/TKuFobIirerI+6M32RiPIxbYTCctt+lKwzYmUMKyjP16KWSPtw jiO26FClh2JumjfhTPbeA4bOS1jyfIkNOtuv+06K52Wb7f2TnlNIrRbVQkMbq4mP4KZaJW w8vq5kl53N/N63D0EtQbdhwRoBWaNSE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-175-CqHssU_jO-S41fHuZ9o9tg-1; Thu, 22 Jul 2021 02:52:57 -0400 X-MC-Unique: CqHssU_jO-S41fHuZ9o9tg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 714DC10086DA; Thu, 22 Jul 2021 06:52:55 +0000 (UTC) Received: from [10.64.54.195] (vpn2-54-195.bne.redhat.com [10.64.54.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1DBDA752BB; Thu, 22 Jul 2021 06:52:52 +0000 (UTC) Reply-To: Gavin Shan Subject: Re: [PATCH v3 11/12] mm/debug_vm_pgtable: Remove unused code To: Anshuman Khandual , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, chuhu@redhat.com, shan.gavin@gmail.com References: <20210719130613.334901-1-gshan@redhat.com> <20210719130613.334901-12-gshan@redhat.com> From: Gavin Shan Message-ID: <54bd0724-90c3-564b-fa3a-2e6c86ec609b@redhat.com> Date: Thu, 22 Jul 2021 16:53:10 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OqQsximr; spf=none (imf05.hostedemail.com: domain of gshan@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Stat-Signature: 75ib464uw85dqwx8ebosakt185toju3p X-Rspamd-Queue-Id: 19B25502A88F X-HE-Tag: 1626936778-519032 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Anshuman, On 7/22/21 2:51 PM, Anshuman Khandual wrote: > Small nit for the subject line. > > s/Remove unused code/Remove unused page table debug elements/ > Ok. Will apply the replacement in v4, thanks! > On 7/19/21 6:36 PM, Gavin Shan wrote: >> The variables used by old implementation isn't needed as we switched >> to "struct pgtable_debug_args". Lets remove them and related code in >> debug_vm_pgtable(). >> >> Signed-off-by: Gavin Shan >> --- >> mm/debug_vm_pgtable.c | 54 ------------------------------------------- >> 1 file changed, 54 deletions(-) >> >> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c >> index 5ebacc940b68..4f7bf1c9724a 100644 >> --- a/mm/debug_vm_pgtable.c >> +++ b/mm/debug_vm_pgtable.c >> @@ -1124,14 +1124,6 @@ static int __init init_args(struct pgtable_debug_args *args) >> static int __init debug_vm_pgtable(void) >> { >> struct pgtable_debug_args args; >> - struct vm_area_struct *vma; >> - struct mm_struct *mm; >> - pgd_t *pgdp; >> - p4d_t *p4dp; >> - pud_t *pudp; >> - pmd_t *pmdp, *saved_pmdp, pmd; >> - pgtable_t saved_ptep; >> - unsigned long vaddr; >> spinlock_t *ptl = NULL; >> int idx, ret; >> >> @@ -1140,41 +1132,6 @@ static int __init debug_vm_pgtable(void) >> if (ret) >> return ret; >> >> - vaddr = get_random_vaddr(); >> - mm = mm_alloc(); >> - if (!mm) { >> - pr_err("mm_struct allocation failed\n"); >> - return 1; >> - } >> - >> - vma = vm_area_alloc(mm); >> - if (!vma) { >> - pr_err("vma allocation failed\n"); >> - return 1; >> - } >> - >> - pgdp = pgd_offset(mm, vaddr); >> - p4dp = p4d_alloc(mm, pgdp, vaddr); >> - pudp = pud_alloc(mm, p4dp, vaddr); >> - pmdp = pmd_alloc(mm, pudp, vaddr); >> - /* >> - * Allocate pgtable_t >> - */ >> - if (pte_alloc(mm, pmdp)) { >> - pr_err("pgtable allocation failed\n"); >> - return 1; >> - } >> - >> - /* >> - * Save all the page table page addresses as the page table >> - * entries will be used for testing with random or garbage >> - * values. These saved addresses will be used for freeing >> - * page table pages. >> - */ > > Please move this comment as is to the right place inside init_args() > in the first patch itself. If possible all comments should be moved > during the first patch and just the code gets dropped here. > In PATCH[v3 01/12], We already had the comments in init_args() as below: /* * The above page table entries will be modified. Lets save the * page table entries so that they can be released when the tests * are completed. */ >> - pmd = READ_ONCE(*pmdp); >> - saved_pmdp = pmd_offset(pudp, 0UL); >> - saved_ptep = pmd_pgtable(pmd); >> - >> /* >> * Iterate over the protection_map[] to make sure that all >> * the basic page table transformation validations just hold >> @@ -1256,17 +1213,6 @@ static int __init debug_vm_pgtable(void) >> pgd_populate_tests(&args); >> spin_unlock(&(args.mm->page_table_lock)); >> >> - p4d_free(mm, p4d_offset(pgdp, 0UL)); >> - pud_free(mm, pud_offset(p4dp, 0UL)); >> - pmd_free(mm, saved_pmdp); >> - pte_free(mm, saved_ptep); >> - >> - vm_area_free(vma); >> - mm_dec_nr_puds(mm); >> - mm_dec_nr_pmds(mm); >> - mm_dec_nr_ptes(mm); >> - mmdrop(mm); >> - >> destroy_args(&args); >> return 0; >> } >> Thanks, Gavin