From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CD33C3DA5D for ; Fri, 19 Jul 2024 21:58:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 683F26B0083; Fri, 19 Jul 2024 17:58:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6333D6B0085; Fri, 19 Jul 2024 17:58:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FA7F6B0088; Fri, 19 Jul 2024 17:58:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 339646B0083 for ; Fri, 19 Jul 2024 17:58:57 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A96AE1A05A4 for ; Fri, 19 Jul 2024 21:58:56 +0000 (UTC) X-FDA: 82357867872.06.2A7108C Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by imf28.hostedemail.com (Postfix) with ESMTP id 9628FC001C for ; Fri, 19 Jul 2024 21:58:54 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmx.com header.s=s31663417 header.b=lrmPSCYD; spf=pass (imf28.hostedemail.com: domain of quwenruo.btrfs@gmx.com designates 212.227.17.22 as permitted sender) smtp.mailfrom=quwenruo.btrfs@gmx.com; dmarc=pass (policy=quarantine) header.from=gmx.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721426313; a=rsa-sha256; cv=none; b=Ot3KMgK5Ne4BPZ/2D3vFDfao0MxnceDtTpnR8wplMonUmGtXtm4WqfVeaMRI6lv0yFGV41 dF/wGdX2oMui9sll1g3uElbUjC6WZ6tu46lTlQxqwEUgtZRxxFOANlEWwxQYL/To3X0qSM YS4X1FI4dTuFjzk7xsLoxvIStO54wCE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmx.com header.s=s31663417 header.b=lrmPSCYD; spf=pass (imf28.hostedemail.com: domain of quwenruo.btrfs@gmx.com designates 212.227.17.22 as permitted sender) smtp.mailfrom=quwenruo.btrfs@gmx.com; dmarc=pass (policy=quarantine) header.from=gmx.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721426313; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ey0LPAaCK2zc899oZ6nd5JXfenvs8mTMm4+ql0q86h8=; b=7HNUnlHIIGz3mgxUdFTHHeHbllxsQWgQimxIVzA7bn+hd4pJqc1vUqGGiQX4wUUqhXauRf Nsnz9dluMg0CZJvRmWCjRgEI6dizVxCl+3B0fKHVbEyk32/1AkEkcq38OQzW87Fzx+PTQx RmkPAbZRs4lKE5pP0IBX7pKQHwyvWQQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.com; s=s31663417; t=1721426331; x=1722031131; i=quwenruo.btrfs@gmx.com; bh=Ey0LPAaCK2zc899oZ6nd5JXfenvs8mTMm4+ql0q86h8=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=lrmPSCYDNKKSHUNbe4ktxjScf/FUIiVBLCeu5WjkiooTVVSXKRh+B/mpSbqi3bqB W9heaPWPeVw7XuS3+vwGum43SChcqpkyAwIPKI/nshL0D03ctl7ySed1dCX4hdvsv O2+rDAChAnzuCu2hadnsQ1aNsrlz5qKDaQuHM9rddGKSx/kqx8na4Pzk+qsbjHXph HVYxI0WBksnXBuJlC4dBa1Y8wZxHs27aHZUwTgCzEZdd1PJ0CD2AjascxxyP582xZ FnwSwPQ98j8WjoILUnt6/6vNaE0zO5KRpcBeJOi7X+IeMN6P9z/xC49brJLacQf6/ Qdndc3/Cw4dWsvY0Xg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [172.16.0.191] ([159.196.52.54]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MQvD5-1siuGj3Svn-00S24k; Fri, 19 Jul 2024 23:58:51 +0200 Message-ID: <54b7d944-37eb-4c3f-a994-13212aa3ed13@gmx.com> Date: Sat, 20 Jul 2024 07:28:45 +0930 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/3] memcontrol: define root_mem_cgroup for CONFIG_MEMCG=n cases To: Michal Hocko , Qu Wenruo Cc: linux-btrfs@vger.kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org References: <2050f8a1bc181a9aaf01e0866e230e23216000f4.1721384771.git.wqu@suse.com> Content-Language: en-US From: Qu Wenruo Autocrypt: addr=quwenruo.btrfs@gmx.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNIlF1IFdlbnJ1byA8cXV3ZW5ydW8uYnRyZnNAZ214LmNvbT7CwJQEEwEIAD4CGwMFCwkI BwIGFQgJCgsCBBYCAwECHgECF4AWIQQt33LlpaVbqJ2qQuHCPZHzoSX+qAUCY00iVQUJDToH pgAKCRDCPZHzoSX+qNKACACkjDLzCvcFuDlgqCiS4ajHAo6twGra3uGgY2klo3S4JespWifr BLPPak74oOShqNZ8yWzB1Bkz1u93Ifx3c3H0r2vLWrImoP5eQdymVqMWmDAq+sV1Koyt8gXQ XPD2jQCrfR9nUuV1F3Z4Lgo+6I5LjuXBVEayFdz/VYK63+YLEAlSowCF72Lkz06TmaI0XMyj jgRNGM2MRgfxbprCcsgUypaDfmhY2nrhIzPUICURfp9t/65+/PLlV4nYs+DtSwPyNjkPX72+ LdyIdY+BqS8cZbPG5spCyJIlZonADojLDYQq4QnufARU51zyVjzTXMg5gAttDZwTH+8LbNI4 mm2YzsBNBFnVga8BCACqU+th4Esy/c8BnvliFAjAfpzhI1wH76FD1MJPmAhA3DnX5JDORcga CbPEwhLj1xlwTgpeT+QfDmGJ5B5BlrrQFZVE1fChEjiJvyiSAO4yQPkrPVYTI7Xj34FnscPj /IrRUUka68MlHxPtFnAHr25VIuOS41lmYKYNwPNLRz9Ik6DmeTG3WJO2BQRNvXA0pXrJH1fN GSsRb+pKEKHKtL1803x71zQxCwLh+zLP1iXHVM5j8gX9zqupigQR/Cel2XPS44zWcDW8r7B0 q1eW4Jrv0x19p4P923voqn+joIAostyNTUjCeSrUdKth9jcdlam9X2DziA/DHDFfS5eq4fEv ABEBAAHCwHwEGAEIACYCGwwWIQQt33LlpaVbqJ2qQuHCPZHzoSX+qAUCY00ibgUJDToHvwAK CRDCPZHzoSX+qK6vB/9yyZlsS+ijtsvwYDjGA2WhVhN07Xa5SBBvGCAycyGGzSMkOJcOtUUf tD+ADyrLbLuVSfRN1ke738UojphwkSFj4t9scG5A+U8GgOZtrlYOsY2+cG3R5vjoXUgXMP37 INfWh0KbJodf0G48xouesn08cbfUdlphSMXujCA8y5TcNyRuNv2q5Nizl8sKhUZzh4BascoK DChBuznBsucCTAGrwPgG4/ul6HnWE8DipMKvkV9ob1xJS2W4WJRPp6QdVrBWJ9cCdtpR6GbL iQi22uZXoSPv/0oUrGU+U5X4IvdnvT+8viPzszL5wXswJZfqfy8tmHM85yjObVdIG6AlnrrD In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:+rwUS6pqYSlruSzT3uI2slOzqyDeM7QHQ+J8pURnGMaSZ5Gz0ct FC5zpWqqOpXSe82Wu5LnUcHZxz1OwdDb/REVPCRE7oQtfWSRLwzkKpYFzNo7ZM3mrPbLPX+ eLYl0NkaSfUJzkyeXotBVxfwD5c00K4CNAj0zvqdqu6tz9z+2cehm6WWcKPALJW32d1d224 BP42f0OLwAW2qN8Ne1JfQ== UI-OutboundReport: notjunk:1;M01:P0:GLm5/WW0PR0=;k4TBVCug4O1/KN7+3QMogE2fpN4 NUsQ4XyPaBlLSJKYduISod1VJoBJzhKtn0rO0mVMKUeVZZuXgstfIG+OCpsanfcufvkwKUK0D 3TKFShSU74B/zEAXsTS4xwS+aNtmLTPfBoptTvX050jRlfhL1A1ImidqFAiJhLWK/zCby7hOk a1z7axN6OWNS9OCnRUGPoZ8P7RALstGs1m/MwcKDWsinzCNw2Fpd7Hg9ONXXEWK7yQPuLJJeA rfIcH3f5UwkmwPQ7Ec3bMgvPDMXjG3Ys+XsG3ygPX1McZYGST4wiXWltNSxwlDVXAg9MvBUF6 a1Cz3Ilwyy3dhfal6CrcMqDB+h5Tdnz3p16I3aVUnletYLE2QgVtVoXFtTPNNJ6wBz+3khFKu 9hT3cnIIB+fcMrWUYbgsVIdkvobTZy105vXYL8zf5zD7k63AIpC1tDHgJrw4EAyoNNuGS2v+q WnzKyqWJsYUe75OLCigZDVuiZkUmwunQ8p4z90bFUkWq9ZR2GvJjUcDOypxtc3cKZAY9FavdR uVciWuBP/cEXIPJ0Oj6pmm0oPy2J+wmi/cLIdOSA/KWZ70xOb7JhaZ14xBjyvis4mJ9qd1buX X43JblFqHCRC0AyAw3ObzNCuiKD/hEGilwGS3ZTDJHp9knsMc4FsKVCAo48MZ4wzqnfzgc85s P234k7P3cad6aJdP2kBF8Lz6N0gytUIEidTVpODcQTW3VGKL9CBd8whcoEH52f7lSUed4yENh je7V6lbN7vOgzGj/1e72so5FAJ1cNMY30V86PVFip2HW5l6UitK32RuKOutpIP3DO/p02bXSd dhnRCzErwjaROir78/5fC20w== X-Stat-Signature: 3eeo55rxhu4qomqnh5n41x1qnfgnno6c X-Rspamd-Queue-Id: 9628FC001C X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721426334-756563 X-HE-Meta: U2FsdGVkX19a8QZuPX7mQcj1lkymFaaXSZI4H61XMt+8/xn0mmvtz5eeoIR7B68gMFL7STdwurlQunJkeVk/AYYnMfPLuSohJphCq4VZYXkR9orjV2rl8lvCITcY03GfHsfkrPSmqhgbN9zlxdDltoFIWG5qwcvUyex0HsWBY42+RkW8tLzsUAYO1Ul7zghhKBvg/pClhtnpcmA55GbVJjKusIN4P8IHras85Yf8aXDOqwNi81k3IpwqqBat93lJEVIkQRyAI3NYnt5dFwFQtNl4qDq8okA6zAaAJvLGT2tLm1Zn4I5vCYlfH8yOlECIoTHjkmnVOyl0PYJcWbOdZCULyke03gGdChOOjmQsAcKrPQ6femiIM00w4YXNbWnFiNdImgGlI8ckdwynY0osOOJzcpZRmjNBlgJqsxCzGqusckZRwtH86XSQtVq6b+gB/zVv7rLUYwP9TqhSt+AXxebkhe4E0sSfDihH1hdu8QVMcT9wkziPNV9Yr6DBiaINxY8IJdFAevIGKaufvAy2kEuQtNS5tmfQyp4Yq/C6AGaDF5UaiSmb8eELwjeuxJwTt4gvuAKLeiPKgZCcJwiNk2ZLx+owAtGEgfld6olC9JAJx4uZWfxPvMumlMgKCSQhBJExmmxylxb9Mv+ZmYW9Ihz/a1+XWvYWzRJp7TNSk9dIIJ930ppswSOklPakqc/GAQ2zOR28uvGfP4rN5QcBBCTYwkueaPixYvM+9WMjx3qfAzoj/KhrC/yGdoX3dAASeiy9HngXRQ6vuWPedvsGOJfUP+HLmwU/ndSICYbOCVptBVhZhZdIICf/USIKB86ds4VcShrVTuUieSOnTPCpmb5EppaLSaOOb6Wo0EQsA87s8RC16gfkqHedAEx/8yqKPizhqwTvde1K8IO+d3dQvL+UPO9/q68LBosHSNB5jd2aexkzdd/3oDV0Kk1g3vudGZVq9GrgfwF1LvCF9Hm L/6fVtQ/ 6RSTrlKR8q1uRbNRUtrO0oI7SaJJKgxNWbaKt2dd8JzCfQQHRislmhZWgOCfBMphpc85MThC2bPA2nQUe9gmY32cmIyRM/wlnzue3fOABavCJnmLIMxY7h59UM7Fbp5oU1TwD3NpjwbuhkwIxPcx2k/+3EHLLne2DV7NC8ilrlHugL4uIykQCYBMlZ7khwZ8DL2rTsyNdsb1zgErT6tFc0YMrVQpGJzjD0Ge7MzbhbeL6mTlVSgidqf2y6ngT+7nh6DLMlFU4gH1MX7vf+S6gVyIuxtII2hnzylZGMrViARICgSMextzYPJ143uyUtxgvZhxG099mlgMhQLrmRsHMV95ofjKkVn2C2rhFkGMRFaExd6CLpfz5d7D11Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: =E5=9C=A8 2024/7/19 20:43, Michal Hocko =E5=86=99=E9=81=93: > On Fri 19-07-24 19:58:39, Qu Wenruo wrote: >> There is an incoming btrfs patchset, which will use @root_mem_cgroup as >> the active cgroup to attach metadata folios to its internal btree >> inode, so that btrfs can skip the possibly costly charge for the >> internal inode which is only accessible by btrfs itself. >> >> However @root_mem_cgroup is not always defined (not defined for >> CONFIG_MEMCG=3Dn case), thus all such callers need to do the extra >> handling for different CONFIG_MEMCG settings. >> >> So here we add a special macro definition of root_mem_cgroup, making it >> to always be NULL. > > Isn't just a declaration sufficient? Nothing should really dereference > the pointer anyway. > That can pass the compile, but waste the extra bytes for the pointer in the data section, even if no one is utilizing that pointer. Thanks, Qu