From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 243CEC77B7A for ; Wed, 31 May 2023 09:08:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 943266B0075; Wed, 31 May 2023 05:08:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F2956B0078; Wed, 31 May 2023 05:08:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E2B38E0001; Wed, 31 May 2023 05:08:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6FC436B0075 for ; Wed, 31 May 2023 05:08:57 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 35B1AAE38D for ; Wed, 31 May 2023 09:08:57 +0000 (UTC) X-FDA: 80849975514.02.F7C27CD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 5A03F40008 for ; Wed, 31 May 2023 09:08:55 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=E4gFHy8T; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685524135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JubkPk4gPDeN9b7yimB7oHd7wZ3DFjoxys5W0ASlmQk=; b=MZESE/otEmUrw+csPKbdg3driiakq23JZhK+XE85ayRtefq+1dXGkll3CvPSs5Fracbjvk PrNsHY1XGdhbC5nhu2LwhsfbquEd5CpzNoLm7rdIQmyyLjongRqqm5SayDfR9XhP8UklLo nXRGb+rw3te/FJdVhnE3Sdn6+oc2+L4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=E4gFHy8T; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685524135; a=rsa-sha256; cv=none; b=rEk6iJOncXpWTPIgf/o3iyleFJWezf/4j/yDOtamvecMKYiDSYHqde3HRFg6zTWFHZNPKR 21PufUkOM414I9n7Ta5El7UvE/ndaPNOqAtR7Fj7GpglNy3avCw3g9Xojci85HiMEUJt6U jdmwFlGo6Um6hs32RMs/yyW2RawgJdw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4FD02634A9; Wed, 31 May 2023 09:08:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 414AEC433EF; Wed, 31 May 2023 09:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685524133; bh=axEkNRQxOw2SsrEsKVeeUf3LFs4+Ez60j1wdXzIL3N8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=E4gFHy8TJgSROxww8OVcO6e3p3dd7vo4i5KSweH0NOnDdcWZRx6VhzGl/tF5voshC UdmJJJ49kI5kmDv8uxIQcXuTasv67aBuZrAX/nFEXNjew8xfFV3/Tv9o4t/50sX560 4osRYtHft7VGmBwOugY2d3gckgf798HrCVdO8An/XzC3FA/TtXWsZVzkSXWlRu/3m1 UcmBmqSm6PgzPnQ6YZuJR6SC10cam6xiaiwNt5PMth2Lvq3oHSe/HVHMr8zaZl9OXp N3UA7Kz7at7Iul2UL15fIZVbY2+75CmNbSF/oiTJWoy68QDXpRnZJj8Do8LRZ7JegV xaP9uJgHiusmg== Message-ID: <54b4a89c-4023-526e-62e3-8f7fadc2861d@kernel.org> Date: Wed, 31 May 2023 18:08:50 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 09/12] fs: factor out a direct_write_fallback helper Content-Language: en-US To: Christoph Hellwig , Matthew Wilcox Cc: Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org References: <20230531075026.480237-1-hch@lst.de> <20230531075026.480237-10-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230531075026.480237-10-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5A03F40008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qgk3oxyio5wpr74fyfd8agxxecb5sukf X-HE-Tag: 1685524135-417196 X-HE-Meta: U2FsdGVkX18WqmuGMyq/qzMAUr7894qiRuOqfDfOrbdyAGJe9yWA5sq5+Xfu/9/FXFLyLH+47fNaqJ1IgblGbociVN2d4lYfbtVW23yt95sRVrllkg9+4R5fYSQeIduj4sYpVQKrwAZcPMEK03HFGrcb4X+s67Jb+M58sDQQh0cAjkhmOLH/l+b7SHVKCOigqLjsMTbLizv41MxvLwJRq1vw9RECSHBgRo+/WdQKXCQFmdm0wkF1NxvvrnbDhi37DtTICMs6A/irM+irLrffjrILBQfD4XGyBL1x7uibdN7JUqKlGp2sF/I2/bv4DjnfTNUG1IMt/RoKIW2NoDc52sI6i45oJH+FqwpPAkxriCoGs1+o5xx6kvkU70DAdMwnAYAW+q8FjTLH8Q1syZKaUO6uvUdzXhciTEC0+ZcatFzvBu+5ezF9dTo+GSIk18xDSQ+D+19/HT+JmapCy0URrx4/9cy/Q9XszmUcu0Vpr0/P5MK8ae0qLnyw2wyapNAE2zliqJpBTd1luwcLQuFQtjhfwN3mT6YC33Kdpvi0gjG+ETtF2oLiMaB41uFa7QMJYXqqyPoyDuQxL9D1UWXLFoJRXaOH7DD0jL/Nxmt1bN+Mpx+7LotnlLwFovGQ/14HhCfcCYBSdpk6CPddojqVsmZSqDkEG+REbVzWHFkgveZhN6CjpyFveyhz/8c91dMShSydVvRLwoIVr26WYvccplkxx7gj4cKrjL6qGEcco8YE60lohqKlCp1qQjQZNdxEJBNuYV6YdZRMYxEF1EK++0dIazzI7uVPgklEzCYTEyABiqsU489romiF9eUZk75PHMU0Ii9hPERlnyXqcXy7Ex/waK18soI1DtXSPiN+YRtGgk4LrU6DVT/L3It/e6TFAYSE8IkFYAA+6W1GuWvpWBfQH4adHc4ILXK1qGkF8Sihesx/7nCt/3jGunj2GsLFQI1lwPOMljrEi+sT82k UaxQJN7T hdjUBSHZ4QTeMdMFGAwIxAB8UMfe1Ytr3JdoIVEXONsMdPOlO/ouOrrm0C3GzEtgCdVn94w8aVYKvhjFNvccmS5DSXda6eGeyReDvrQOndgAJ7VSNcluJ1/fESmdphaq/uyA08MTOVGCrttP2quCxzJiPhu3m/mUC8TNUfIhPWmQ3EO4y5pP/+V2DA2U1L/kCbm2y79jr9bjq4Nmr2Pl4fjAWVkoxKz4pKZ5kWTWysY939amrq9bQnDMuNNIT6w2q2V7s0Ud5Btp2JGlzifpNTnFpYwnYstuM3oHdgnMeicHd6peKAikrynv9JVnuOgO/Uq63dteojP7qs825MfIrcIAPdCRFLYkr/Cq2/fYinFunZIzjFyCEQangH4pVi4DxR1+5uCnhq2CS8vSq+YsZFYp5GxPYoLszCudk1sGmiVdBGFUsMee8x105aQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/31/23 16:50, Christoph Hellwig wrote: > Add a helper dealing with handling the syncing of a buffered write fallback > for direct I/O. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research