From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D941C36002 for ; Wed, 9 Apr 2025 10:23:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85D36280060; Wed, 9 Apr 2025 06:23:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80C5728005F; Wed, 9 Apr 2025 06:23:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6ACD6280060; Wed, 9 Apr 2025 06:23:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4B29C28005F for ; Wed, 9 Apr 2025 06:23:36 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6815F1C8FA7 for ; Wed, 9 Apr 2025 10:23:36 +0000 (UTC) X-FDA: 83314118832.30.53DAB47 Received: from fout-b3-smtp.messagingengine.com (fout-b3-smtp.messagingengine.com [202.12.124.146]) by imf16.hostedemail.com (Postfix) with ESMTP id 6101F180013 for ; Wed, 9 Apr 2025 10:23:34 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="J Fz0emP"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=wEzYM2Pn; dmarc=none; spf=pass (imf16.hostedemail.com: domain of kirill@shutemov.name designates 202.12.124.146 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744194214; a=rsa-sha256; cv=none; b=eUt1qXb4iB/zgK2hY+t29jtW4HUwl3ySlExh25/jcz9ND256OOmK6YHuykiuhM2jy1IhEs P5Qcq7ogdcoVb78eBjm5AoaAiePvOcNIj3vLd43cbwlVqKhDdDH2LT+2IYIKFg/xBTgQf+ GglknYR+JLF6srIknYzmeLr8TUkNQ7M= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="J Fz0emP"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=wEzYM2Pn; dmarc=none; spf=pass (imf16.hostedemail.com: domain of kirill@shutemov.name designates 202.12.124.146 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744194214; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WW5S0beDMkjLQjYoIeV6+54mnEU4UlN+IJCaQTuUFk8=; b=fotdYercfjkrQGzcMHND3KBFdcTtzhMPOUuAv9o5b/TZEJxgqvturetPNgJc/zFYNPqyGN +QsQd8eqjuknbwDTsUffZNF+u8lnaxx1EQnynZu2ATq+IEfSd+tbDNr0P7VZ9rpveZeeFR /pO6mzj33zgEJARd5iMUAm4zTPSACJ0= Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.stl.internal (Postfix) with ESMTP id 606351140165; Wed, 9 Apr 2025 06:23:33 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Wed, 09 Apr 2025 06:23:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1744194213; x= 1744280613; bh=WW5S0beDMkjLQjYoIeV6+54mnEU4UlN+IJCaQTuUFk8=; b=J Fz0emPtwRkAu+Pc5+o+XGsLQNT7GiHWtC4EF9QXDg2xDGrQSv0eQt0Zcuy9uNmaC Q5v424B6HjQWccLy9sA7JUXECynGnuXuSECEsyG2S5krRBwmMBVEjoJh1wOKrWvd VfSXcF6Vx77xx3sKPvd7hwibKz5L2PZoOj2BF+9A63XGjZzvZg6hsf3LlOftO5de kFC8An+qWRzMmHNDSKy2X1argi3G19DXb1dPuVTxTIrSxazbQGUykHiKlZ3BdunO jjzqw7Y9xOBddGveyNqH680cbfh5O4ZvvQabPL5fUf9OvK4+3L3/NiGW1hG8dbvs gS9u/7ua8NtHREA68cVPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1744194213; x=1744280613; bh=WW5S0beDMkjLQjYoIeV6+54mnEU4UlN+IJC aQTuUFk8=; b=wEzYM2PnIdiiXBor2hcMB6AIpTw3qe5kyloKu1SNWRmYbncQOPz ovg3Zz5/un1hFSYiLK8BZfBmT6Au93ga/6eS5GsJuRWwMkMbMOg8bGtZ02gk2k/b 7MR3wjAfDT2ahtCdX4bzdnlpiFAOlIbT/3oteajPDEGn2bzWc6fyfibzJosTnZgP 7x8420pjN5EW3hZnEq3hbBiS36xy7X8Ar0nSkh7wYdqXnU1M8swn3newpTvgIuOM POc0gHN5zjxdITnKNZA8R6+pftvrJvGhONmUIpilF1+HIq/xmXR/nzE96GkFfW0e Zt/6eP6+FFgiPaADmA/vSwA7S9ithw64zfA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvtdehjeegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtsfdttddt vdenucfhrhhomhepfdfmihhrihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilh hlsehshhhuthgvmhhovhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeffvdevueetudfh hfffveelhfetfeevveekleevjeduudevvdduvdelteduvefhkeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghm ohhvrdhnrghmvgdpnhgspghrtghpthhtohepjedpmhhouggvpehsmhhtphhouhhtpdhrtg hpthhtohepuggrvhhiugesrhgvughhrghtrdgtohhmpdhrtghpthhtohepkhhirhhilhhl rdhshhhuthgvmhhovheslhhinhhugidrihhnthgvlhdrtghomhdprhgtphhtthhopegrkh hpmheslhhinhhugidqfhhouhhnuggrthhiohhnrdhorhhgpdhrtghpthhtohepvhgsrggs khgrsehsuhhsvgdrtgiipdhrtghpthhtoheplhhinhhugidqmhhmsehkvhgrtghkrdhorh hgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdho rhhgpdhrtghpthhtohepughjrgesrgigthgvnhhsrdhnvght X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Apr 2025 06:23:29 -0400 (EDT) Date: Wed, 9 Apr 2025 13:23:26 +0300 From: "Kirill A. Shutemov" To: David Hildenbrand Cc: "Kirill A. Shutemov" , Andrew Morton , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Daniel Axtens Subject: Re: [PATCH] mm: fix apply_to_existing_page_range() Message-ID: <54aymye7ctvyoaxdoge3h756tnhd57kzy4lnpggvydohtrxy45@ruwh3ni4yttq> References: <20250409094043.1629234-1-kirill.shutemov@linux.intel.com> <00a37819-b2ae-4399-b21d-86339059c46a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00a37819-b2ae-4399-b21d-86339059c46a@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6101F180013 X-Stat-Signature: fk8e9ukmr8heo8ufjk9mmij6r11akkgs X-HE-Tag: 1744194214-717352 X-HE-Meta: U2FsdGVkX1/SiMxfheF6P3aWVZN6qI45ieUiBmcj9kTY7srsE6vryVII0RI6G1nHhJHS4xs2bzOLVUdARzds34ijA6jlVaYLhToJn5tGOYUiA4x8Xcy6a/h2qyMgc6HCQfo2Bz4qRg5esltFNJU+i17kwLBRdGPstwyLLLKfzRCswdSpbQ7ljSIIUturgPYBoI9wkRyq83UZx6BeRCvGAJtX1p0FOLOsW4P5yfS2JmeOR9ZcsytxfvoD0GKUBrh6b0cauqNzzQEYN10+UPzkIvLEeYfNPJB377ZytzZTCMK1gqCLtOmbAZpeDg3K9cl6niPZrXX0zxByk5oAdU25O6h6Wt8OEn8MAJHW5qy8I29MjUVfY0R+Ff545Q0oVa/hGq5itAt/1izGFlOCxcUE8bhxcRuxdrE+1n6AVuDeEHSoRElKTxSckTtoY4kfOyhHIeMjy/ZQQtAwwRXelQZpv5AsWn17kPiqNEoGhkHYf9a4Tdj0HFxcyVlIJ9Juavh6aUXg9fFb/F4VxrmWSVp3lAP6NTTbe4VEY0cibtnjUYAYDXeo3x81UbfcGz9mpeWpDprBHqCEbTYG210BqZZVHN/K+YlBlFCH4hjcPBI/1NK8yFvGqDqT4XXFz1md2cOQ9Nqw+bv1/pWuTk3BLWpg3QeCUeCO8yI6y8X4lplZ1OV7FsghQQp0YIcdF632KJ2UbDAvepm/RqpzvTvj4QPpAlFMx28LgYYoqCjZXZkamNs7FYVp+gwiMzfLxvXVmIZAEHO1t9l1iaDQPmDgyimxUFNZfT2zcnUqgkIPr1xVoP3YMEPjcTWsYQs53GNQqJZzkBL+hIQOd1cbPH/y6CR8MJb+91E51hzJytsRURh+9ROJd72cUlyxeHVmWjJqRFsCtM3y0lndWpWdAhH4IFQu/NmAt7WVV89sgzn3W160nxILJtO2iwBYaeJyW6bhHhIVD95O62OJrSU8asF1Mmp oLaKD8aQ rR7lXPjLpPrzVCbFQ+J9cskstqk54fRmFSzW21rru7rrr8bKsh6n8j9BFtCJ8zGr7eRq8PlA2pADgh2NWiKnfk4syaAvIwDV7SSWfFHYX7CyKMNbJJfh/k4q/t4UGsCZsThGzBqhFZ7W7xuVxq9qtNVYiMVx0kLFRmr0CzuvFmXuh3uYcazEEIbhOzEcmjYuqKMjCv8TgwjZkXv5uOWIWxkd8EaO9W4qVGT9zNkG9ZZDMnI5Jultub8do8+HyL7U5048mS4orZZsZ0X4zsVC6rUnotDO01wga0vyGuT1QZLICRYwb86FgdMx/COYbe5plpqBP/iKkGAfSnksgASWyyUdY8zzpK5yR/cNihpl896kejz2RZE2qLD1bjiqP20S+3iEqF2RUzoeH+QXGYOXkXOX467FWeIdmR+zw2kXL4Pxk/sS4Z3R9u1WH75FBOkgdXmlMIoS+WU1QH2NYZCkppQSmirUhGx9S8HAgri19VnAgxXXu97x4VMi0X56PUrDH4OaQdyPYOkESP5M7cKGF+VsrsyHVD63RmYChfGFt+iaOQZUuYeFcduQ4fg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 09, 2025 at 11:52:43AM +0200, David Hildenbrand wrote: > On 09.04.25 11:40, Kirill A. Shutemov wrote: > > In the case of apply_to_existing_page_range(), apply_to_pte_range() is > > reached with 'create' set to false. When !create, the loop over the PTE > > page table is broken. > > > > apply_to_pte_range() will only move to the next PTE entry if 'create' is > > true or if the current entry is not pte_none(). > > > > This means that the user of apply_to_existing_page_range() will not have > > 'fn' called for any entries after the first pte_none() in the PTE page > > table. > > > > Fix the loop logic in apply_to_pte_range(). > > > > Signed-off-by: Kirill A. Shutemov > > Fixes: be1db4753ee6 ("mm/memory.c: add apply_to_existing_page_range() helper") > > Cc: Daniel Axtens > > --- > > mm/memory.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index fb7b8dc75167..2094564f4dfb 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -2907,11 +2907,11 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd, > > if (fn) { > > do { > > if (create || !pte_none(ptep_get(pte))) { > > - err = fn(pte++, addr, data); > > + err = fn(pte, addr, data); > > if (err) > > break; > > } > > - } while (addr += PAGE_SIZE, addr != end); > > + } while (pte++, addr += PAGE_SIZE, addr != end); > > } > > *mask |= PGTBL_PTE_MODIFIED; > > LGTM. just curious, did you run into any actual issues that are worth > describing? I stepped on it in my non-upstream code debugging. I am not sure how it affects existing users. > It should affect apply_to_existing_page_range() users where create==false. > There are not many, and likely most PTEs in the range they are passing are > all non-none. Or we just silently leak memory :P > Acked-by: David Hildenbrand Thanks! -- Kiryl Shutsemau / Kirill A. Shutemov