linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Sourav Panda <souravpanda@google.com>
Cc: lsf-pc@lists.linux-foundation.org, Linux-MM <linux-mm@kvack.org>,
	 Pavel Tatashin <pasha.tatashin@soleen.com>,
	Yu Zhao <yuzhao@google.com>,
	 shr@devkernel.io
Subject: Re: [LSF/MM/BPF TOPIC] KSM Enhancements: Selective KSM
Date: Sun, 2 Feb 2025 18:54:52 -0800 (PST)	[thread overview]
Message-ID: <54a56cd9-dc34-e0d1-045f-04a372b3c3a1@google.com> (raw)
In-Reply-To: <CANruzcR0oN8URqHh86HLuqfiv=pax0-eQ=3_oCK-kX_cuktUGw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3276 bytes --]

On Fri, 31 Jan 2025, Sourav Panda wrote:

> Hi,
> 
> KSM is a powerful tool for deduplicating memory, reducing usage by merging
> 
> identical pages across processes. However, there are certain interface and
> 
> implementation aspect that prevents its deployment in our use case; wherein
> 
> security and efficiency (CPU overhead - due to background scanning) are of
> 
> greater importance.
> 
> We propose Selective KSM, a mechanism to control when the merging takes
> 
> place and what pages can be merged together. We do this by partitioning the
> 
> merge-space as per security-domains and carryout the merging as part of a
> 
> synchronous syscall. Doing so, we ensure sensitive-content is not merged
> 
> with non-sensitive content.
> 

Thanks for proposing this, Sourav, it sounds like a useful topic to 
discuss.

Regarding the above, this looks like this is analogous to doing 
synchronous MADV_COLLAPSE in process context and not relying on khugepaged 
as the sole mechanism for doing that collapse?  In your case, it's 
userspace doing a merge in process context without relying on ksmd.

Is s/Selective/Userspace/ the way to think about it?

Does this require a fully cooperative guest for it to work properly?

> Our overall goal is to optimize the memory utilization in a virtualized
> 
> environment, wherein there exists significant duplications across guest
> 
> instances (e.g., kernel). With the better ability of the operator to  group
> pages
> 
> as per security and similarity, Selective KSM improves security and
> efficiency.
> 
> Other than virtualized environments, we also want Selective KSM to work
> 
> well in containerized environments.
> 
> An example API could look like this ( Alternatively we can do it through
> sysfs
> 
> without adding syscalls):
> 
> // This feature shall be gated by a KConfig: “CONFIG_SELECTIVE_KSM”
> 
> // Create a unique identifier known to userland.
> 
> char *ksm_name = “some_name”;
> 
> // ksm_open() creates and opens a new, or opens an existing, ksm partition
> obj.
> 
> // flags is a bit mask to determine if the merging is sync, etc.
> 
> // KSM_SYNC: Carryout synchronous merging (no-background scanning).
> 
> // KSM_CREAT: Creates a KSM partition obj if it does not exist.
> 
> // KSM_EXCL: If KSM partition obj with name already exists and
> 
> // KSM_CREAT is also specified, return err.
> 
> // modes is used to handle permissions:
> 
> // O_RDONLY, O_WRONLY, O_RDWR, S_IRUSR, S_IWUSR, S_IXUSR
> 
> // On success, returns a file descriptor (a nonnegative integer) and
> creates the
> 
> // sysfs path:
> 
> // /sys/kernel/mm/ksm/partition/<ksm_name>/
> 
> // On failure, it returns -1 and sets errno to indicate the error.
> 
> int ksm_fd = ksm_open(ksm_name, flag, mode);
> 
> // Destroy the name. The named object will be removed only after all open
> 
> // references are closed. On success, ksm_unlink() returns 0.
> 
> //  On failure, it returns -1 and sets errno to indicate the error.
> 
> ksm_unlink(ksm_name);
> 
> // Trigger merge. Only valid if KSM_SYNC is set during ksm_open().
> 
> ksm_merge(ksm_fd, pid, addr, size);
> 
> // Trigger unmerge. Only valid if KSM_SYNC is set during ksm_open().
> 
> ksm_unmerge(ksm_fd, pid, addr, size);
> 
> With regards,
> 
> Sourav Panda
> 

  reply	other threads:[~2025-02-03  2:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-01  2:15 Sourav Panda
2025-02-03  2:54 ` David Rientjes [this message]
2025-02-03  7:20   ` Sourav Panda
2025-02-04  9:44 ` David Hildenbrand
2025-02-04 18:21   ` Sourav Panda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54a56cd9-dc34-e0d1-045f-04a372b3c3a1@google.com \
    --to=rientjes@google.com \
    --cc=linux-mm@kvack.org \
    --cc=lsf-pc@lists.linux-foundation.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=shr@devkernel.io \
    --cc=souravpanda@google.com \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox