From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 105A6C4332F for ; Tue, 12 Dec 2023 06:59:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88B976B028C; Tue, 12 Dec 2023 01:59:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83B596B028D; Tue, 12 Dec 2023 01:59:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7026F6B028E; Tue, 12 Dec 2023 01:59:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 60F776B028C for ; Tue, 12 Dec 2023 01:59:23 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 20B1E80974 for ; Tue, 12 Dec 2023 06:59:23 +0000 (UTC) X-FDA: 81557265006.12.B0BB062 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf03.hostedemail.com (Postfix) with ESMTP id 3DAA32001B for ; Tue, 12 Dec 2023 06:59:20 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=0ktkwAIO; spf=pass (imf03.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702364361; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YTQK+pIPXgnigoS9lJtXq/Umk1DYPETwaZ1oRGAmnX4=; b=Qg7BXBdTHszuMA9kqQM1BQNAoYEyTC2Lv21m8/hgDiY36F0m0hhWD5GHBV2ouktX+eZDfo CFO563XjrPo45GyGPPRG1T7yw022zEQZfScGwNCh582qpQ4SkH2eXb2t0dWaG7IsxkP5wI 0ZvVaNH3/gyPEEGHGj8hADn80fTqKgQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702364361; a=rsa-sha256; cv=none; b=vw/GNwi0rDUjypjLVRKUxh++4J6nAQpw9QRRPI6KvhfFQgnJf5PdbHp0E2WZDP6EQurSkP EuWdhDnA4X9lIiuhEwxTsoq1Yu5oJTefTWwWnUdNZ+DBKLQCLU2nv0IE7dTiFXEkRbES94 aUY0lajSZ97Mq9VdFj1KtmINqQFkdrY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=0ktkwAIO; spf=pass (imf03.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702364359; bh=F41feDTLD6EeSRJQf7rvDdapR+nQMsHfWA39oKGkLZw=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=0ktkwAIOn1gHRVA2zhrHIyNM2u35YJz/y5vQZFlw6eFQbWsCHcaZo3qZv8LihEq9A /2yEYGNfbCpbvzn+Xbw4ZGhQMZ1X0nrOOUs8UCu79FRTAltvEmzsIuA1U81di7r9xR TykJ4WuqkOCCnrLjXiVqN9fr55Vd08Y8nZ3AGT9qpv9t/m3mQU/yeYvfxeEQ7nhPdT 7+nBysn+06H6syKxsX5U4s7iVIXYD756YTfSXuDtnEefCci0uNFoo7XTvTynasmLvR wU1sBknUJ5aeFVg3DStDQhk/rznCeo5rihTztnZ0gB7AG7wjcZeaCycHBsf1lKUncw 3pGxxuqMbIbEg== Received: from [100.96.234.34] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id A2D7E37809D0; Tue, 12 Dec 2023 06:59:15 +0000 (UTC) Message-ID: <54a02895-26e5-4113-84f4-3f04358f09e6@collabora.com> Date: Tue, 12 Dec 2023 11:59:12 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , David Hildenbrand , Peter Xu , Nathan Chancellor , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML , Anders Roxell , Jonathan Corbet , Peter Zijlstra , Andrew Morton Subject: Re: [PATCH] Revert "selftests: error out if kernel header files are not yet built" Content-Language: en-US To: John Hubbard , Shuah Khan References: <20231209020144.244759-1-jhubbard@nvidia.com> <0b35fcbd-ce8c-4c12-9725-01f18ade9fc0@collabora.com> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: spbwezcddjth86hwm3bq4bq8cqjmkhqu X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3DAA32001B X-Rspam-User: X-HE-Tag: 1702364360-755453 X-HE-Meta: U2FsdGVkX187OC7CYXERMnOQABU/pndLeHCBdTAYx5AjZUiBwXisCWmY1PXIh0ss5Z4MUaVgfklfgSuAUXZsMH3WHAO0GPxyS5KWJE5hWh1ggmKNGw/CBEvxH5xRw1kWDVTaj4hBm8ddibvTL66mi4J/9yautWkpS5tGKHrk1gtqVOcIWOGZpVXWA7TxUbyXCyzvOUEzqlJ7rXmCyxuUoKpiBDMLxpXhpZZrqQYVOTODWYCrE+Oyr7CavopN8ZfrLqgfG7R5VbygLsOA/EZ68zuDPOGpKV1cy28mBTVC1VadKPGoVjCBzSlsuWaxjXxyAZio+VCT48heqpoZ91bKBdIwubM0dZk2fu3xbR7WkhOSFlXzeXDacbBqHspED1k8qnEqBwUog9myQz1JT0CTOb2T2tsqmWyOmghKqid2LAU61SVK6kjJ0Qbizn8yqHKX3psfTtmAmkDK4HRIGe47b1BNbO7etFRbYVO/P2rZdmAEIu06n1fDinpTvdBmLIomseJYzfrwO/ByT3Uk7HT/JdgjO7nTPz+Jawkzgqu1myoDHHyXVHJceodEHZk9OopyB13NrMb2eHj8LOzf6dscq+B7vp2ySNkVjXE2Ez4c0V50w1LOYP5e5NfMRtgbpS8e6aTp1KmBait7rcHTRBaSV2SCIaD28Iz832J86nv0iqdJ9a040KVzyn4YrYVN/IhBauyZH44V2jv0FH60G4HWq+STjd8PafwIsY+tFIk6f5FBO3oz7Ijq5u3pVN05u9T78wwRAnXj2mv7b/ZNjVebkrYCSIHwzRCUTInHPfL4diwuosrr7l2DytQrz1o6oXck1CJEU1XxWlmMKeu7xMo7LyIQDjT8ulYKS3Bhk4TkdaLvugkILNywgNT19sAuCuBoAWXrUDoXBWn/G6af3Gahl0il38fQOHvjPJ8xd617EK58CwnlC3nJTKvF/FHYV2p0q8nTiE5w37+KJC9hu1B LPOTiHLC ikdaftTvOOmWzjF7C16aM8u2DjdCUcGisekjzlpHSMPCXWZ3+I4LUU9O8OuSAelFnMesByaGVtQvpTaMdX8VISiQyHbC+SHxqWBbQNsFAP6WnU7C6LXJ2dqyepINegiE53ofKrdfpClqUNUBDVUp4qOeCG5WehCsNE5FP/AMkzzXIxfjxhep9cZ8+LXtNXeZQ9BiLwSAA7v05gK4vtgh+/RJMSWNqdrkNr8COOoFse5algqnNi3kFTyLDN0UQj2OcgjoG7elThCnBm2Cx/ahP/n4ZDPQ/n4oJcTSB/+wde1VVbpZ40x6du69yw5mw5vikzGzp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/12/23 12:00 AM, John Hubbard wrote: > On 12/11/23 03:00, Muhammad Usama Anjum wrote: >> On 12/9/23 7:01 AM, John Hubbard wrote: >>> This reverts commit 9fc96c7c19df ("selftests: error out if kernel header >>> files are not yet built"). >> I don't think whole of this commit needs to be reverted. Lets leave the >> warning message as it is and just remove the condition to abort the >> compilation. >> > > Hi Muhammad! > > If we do decide that "make headers" or something like it is required, > then yes, this patch should be changed from a revert, to a "warn instead > of failing out" patch. I support this is as most of the times when the latest headers aren't installed in the system. Hence the build of all those kselftests would fail which require the recently added macros. There is no workaround to build those tests until `make headers` is done or the latest headers are installed. The former is easier. If we just turn this into warning, most people reporting issues with `make headers` would go away. They will be able to build all those kselftest which don't require latest headers. For example mincore kselftest gets build without KHDR_INCLUDES. In case people want to build failing tests, they should add #ifdefs to the tests and submit patches which is idea 4. > > First, though, I'd like us to choose a design direction. The patch as > written is intended to put us on a design that does not require "make > headers" before building the selftests, because that approach would work > for all the cases I've seen so far. > > If we want something else, then David Hildenbrand has listed several > ideas, and I've added a 4th one to the list, in [1]. > > > [1] https://lore.kernel.org/3eadd79c-c02a-495f-92c0-0315046ef59f@nvidia.com > > > thanks, -- BR, Muhammad Usama Anjum