From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by kanga.kvack.org (Postfix) with ESMTP id 7AA956B0038 for ; Tue, 3 Mar 2015 04:22:31 -0500 (EST) Received: by widex7 with SMTP id ex7so19960780wid.1 for ; Tue, 03 Mar 2015 01:22:31 -0800 (PST) Received: from service87.mimecast.com (service87.mimecast.com. [91.220.42.44]) by mx.google.com with ESMTP id hk9si281995wjc.117.2015.03.03.01.22.29 for ; Tue, 03 Mar 2015 01:22:30 -0800 (PST) Message-ID: <54F57D4C.9010909@arm.com> Date: Tue, 03 Mar 2015 09:22:20 +0000 From: Vladimir Murzin MIME-Version: 1.0 Subject: Re: [RFC PATCH 1/4] mm: move memtest under /mm References: <1425308145-20769-1-git-send-email-vladimir.murzin@arm.com> <1425308145-20769-2-git-send-email-vladimir.murzin@arm.com> <54F513C0.4000706@infradead.org> In-Reply-To: <54F513C0.4000706@infradead.org> Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Randy Dunlap , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-arch@vger.kernel.org" , "x86@kernel.org" , "linux-arm-kernel@lists.infradead.org" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "akpm@linux-foundation.org" , "lauraa@codeaurora.org" , Catalin Marinas , Will Deacon , "linux@arm.linux.org.uk" , "arnd@arndb.de" , Mark Rutland , "ard.biesheuvel@linaro.org" On 03/03/15 01:52, Randy Dunlap wrote: > On 03/02/15 06:55, Vladimir Murzin wrote: >> There is nothing platform dependent in the core memtest code, so other p= latform >> might benefit of this feature too. >> >> Signed-off-by: Vladimir Murzin >> --- >> arch/x86/Kconfig | 11 ---- >> arch/x86/include/asm/e820.h | 8 --- >> arch/x86/mm/Makefile | 2 - >> arch/x86/mm/memtest.c | 118 ------------------------------------= ------- >> include/linux/memblock.h | 8 +++ >> lib/Kconfig.debug | 11 ++++ >> mm/Makefile | 1 + >> mm/memtest.c | 118 ++++++++++++++++++++++++++++++++++++= +++++++ >> 8 files changed, 138 insertions(+), 139 deletions(-) >> delete mode 100644 arch/x86/mm/memtest.c >> create mode 100644 mm/memtest.c >=20 >> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug >> index c5cefb3..8eb064fd 100644 >> --- a/lib/Kconfig.debug >> +++ b/lib/Kconfig.debug >> @@ -1732,6 +1732,17 @@ config TEST_UDELAY >> =20 >> =09 If unsure, say N. >> =20 >> +config MEMTEST >> +=09bool "Memtest" >> +=09---help--- >> +=09 This option adds a kernel parameter 'memtest', which allows memtes= t >> +=09 to be set. >> +=09 memtest=3D0, mean disabled; -- default >> +=09 memtest=3D1, mean do 1 test pattern; >> +=09 ... >> +=09 memtest=3D4, mean do 4 test patterns. >=20 > This sort of implies a max of 4 test patterns, but it seems to be 17 > if I counted correctly, so if someone wants to test all of the possible > 'memtest' patterns, they would need to use 'memtest=3D17', is that correc= t? >=20 Yes, that correct. Additional patterns were introduced since 63823126 "x86: memtest: add additional (regular) test patterns", but looks like Kconfig was not updated that time. Do you want me to fold updates for that info or make a separate patch? Thanks Vladimir >=20 >> +=09 If you are unsure how to answer this question, answer N. >=20 > Thanks, >=20 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org