From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F5EFC0219D for ; Tue, 11 Feb 2025 21:17:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80F396B007B; Tue, 11 Feb 2025 16:17:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BE6B280004; Tue, 11 Feb 2025 16:17:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66097280002; Tue, 11 Feb 2025 16:17:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4C6C36B007B for ; Tue, 11 Feb 2025 16:17:32 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EE8ED47EA5 for ; Tue, 11 Feb 2025 21:17:31 +0000 (UTC) X-FDA: 83108925102.13.1CC2C9C Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2045.outbound.protection.outlook.com [40.107.95.45]) by imf04.hostedemail.com (Postfix) with ESMTP id 3D92940004 for ; Tue, 11 Feb 2025 21:17:29 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=SXIX2iSx; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf04.hostedemail.com: domain of ziy@nvidia.com designates 40.107.95.45 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1739308649; a=rsa-sha256; cv=pass; b=q9HwrOGLeTJhRyLsZsEAYhv7jVFbh4r2pwQmoS16Kd7QOuqMCQ1t2UYr3OFome9lEOP/rY NmnFe6kQIY8WJnjXP7tcUvF9bJTg7LGxBL4Rl2BPSJp25YIrpJICbQoFU59BldkdjQTBD2 TbL1UDtksDrJLgsj+Yu4DyUDKr1MZPA= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=SXIX2iSx; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf04.hostedemail.com: domain of ziy@nvidia.com designates 40.107.95.45 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739308649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ERVZlYgengVxIF07q5Nd+c+RZsHndThMhLBOh5jIZX4=; b=okEdLUsh3eZk39dXiJEPDwd4mNVm/x/qgqMsNe5HQBzB8v93+TfO+HjGSuUsabft1y9/cv zujAU1u1W66ioYHBOCCIzpGokgOysGeFyN+MPuot30y5p/vTda/zzPZ6u1aM74nTkEZISC UGRg/3Fbafy6rOyXnrXeokRWOVIvCxA= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=maQzNRy72nVnOp5Jx9CIRf6GLgbrf/7MZrYWlvms5K0Gw/4ORN9GORMVmG9RlyIIT4WsKo3TEjaBomoR3hOOJTrRhsvX0BCv1WB3zVcgH3/vsT+lPpVziZuU48vSCWdDHlRQzR763ZAYKya4GKmsKjKPoaTj0nXUdoyrOgrrnPzBVSRIGw0Vpl1Zc8BTvubSFkkW7xr9zt5AN34kq8I1dO5x4jEVn4tv3iScszBHAxLfXzFnqcKH17b1bkfIyKMD9pEca8qz4fPEz5PNEuiCIzYBvBkqVFqRubrqJdNcq8sHORPnfA9YTtS8Svz8Is+Zbj2teAYjN32YRXLc4Pq+Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ERVZlYgengVxIF07q5Nd+c+RZsHndThMhLBOh5jIZX4=; b=aJkt8rKYVM6V7JiuWwxkVkBul/kOxzqzZsOc4fN3uz2KYO0ry6CFpG1CgOyiNozXkvjTspJql0E2n5L0prqeWf9WZ1iXnxaJxqT9maLz92GX4Kvf/Ebx6lrUpx1TRfUxFAD/oP8EOwq+9ukuphHhABa2aw8gJtNmu1+q0Hb84B0pQGp6Rul/yJ4fwhzT32SGWBkFxKNHdiJoZavMu9md+BP+9foW2hIXLjxjDH8JSwGoyqBOkZqUVVwT4HMmwQ1Sn80povHlD88/mScavs0b+dZwSrhe8RRSuGDqslKL+cJYxil7qbfEZ9YkzKfSa8WrOkPlq8vUm3E/FjUDeBWFVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ERVZlYgengVxIF07q5Nd+c+RZsHndThMhLBOh5jIZX4=; b=SXIX2iSxJUz/NuyKLbnVEoXet8OswNdz67RLNHljWzD7+HdfXy8YdviJH8gAw5pgJF5dL3ErAUZAChtC7YXYwztllneFvsnnXu+/2n70bAQhf2UbfeLJpYLyjRq8jGpkJ8XOMLRXH+Ew4bnFH4bMCFc5SfOzPdheHyG+dIXz6d7rzGsHs7SjLqUzpCaEcvEnUOFMRCpht2uVtSHTnSqte5LIlgJPFG+ohvF3JBK57HLhlRJXZCCtE712kJIIAKCz0DUhOJCsLUM26g325elMbAInu3FFl6neFFtrBuTIszYWfTMAq6C6LDCR6EGEI8ISZJ6Po4WkfXTkW6+w2PCpnQ== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by SN7PR12MB7788.namprd12.prod.outlook.com (2603:10b6:806:345::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.19; Tue, 11 Feb 2025 21:17:26 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8422.015; Tue, 11 Feb 2025 21:17:26 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, David Hildenbrand Subject: Re: [RFC PATCH 3/3] proc: Use snapshot_page() in kpageflags Date: Tue, 11 Feb 2025 16:17:21 -0500 X-Mailer: MailMate (2.0r6222) Message-ID: <54F12A29-A2C0-4823-BC9B-E58C7673E144@nvidia.com> In-Reply-To: <20250210212142.4002210-4-willy@infradead.org> References: <20250210212142.4002210-1-willy@infradead.org> <20250210212142.4002210-4-willy@infradead.org> Content-Type: text/plain X-ClientProxiedBy: BYAPR05CA0026.namprd05.prod.outlook.com (2603:10b6:a03:c0::39) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|SN7PR12MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: c15adbb4-a84d-4a5b-049e-08dd4ae17bc7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?MmVlec6jDROyCzj8kwEXGi3tAj8/yhGq0/xfUOjFtpgWoPLkA4MTfphmWUqe?= =?us-ascii?Q?LimlkRTONTqWvsEN9Ss8kko+c+zBcMlAXLCd5mpEYeXuUNR88JBM6n4DyOl1?= =?us-ascii?Q?i3h7N9TjD9zMNMWLsdM4XYrtyT5NYXTKYtavvLOV5i469R0QKAmaKLW7GY41?= =?us-ascii?Q?RzV/7d/Mw7bXeyXHo0Nndb2oGh+IrB/3zd39n/H73eNL/IKxsBBvJAEfFbEh?= =?us-ascii?Q?FsE1khVoXRMqSf5YTU9bMthvW0ungDFB34P44s0n9b69pHNBYdtlhYssZMbU?= =?us-ascii?Q?5gocIoOM5NqLB0mUvlyX1IyL/RLa3A6bM59Bh3yL8H19mkfu/e0MALsiP6s/?= =?us-ascii?Q?cz4pkJghmA1oQuxRunlTeZvj7zckFjlRDQJGscLloYBeC5MarA9DaNAboQ8x?= =?us-ascii?Q?TYqr8gx9E9n58DjvDhEq5kNTpWJ+19nizPYJ5mjYlYE95k6h+K/RF/p9VWzx?= =?us-ascii?Q?Z2XkLXHijSNsswPMpJrYm/v+3NTyTR2B1W4Ugv8nDhnJbNosyXQoXsLkzImj?= =?us-ascii?Q?8Akb2fG0UdozQEYA5H86S3w4bNRiemfJbBY9f6UOYYvqgJbX6g/DToSBc0KR?= =?us-ascii?Q?4wOobFsBiPDFykdfS10ybl6EMldfz+sSAkvRPU/qgex7wTBx1OAlGeyRIe+3?= =?us-ascii?Q?iSnJwLxHwehHxxMvLz8Ip9MDZ9sziz1I54JGUKV6wImdY6cz21pCXFfJeKH+?= =?us-ascii?Q?Yvk3Al4h8PgF06e5iGUDszVQnRBnonnbwt3ObZLjwsrj+6LR38cIhMTN2mFV?= =?us-ascii?Q?NwrQBlAP4PEuqesPBP044ZuJzMaG0ZngUE+usVuX1N6eY5RJMdYSWcm6omwQ?= =?us-ascii?Q?JQtDtP7CwptGxM3f78C7JWPCc/+uGcT0DlCLvXz+r60547phR9oDC+q9Tipc?= =?us-ascii?Q?NhLktcyMrRn6In/1ojIPlYhSJ6oRMgvielCzF0NR18XCobylfTj2AHL8i/Ra?= =?us-ascii?Q?puPRsVXpeqMsn4TsfO0ih/LN7P2dPruKgcKqKw853NVzzt4Vg1DJMlX0TVjn?= =?us-ascii?Q?LjzevzyyBVjkd3uNzd1K5jAPZcDbhb5ws/hqeL9XKe45DmEqJbO4uDM6DYXN?= =?us-ascii?Q?Ez60YARKvCCpP0X4LBtpQNnWWRu8tfwTrg7rqm9wrANKbcttehuCIxkjsMGM?= =?us-ascii?Q?l+dWd8zgIussOtpc20luEsDmdMe5jl4Oyl7+NOG/MbTBd8Bu0ioge4KFqcrX?= =?us-ascii?Q?Ouuhtpz2HZvTGK4e3iz1fkq7mVbDpJlEnkjPxWp8YZG1rUpBo46QfDBXUm2P?= =?us-ascii?Q?TUgbmF6UXXl5ZBu9OoEby8Z5NQLtkCiO900LoZAlLxbj7c7gmx6LvRuOdKT1?= =?us-ascii?Q?5Y5x/0UqBKZd+griruIOpyXS8KBfV6mYT33QKyeXbFITobWxvxc8u9k8l492?= =?us-ascii?Q?4Snbw5lrMoh2qlOlbBfosE+vhk52?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JaKI1HIzsZLs4Ut75bEKtBwOV9qVbV6GxjBzAONDNBZl4iGp9GYPmvwKLkOr?= =?us-ascii?Q?hI3ONHqoixccrDVdBfQBEWq4PN3DoowzNQif7XtLjgi8OCiZdw5pRhWsAutz?= =?us-ascii?Q?V90P3Rjsy26SzmqOHtGZ9fW0MFxo/Ifsi3C72dfWngRrdnsO8FGk7K2jRDzr?= =?us-ascii?Q?NAH87cs9Pk92Xz9G/LIqwNiot8wRHrJdm+81FcQKJ3eG+mfs7ywOImpWg053?= =?us-ascii?Q?qS+iJXnGQGIhN5R2j8RCB2clht2fQ6LqUvJ4LxCuFIaOiBUnfTc5/9Ww5RJd?= =?us-ascii?Q?2ijXmOi1jyOyEn9m/e0vVgvQTx42dL5R5v8NLAA9709p6ttoEEzVB+UqS/TA?= =?us-ascii?Q?OiRj/VDGmhu+eTef87FnhOAuj3m8omgYwkOWb3YVnjcBFRqKEZSd0DQyNOJI?= =?us-ascii?Q?5q/HfiBtkvM5qyqMxWRhzyEF/6xiL6VVFdf9pD9iEimxQGBHVlbEcC7mmuoB?= =?us-ascii?Q?GWgJYvQekGflOzNF+UJR2UIdHzWnzko7LprlA9YibSMcphBDFdk19fRSpfLH?= =?us-ascii?Q?QzE5RRnNZ/jJeE5C0dVgDoxAgb2dkKaeGIVXdT4GDk9jnnds3YeMsmGfCH8j?= =?us-ascii?Q?QVCU16w8LqUuOROJfrfRkaqfGoLDdpeBcsOjnFXmcEM61vLAWkR5BbgQyakw?= =?us-ascii?Q?LHcA6WqT6sjs60jy5svBFQTYX+4oebe74juWtMhA8aTq5ImnVSUV/6hNkyvr?= =?us-ascii?Q?ZbQGSovAC449pYkBB6/io3CaG/r5JCEVk3tmm3mm3nrkPVHH5EljNb8UHvA9?= =?us-ascii?Q?Lq2/UMNQWm6c3x8rk5gJxrjEU61lSWBdDMiT5UeCpxuKZfttvJTpdJ+mRqV0?= =?us-ascii?Q?67EFoPD/DKNCfed3I1beOKWAv9fJxewqlgiXjegXgInx6+chgHD7Qv/dCpHb?= =?us-ascii?Q?/br45wtNNwMeqHFgRLVMSXsy1O7Ekhku/Q+cWMkGoJ8cu+Ki+1eipBSPTC36?= =?us-ascii?Q?/CkZWVLuld4ikQJne7Y5Pyga6hNFdIbVJqB+BFLM/M4Gkty4QoN0Uq9eOS5R?= =?us-ascii?Q?MB4AI/gmXBqgOZ5gqJYzLKhLg548CXADH3ojQi5W6MeOdaw2z7O4xmF/CBo/?= =?us-ascii?Q?AKup8RBm/hC+weRjXwWdFemWCF6CzvXSsBBr44jTUVLo9XfdV+0/hY1zgjcW?= =?us-ascii?Q?XEiGiU8K7Xac2ilmI7xawOr7ypy/LFDiNpjvG16PUICD0ybC/PtmrD7vaP09?= =?us-ascii?Q?8d8LD4EKajNXeRSvFVI2sLpcWFdxB+X61+0RRAOs+zdV/Hb7HXJ1HDxOLc+L?= =?us-ascii?Q?/S56R5e8WNUYe9bvlHePdN/0mLaA1J77k5kdVj0Ei2htyjqsuG7jzje7qB+f?= =?us-ascii?Q?VOd+zVmb+tLenP+w52Xrc37iU/gppChmannj9CRYnCWr5w+oyLlzxyGTTSHx?= =?us-ascii?Q?uH0+TcNO/7o5sdvJC3LnCmo2YWHCLq/loJTaXmJnwrC8o2UG7k/rojGDT9xj?= =?us-ascii?Q?z9wEj/ej2cA2pHEE6RMpQDIeAh9QXClx3XMxNDlrXFIT9XiDsrpCfYDMZ4nr?= =?us-ascii?Q?D7YbzSirf5ACStWaF4dIdQ2ZdUaLMzzOeyj8fJOgLFNHWpolXa58hYHPocIH?= =?us-ascii?Q?zJBsY/E5b/GrJU8QfhvvG0jfaF7fQRZ5vG2L8ffJ?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c15adbb4-a84d-4a5b-049e-08dd4ae17bc7 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2025 21:17:26.2178 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FuPOywafymwzszCLG78/HH9LcaAyFUayCbIhvhdJ0mwrx0A2NJN5OMtbL8KMtkTL X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7788 X-Rspam-User: X-Rspamd-Queue-Id: 3D92940004 X-Rspamd-Server: rspam12 X-Stat-Signature: p1sr1zxboqepjkgop97inu1unpd9ncus X-HE-Tag: 1739308649-770276 X-HE-Meta: U2FsdGVkX18r6xd4SJdqFs+PndOBR43kSCMw0SWcF2w3oOZFNQbm/sNztrrPg2rx/ttqOnJ1Ise5DAGIz89QDEiKKTqnjYC2UlRYFfgzcAuEgbQB+CQ4+4ZRr4RNIbcPfh6OKqf0w0E5fzU82LuaCRoa68aIRqqFBctfi0HA5bEI4Xn3BWXTZlbPISZ6vVPvGmhaIg34beZ6YT7UFlrw54jQ89eND2ujOy5hduvN52pDDNGoxZz+DlCFODMfTTScj+PJ5+SolsXOTfGYLBMJN+03A1EMTuriHk6BLdEMtFum5NSQhLPjBgmu6BGwhoO8UL7+td+Nayzu5wZbmhnZBwa5KGrp+LIVUHeWS19Bd9yDs3ANBtraKWYOm3/jinr0F0vN4klBAso0l23l2QBQ+lu6d3b2N1xuP9F/2GuOSEl2epfSPuwa4WvEufKQP8H24QNivuDPuoUv5QewI3s+SF9f9UGjpnZ22FIdZCPMSM9llAR2H+uW3c7GLQodVZCUjmcMdozc4fEJpzVGXBW9PW5emo3oYnLw+qaHm9ZlzU+3P/84z2yohg5h3CT41fEmfw9IV+X4w4AJkbNNS5Z/l9JC8sCZ0V4ByzBxp1UUEQ5lr4k8mQ6EtrcfYNT7RY2JSbntzoB9tmyOFpewlljPAApA6MsEBdVqa0qyWzLtfqS6OgBmEOtJeijywYet9RxJXJqrd55ubkTc5CYKL4sRrfIxEdd4wrgTFo+zgfNlGqmJ394YY2HwbcIfc/ODeldNpeAmGf6ptkMoCgazmo5PP6sdxJ26o2FP9n5b8B1D98UJarN6R+y3hdr4SewC5QOSSYuVvF9/4r9wWs0KhozWAk1vp3Nt9gsMJGMD0RZq0X/Jn6SS7K2Nvr71QQPHRT5ZD7XX00iyn94/Cm+N1OsoZtKFAi+Ip3s0EuMWsR4o7I7pa9BbarMAu5yEluFK+PCO8UmuHQOWQ4GjCD7tk3k l5qmiDaa GKUaZQsXnwzclxL+vtsBIJba8eTf/gzS2PxKxdRTfsbxLTNTbnQLN809gkKziVEXnVNAbB4GfaeAaoGAthAYKuEKm09hx+6m7QggA6IHaU9wtruhp00EC5yTNi2FO2vQyVzdERAdd4wscEYSgw77NkD3Nva6ix8+nc2K6RZNo87nfxQJaObpgUiWicYFUr7N7z8klJW4QATPLtyjUGpyLZC1l5+mqtSjT2dQPOf/iolllpAAfhx106s+y8E3UhJwDfqLXox2DMo4Huif9Qsi1lk1cV7r6KcuOe0zltFbX12Vv6mv/B0UKP9w5dCqhEoJ5VoMtbEz3eQcW53L+NN0aKr5QKcdJBKa3scI+V7BxJk8BnD76NNbpy65ZzkDRkT3AyU+mGbG2ZECo1x2Hvu+U9HQdQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10 Feb 2025, at 16:21, Matthew Wilcox (Oracle) wrote: > syzbot has reported a number of oopses caused by reading > /proc/kpageflags racing with a folio being split / freed / allocated > and thus a page which starts out as a hed page becomes a tail page s/hed/head/ > during the read, which our assertions catch as an error. > > To solve this problem, snapshot the page like dump_page() does. > > Link: the syzbot reports > Signed-off-by: Matthew Wilcox (Oracle) > --- > fs/proc/page.c | 24 ++++++++++++++---------- > 1 file changed, 14 insertions(+), 10 deletions(-) LGTM. Reviewed-by: Zi Yan Best Regards, Yan, Zi