From: Danesh Petigara <dpetigara@broadcom.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: m.szyprowski@samsung.com, mina86@mina86.com,
iamjoonsoo.kim@lge.com, aneesh.kumar@linux.vnet.ibm.com,
laurent.pinchart+renesas@ideasonboard.com,
gregory.0xf0@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] mm: cma: fix CMA aligned offset calculation
Date: Fri, 27 Feb 2015 15:52:56 -0800 [thread overview]
Message-ID: <54F10358.1050102@broadcom.com> (raw)
In-Reply-To: <20150227132443.e17d574d45451f10f413f065@linux-foundation.org>
On 2/27/2015 1:24 PM, Andrew Morton wrote:
> On Tue, 24 Feb 2015 15:39:45 -0800 Danesh Petigara <dpetigara@broadcom.com> wrote:
>
>> The CMA aligned offset calculation is incorrect for
>> non-zero order_per_bit values.
>>
>> For example, if cma->order_per_bit=1, cma->base_pfn=
>> 0x2f800000 and align_order=12, the function returns
>> a value of 0x17c00 instead of 0x400.
>>
>> This patch fixes the CMA aligned offset calculation.
>
> When fixing a bug please always describe the end-user visible effects
> of that bug.
>
> Without that information others are unable to understand why you are
> recommending a -stable backport.
>
Thank you for the feedback. I had no crash logs to show, nevertheless, I
agree that a sentence describing potential effects of the bug would've
helped.
I'll keep that in mind for future submissions.
Best Regards,
Danesh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-02-27 23:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 23:39 Danesh Petigara
2015-02-27 21:24 ` Andrew Morton
2015-02-27 23:52 ` Danesh Petigara [this message]
2015-02-27 23:54 ` Andrew Morton
2015-02-28 1:07 ` Danesh Petigara
2015-02-28 1:18 ` Andrew Morton
2015-02-28 2:06 ` Gregory Fong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F10358.1050102@broadcom.com \
--to=dpetigara@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=gregory.0xf0@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mina86@mina86.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox