From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f45.google.com (mail-oi0-f45.google.com [209.85.218.45]) by kanga.kvack.org (Postfix) with ESMTP id C48366B0032 for ; Mon, 26 Jan 2015 09:18:22 -0500 (EST) Received: by mail-oi0-f45.google.com with SMTP id g201so7272044oib.4 for ; Mon, 26 Jan 2015 06:18:22 -0800 (PST) Received: from bh-25.webhostbox.net (bh-25.webhostbox.net. [208.91.199.152]) by mx.google.com with ESMTPS id sb4si4975761oeb.13.2015.01.26.06.18.21 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 26 Jan 2015 06:18:22 -0800 (PST) Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1YFkUf-002Gxm-GC for linux-mm@kvack.org; Mon, 26 Jan 2015 14:18:21 +0000 Message-ID: <54C64C93.6040504@roeck-us.net> Date: Mon, 26 Jan 2015 06:17:55 -0800 From: Guenter Roeck MIME-Version: 1.0 Subject: Re: mmotm 2015-01-22-15-04: qemu failures due to 'mm: account pmd page tables to the process' References: <54c1822d.RtdGfWPekQVAw8Ly%akpm@linux-foundation.org> <20150123050445.GA22751@roeck-us.net> <20150123111304.GA5975@node.dhcp.inet.fi> <54C263CC.1060904@roeck-us.net> <20150123135519.9f1061caf875f41f89298d59@linux-foundation.org> <20150124055207.GA8926@roeck-us.net> <20150126122944.GE25833@node.dhcp.inet.fi> <54C6494D.80802@roeck-us.net> In-Reply-To: <54C6494D.80802@roeck-us.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org, sfr@canb.auug.org.au, mhocko@suse.cz, "Kirill A. Shutemov" On 01/26/2015 06:03 AM, Guenter Roeck wrote: > On 01/26/2015 04:29 AM, Kirill A. Shutemov wrote: >> On Fri, Jan 23, 2015 at 09:52:07PM -0800, Guenter Roeck wrote: >>> On Fri, Jan 23, 2015 at 01:55:19PM -0800, Andrew Morton wrote: >>>> On Fri, 23 Jan 2015 07:07:56 -0800 Guenter Roeck wrote: >>>> >>>>>>> >>>>>>> qemu:microblaze generates warnings to the console. >>>>>>> >>>>>>> WARNING: CPU: 0 PID: 32 at mm/mmap.c:2858 exit_mmap+0x184/0x1a4() >>>>>>> >>>>>>> with various call stacks. See >>>>>>> http://server.roeck-us.net:8010/builders/qemu-microblaze-mmotm/builds/15/steps/qemubuildcommand/logs/stdio >>>>>>> for details. >>>>>> >>>>>> Could you try patch below? Completely untested. >>>>>> >>>>>> >From b584bb8d493794f67484c0b57c161d61c02599bc Mon Sep 17 00:00:00 2001 >>>>>> From: "Kirill A. Shutemov" >>>>>> Date: Fri, 23 Jan 2015 13:08:26 +0200 >>>>>> Subject: [PATCH] microblaze: define __PAGETABLE_PMD_FOLDED >>>>>> >>>>>> Microblaze uses custom implementation of PMD folding, but doesn't define >>>>>> __PAGETABLE_PMD_FOLDED, which generic code expects to see. Let's fix it. >>>>>> >>>>>> Defining __PAGETABLE_PMD_FOLDED will drop out unused __pmd_alloc(). >>>>>> It also fixes problems with recently-introduced pmd accounting. >>>>>> >>>>>> Signed-off-by: Kirill A. Shutemov >>>>>> Reported-by: Guenter Roeck >>>>> >>>>> Tested working. >>>>> >>>>> Tested-by: Guenter Roeck >>>>> >>>>> Any idea how to fix the sh problem ? >>>> >>>> Can you tell us more about it? All I'm seeing is "qemu:sh fails to >>>> shut down", which isn't very clear. >>> >>> Turns out that the include file defining __PAGETABLE_PMD_FOLDED >>> was not always included where used, resulting in a messed up mm_struct. >> >> What means "messed up" here? It should only affect size of mm_struct. >> > Plus the offset of all variables after the #ifndef. > >>> The patch below fixes the problem for the sh architecture. >>> No idea if the patch is correct/acceptable for other architectures. >> >> That's pain. Some archs includes from . >> I don't see obvious way to fix this. Urghh. >> > Does it matter ? Circular includes are normally ok and happen all over the place. Ah yes, it does, because mm_struct will not see the define in that case since it comes later. Hmm, that is really tricky. You could of course just drop the conditional from mm_struct. That would result in an unused variable for some architectures, but at least it would work. Guenter -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org