From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by kanga.kvack.org (Postfix) with ESMTP id EEF6A6B0032 for ; Fri, 16 Jan 2015 14:02:08 -0500 (EST) Received: by mail-we0-f181.google.com with SMTP id q58so21860165wes.12 for ; Fri, 16 Jan 2015 11:02:08 -0800 (PST) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id l3si5767300wic.38.2015.01.16.11.02.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 16 Jan 2015 11:02:07 -0800 (PST) Message-ID: <54B9602E.70707@suse.cz> Date: Fri, 16 Jan 2015 20:02:06 +0100 From: Vlastimil Babka MIME-Version: 1.0 Subject: Re: [PATCH] mm/vmscan: fix highidx argument type References: <1421360175-18899-1-git-send-email-mst@redhat.com> <20150115144920.33c446af388ed74c11dc573e@linux-foundation.org> <20150116070744.GA12190@redhat.com> <54B95E41.5010305@suse.cz> In-Reply-To: <54B95E41.5010305@suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Michael S. Tsirkin" , Andrew Morton Cc: linux-kernel@vger.kernel.org, Johannes Weiner , Vladimir Davydov , Rik van Riel , Michal Hocko , Mel Gorman , Suleiman Souhlal , linux-mm@kvack.org On 01/16/2015 07:53 PM, Vlastimil Babka wrote: > BTW, I wonder if the whole code couldn't be much simpler by capping high_zoneidx > by ZONE_NORMAL before traversing the zonelist, like this: > > int high_zoneidx = min(gfp_zone(gfp_mask), ZONE_NORMAL); > > first_zones_zonelist(zonelist, high_zoneidx, NULL, &zone); Erm, s/NULL/nodemask/ here. I copy/pasted this from before 675becce15f32, where it didn't actually use the nodemask parameter of throttle_direct_reclaim(), Wonder why, looks like another bug to me, that the commit has silently fixed. > pgdat = zone->zone_pgdat; > > if (!pgdat || pfmemalloc_watermark_ok(pgdat)) > goto out; > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org