From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by kanga.kvack.org (Postfix) with ESMTP id 057CD6B0032 for ; Mon, 12 Jan 2015 09:34:57 -0500 (EST) Received: by mail-we0-f176.google.com with SMTP id w61so19363016wes.7 for ; Mon, 12 Jan 2015 06:34:56 -0800 (PST) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id o9si36098086wjw.15.2015.01.12.06.34.55 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 12 Jan 2015 06:34:55 -0800 (PST) Message-ID: <54B3DB8D.3000005@suse.cz> Date: Mon, 12 Jan 2015 15:34:53 +0100 From: Vlastimil Babka MIME-Version: 1.0 Subject: Re: [PATCH v2 3/5] mm/compaction: print current range where compaction work References: <1421050875-26332-1-git-send-email-iamjoonsoo.kim@lge.com> <1421050875-26332-3-git-send-email-iamjoonsoo.kim@lge.com> In-Reply-To: <1421050875-26332-3-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim , Andrew Morton Cc: Mel Gorman , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org On 01/12/2015 09:21 AM, Joonsoo Kim wrote: > It'd be useful to know current range where compaction work for detailed > analysis. With it, we can know pageblock where we actually scan and > isolate, and, how much pages we try in that pageblock and can guess why > it doesn't become freepage with pageblock order roughly. > > Signed-off-by: Joonsoo Kim Acked-by: Vlastimil Babka > --- > include/trace/events/compaction.h | 30 +++++++++++++++++++++++------- > mm/compaction.c | 9 ++++++--- > 2 files changed, 29 insertions(+), 10 deletions(-) > > diff --git a/include/trace/events/compaction.h b/include/trace/events/compaction.h > index 839f6fa..139020b 100644 > --- a/include/trace/events/compaction.h > +++ b/include/trace/events/compaction.h > @@ -11,39 +11,55 @@ > > DECLARE_EVENT_CLASS(mm_compaction_isolate_template, > > - TP_PROTO(unsigned long nr_scanned, > + TP_PROTO( > + unsigned long start_pfn, > + unsigned long end_pfn, > + unsigned long nr_scanned, > unsigned long nr_taken), > > - TP_ARGS(nr_scanned, nr_taken), > + TP_ARGS(start_pfn, end_pfn, nr_scanned, nr_taken), > > TP_STRUCT__entry( > + __field(unsigned long, start_pfn) > + __field(unsigned long, end_pfn) > __field(unsigned long, nr_scanned) > __field(unsigned long, nr_taken) > ), > > TP_fast_assign( > + __entry->start_pfn = start_pfn; > + __entry->end_pfn = end_pfn; > __entry->nr_scanned = nr_scanned; > __entry->nr_taken = nr_taken; > ), > > - TP_printk("nr_scanned=%lu nr_taken=%lu", > + TP_printk("range=(0x%lx ~ 0x%lx) nr_scanned=%lu nr_taken=%lu", > + __entry->start_pfn, > + __entry->end_pfn, > __entry->nr_scanned, > __entry->nr_taken) > ); > > DEFINE_EVENT(mm_compaction_isolate_template, mm_compaction_isolate_migratepages, > > - TP_PROTO(unsigned long nr_scanned, > + TP_PROTO( > + unsigned long start_pfn, > + unsigned long end_pfn, > + unsigned long nr_scanned, > unsigned long nr_taken), > > - TP_ARGS(nr_scanned, nr_taken) > + TP_ARGS(start_pfn, end_pfn, nr_scanned, nr_taken) > ); > > DEFINE_EVENT(mm_compaction_isolate_template, mm_compaction_isolate_freepages, > - TP_PROTO(unsigned long nr_scanned, > + > + TP_PROTO( > + unsigned long start_pfn, > + unsigned long end_pfn, > + unsigned long nr_scanned, > unsigned long nr_taken), > > - TP_ARGS(nr_scanned, nr_taken) > + TP_ARGS(start_pfn, end_pfn, nr_scanned, nr_taken) > ); > > TRACE_EVENT(mm_compaction_migratepages, > diff --git a/mm/compaction.c b/mm/compaction.c > index 2d86a20..be28469 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -429,11 +429,12 @@ isolate_fail: > > } > > + trace_mm_compaction_isolate_freepages(*start_pfn, blockpfn, > + nr_scanned, total_isolated); > + > /* Record how far we have got within the block */ > *start_pfn = blockpfn; > > - trace_mm_compaction_isolate_freepages(nr_scanned, total_isolated); > - > /* > * If strict isolation is requested by CMA then check that all the > * pages requested were isolated. If there were any failures, 0 is > @@ -589,6 +590,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, > unsigned long flags = 0; > bool locked = false; > struct page *page = NULL, *valid_page = NULL; > + unsigned long start_pfn = low_pfn; > > /* > * Ensure that there are not too many pages isolated from the LRU > @@ -749,7 +751,8 @@ isolate_success: > if (low_pfn == end_pfn) > update_pageblock_skip(cc, valid_page, nr_isolated, true); > > - trace_mm_compaction_isolate_migratepages(nr_scanned, nr_isolated); > + trace_mm_compaction_isolate_migratepages(start_pfn, low_pfn, > + nr_scanned, nr_isolated); > > count_compact_events(COMPACTMIGRATE_SCANNED, nr_scanned); > if (nr_isolated) > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org