From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by kanga.kvack.org (Postfix) with ESMTP id B281E6B008A for ; Mon, 22 Dec 2014 12:10:38 -0500 (EST) Received: by mail-pd0-f170.google.com with SMTP id v10so6166543pde.15 for ; Mon, 22 Dec 2014 09:10:38 -0800 (PST) Received: from mga11.intel.com (mga11.intel.com. [192.55.52.93]) by mx.google.com with ESMTP id va1si25712315pbc.211.2014.12.22.09.10.36 for ; Mon, 22 Dec 2014 09:10:37 -0800 (PST) Message-ID: <5498508A.4080108@linux.intel.com> Date: Mon, 22 Dec 2014 09:10:34 -0800 From: Dave Hansen MIME-Version: 1.0 Subject: Re: [PATCH] proc: task_mmu: show page size in /proc//numa_maps References: <20141220183613.GA19229@phnom.home.cmpxchg.org> <20141220194457.GA3166@x61.redhat.com> <54970B49.3070104@linux.intel.com> <20141221222850.GA2038@x61.redhat.com> In-Reply-To: <20141221222850.GA2038@x61.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Rafael Aquini Cc: Johannes Weiner , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, oleg@redhat.com, rientjes@google.com, linux-mm@kvack.org On 12/21/2014 02:28 PM, Rafael Aquini wrote: >>> > > I'm fine either way, it makes the change even simpler. Also, if we >>> > > decide to get rid of page_size != PAGE_SIZE condition I believe we can >>> > > also get rid of that "huge" hint being conditionally printed out too. >> > >> > That would break existing users of the "huge" flag. That makes it out >> > of the question, right? >> > > Yeah, but it sort of follows the same complaint Johannes did for the > conditional page size printouts. If we start to print out page size > deliberately for each map regardless their backing pages being PAGE_SIZE > long or bigger, I don't see much point on keep conditionally printing out > the 'huge' hint out. Because existing userspace might be relying on it. If we take the 'huge' hint out, userspace will break. > As I said before, I'm fine either way though I think > we can keep the current behaviour, and just disambiguate page sizes != > PAGE_SIZE as in the current proposal. Unless we somehow have a (really good) handle on how many apps out there are reading and using 'huge', I think we have to keep the existing behavior. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org