From: Dave Hansen <dave.hansen@linux.intel.com>
To: Rafael Aquini <aquini@redhat.com>, Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
oleg@redhat.com, rientjes@google.com, linux-mm@kvack.org
Subject: Re: [PATCH] proc: task_mmu: show page size in /proc/<pid>/numa_maps
Date: Sun, 21 Dec 2014 10:02:49 -0800 [thread overview]
Message-ID: <54970B49.3070104@linux.intel.com> (raw)
In-Reply-To: <20141220194457.GA3166@x61.redhat.com>
On 12/20/2014 11:44 AM, Rafael Aquini wrote:
>> >
>> > It would be simpler to include this unconditionally. Otherwise you
>> > are forcing everybody parsing the file and trying to run calculations
>> > of it to check for its presence, and then have them fall back and get
>> > the value from somewhere else if not.
> I'm fine either way, it makes the change even simpler. Also, if we
> decide to get rid of page_size != PAGE_SIZE condition I believe we can
> also get rid of that "huge" hint being conditionally printed out too.
That would break existing users of the "huge" flag. That makes it out
of the question, right?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-12-21 18:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 13:54 Rafael Aquini
2014-12-20 16:40 ` Dave Hansen
2014-12-22 22:27 ` David Rientjes
2014-12-20 18:36 ` Johannes Weiner
2014-12-20 19:44 ` Rafael Aquini
2014-12-21 18:02 ` Dave Hansen [this message]
2014-12-21 22:28 ` Rafael Aquini
2014-12-22 17:10 ` Dave Hansen
2014-12-22 17:25 ` Rafael Aquini
2014-12-22 17:59 ` Dave Hansen
2014-12-22 22:21 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54970B49.3070104@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox