* Question about Old Fix Me comment in mempool.c
@ 2014-12-17 4:32 nick
2015-02-25 20:18 ` Mikulas Patocka
0 siblings, 1 reply; 2+ messages in thread
From: nick @ 2014-12-17 4:32 UTC (permalink / raw)
To: akpm; +Cc: catalin.marinas, mpatocka, sebott, linux-mm, linux-kernel
Greetings Andrew and other maintainers,
I am wondering why the below comment is even in mempool.c and this has not been changed to a call to io_schedule as the kernel version is stupidly old and this should be fixed by now and the issues with DM would have been removed by now.
/*
* FIXME: this should be io_schedule(). The timeout is there as a
* workaround for some DM problems in 2.6.18.
*/
Sorry for the stupid question but I like to double check with the maintainers before I sent in a patch for things like this to see if I am missing anything:).
Thanks for Your Time,
Nick
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Question about Old Fix Me comment in mempool.c
2014-12-17 4:32 Question about Old Fix Me comment in mempool.c nick
@ 2015-02-25 20:18 ` Mikulas Patocka
0 siblings, 0 replies; 2+ messages in thread
From: Mikulas Patocka @ 2015-02-25 20:18 UTC (permalink / raw)
To: nick; +Cc: akpm, catalin.marinas, sebott, linux-mm, linux-kernel
On Tue, 16 Dec 2014, nick wrote:
> Greetings Andrew and other maintainers,
> I am wondering why the below comment is even in mempool.c and this has not been changed to a call to io_schedule as the kernel version is stupidly old and this should be fixed by now and the issues with DM would have been removed by now.
> /*
> * FIXME: this should be io_schedule(). The timeout is there as a
> * workaround for some DM problems in 2.6.18.
> */
>
> Sorry for the stupid question but I like to double check with the maintainers before I sent in a patch for things like this to see if I am missing anything:).
>
> Thanks for Your Time,
> Nick
There are still some bugs with respect to this (and they will probably
never be removed all) - for example this bug which wasn't fixed yet
http://www.redhat.com/archives/dm-devel/2014-May/msg00089.html .
So, you should not remove it.
Mikulas
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-25 20:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-17 4:32 Question about Old Fix Me comment in mempool.c nick
2015-02-25 20:18 ` Mikulas Patocka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox