From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,BIGNUM_EMAILS, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2079BC433E0 for ; Mon, 4 Jan 2021 10:18:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5DC72207B3 for ; Mon, 4 Jan 2021 10:18:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DC72207B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2F0666B009D; Mon, 4 Jan 2021 05:18:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A0896B009F; Mon, 4 Jan 2021 05:18:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B7016B00A1; Mon, 4 Jan 2021 05:18:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id 022346B009D for ; Mon, 4 Jan 2021 05:18:01 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B0856180AD802 for ; Mon, 4 Jan 2021 10:18:01 +0000 (UTC) X-FDA: 77667691962.24.roll46_38126e4274cf Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 938B11A4A7 for ; Mon, 4 Jan 2021 10:18:01 +0000 (UTC) X-HE-Tag: roll46_38126e4274cf X-Filterd-Recvd-Size: 2302 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 Jan 2021 10:18:01 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 33824101E; Mon, 4 Jan 2021 02:18:00 -0800 (PST) Received: from [10.163.87.157] (unknown [10.163.87.157]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2CCAB3F70D; Mon, 4 Jan 2021 02:17:58 -0800 (PST) Subject: Re: [bug report] mm,hwpoison: refactor get_any_page To: Dan Carpenter , osalvador@suse.de Cc: linux-mm@kvack.org References: From: Anshuman Khandual Message-ID: <54865ebd-5459-81bc-6def-b7f6237fb038@arm.com> Date: Mon, 4 Jan 2021 15:48:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/4/21 3:25 PM, Dan Carpenter wrote: > Hello Oscar Salvador, > > The patch 8295d535e2aa: "mm,hwpoison: refactor get_any_page" from Dec > 14, 2020, leads to the following static checker warning: > > mm/memory-failure.c:1943 soft_offline_page() > error: '%pG' must be followed by one of [gpv] > > mm/memory-failure.c > 1933 put_online_mems(); > 1934 > 1935 if (ret > 0) { > 1936 ret = soft_offline_in_use_page(page); > 1937 } else if (ret == 0) { > 1938 if (soft_offline_free_page(page) && try_again) { > 1939 try_again = false; > 1940 goto retry; > 1941 } > 1942 } else if (ret == -EIO) { > 1943 pr_info("%s: %#lx: unknown page type: %lx (%pGP)\n", > ^^^^ > Presumably lower case 'p' was intended. "%pGp". See the flags_string() > function for more details. Yeah right, s/P/p is required. Otherwise apart from this static checker warning, this might not even print the page flags correctly.