From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>, osalvador@suse.de
Cc: linux-mm@kvack.org
Subject: Re: [bug report] mm,hwpoison: refactor get_any_page
Date: Mon, 4 Jan 2021 15:48:18 +0530 [thread overview]
Message-ID: <54865ebd-5459-81bc-6def-b7f6237fb038@arm.com> (raw)
In-Reply-To: <X/LmGEE3Yg9xiqLC@mwanda>
On 1/4/21 3:25 PM, Dan Carpenter wrote:
> Hello Oscar Salvador,
>
> The patch 8295d535e2aa: "mm,hwpoison: refactor get_any_page" from Dec
> 14, 2020, leads to the following static checker warning:
>
> mm/memory-failure.c:1943 soft_offline_page()
> error: '%pG' must be followed by one of [gpv]
>
> mm/memory-failure.c
> 1933 put_online_mems();
> 1934
> 1935 if (ret > 0) {
> 1936 ret = soft_offline_in_use_page(page);
> 1937 } else if (ret == 0) {
> 1938 if (soft_offline_free_page(page) && try_again) {
> 1939 try_again = false;
> 1940 goto retry;
> 1941 }
> 1942 } else if (ret == -EIO) {
> 1943 pr_info("%s: %#lx: unknown page type: %lx (%pGP)\n",
> ^^^^
> Presumably lower case 'p' was intended. "%pGp". See the flags_string()
> function for more details.
Yeah right, s/P/p is required. Otherwise apart from this static checker
warning, this might not even print the page flags correctly.
next prev parent reply other threads:[~2021-01-04 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 9:55 Dan Carpenter
2021-01-04 10:18 ` Anshuman Khandual [this message]
2021-01-04 12:06 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54865ebd-5459-81bc-6def-b7f6237fb038@arm.com \
--to=anshuman.khandual@arm.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox