From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95E21C4345F for ; Thu, 11 Apr 2024 16:58:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F101D6B00A2; Thu, 11 Apr 2024 12:58:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4B0F6B00AE; Thu, 11 Apr 2024 12:58:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEC296B00B3; Thu, 11 Apr 2024 12:58:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AF3EA6B00A2 for ; Thu, 11 Apr 2024 12:58:54 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6C48AA1802 for ; Thu, 11 Apr 2024 16:58:54 +0000 (UTC) X-FDA: 81997860588.08.8406A8A Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf04.hostedemail.com (Postfix) with ESMTP id C825C40002 for ; Thu, 11 Apr 2024 16:58:52 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=softfail (imf04.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712854733; a=rsa-sha256; cv=none; b=GBQMzVqxTELObxzU5Blcv2bIzHHmYdTDPAt/efSGyfIYP1o4lEW4oUo4CHsyo2RILaSGDv vsjaq1gvJ/tfI3fOCFkFhQPvE6miSNHQeElwfbGf85JHqIf2/tGpHAkWY/TTaOs5m2CavV 3brcx0HLZMoMoEvcszXXMmyk+nlZiv0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=softfail (imf04.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712854733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MibdMJWbAGkXU+bJBEHPDcusRTLoUkXBmxnDnt1+roE=; b=3vYQfBO7i7tYHzyZqEGLS7IL77Wg+veUACIZM3Itceltn+Iy5CL4zdHDjTUJY66s50yFaV mKST13HXLFnGM07wSRVNc1zcfJE36YLVDfIK/oOnVq8d83G5AlRQBkeu4BYaH5NI+2yObU EUf5sJOUXi6TiMF5ll6bcsL5A26G4R4= Received: by gentwo.org (Postfix, from userid 1003) id DF1AF40AFA; Thu, 11 Apr 2024 09:51:13 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id DE85240A90; Thu, 11 Apr 2024 09:51:13 -0700 (PDT) Date: Thu, 11 Apr 2024 09:51:13 -0700 (PDT) From: "Christoph Lameter (Ampere)" To: Haifeng Xu cc: vbabka@suse.cz, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] slub: Clear __GFP_COMP flag when allocating 0 order page In-Reply-To: <20240411091832.608280-1-haifeng.xu@shopee.com> Message-ID: <5482360c-0a0b-e5f5-b88e-4a6ec4d43f7d@linux.com> References: <20240411091832.608280-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C825C40002 X-Stat-Signature: yaot8g94kd1cj59jimhnru6ca75dowwk X-HE-Tag: 1712854732-495940 X-HE-Meta: U2FsdGVkX18lP3ZWNoOytw5ViDPTQ3bSAPhhKw+a9BdC+fQRyGwm5SndfeynLX3Bx2fEeCFTwSPAIPTAMShO7bg1fyEeZH5jeAkUAcFUHwqxyAMeFHWwnjs1vC8BLJH2UB8QD9AYREckJIY+UGL7tj0dih6WPPBLaOjHp2hEofxGZJtjOXn0/G6sBBRr4r47g4BIfIh7Eebm6yP1auj0KiHeV1cLqZ74xRRPyaSBZIuouBk6j0wu3vEDdXYd5hrAePYJ9UT3wmIiJNlgmqpqJXA13SSMzxOQC6h3awTJmbNt+nRpNSfj24oO6VPfA5+kzV+JzN4mBUuCij6ijLEn2CXh7a0E7VKcKaTz0wASRlI67aas1DC9KZIO6HnkxQHCuanQ7kBZuicCn0uP58zf37475PtL/gfYVpWRVf+qvtVHNaQOD9+t2PaYp843/SkxnQpne7ewrjpapWPe9otSx/APzDx3lvwQtChqAR1Xo/Fk3gNiIMwFsSvgbnSp3F9tmeU/eSOBTJ1hiBNh70MVQbWltD1tJiLiUBZ7F31RBHSpw/tmr6l/zb4RJasZRyVCyLmB1t/tWC4c0Xwnf9qCnpYT56FeL5Jja1+fiCfMqP00WZGI8ty4uTEhcLR/NDM2NrQSVjM5ai2UanFe88qwL5oonNX3FJbRq5qc+EdFdWBsIcXmrsDHE8YyCEdAXVuodlHSqlt6CJ3qiEy78jm4pwWhTYbCKYHrvtEXZM5gx6EZkd7b/6v3wSFHGOxvJRWNK4ovLmgEBMWvla43Rn90Kh0jTbltMgzKhY1kjhBvoxW5DW3vjWImIx4OB1IrBbiAPD7ywe+8shQG3W7np11jhoQLcBMGZULN+8X7D83NZA7PIh9/SzUSdMwDZBkCBA4/AuhItSpPZ0Noz3Mhmm9Xi/TOav6afMDodSXUB2WEiuZSrM4wgWBt9fkV6RgI1ULJdg1C1W6+Pb2OPDkACnE /9yxcybD 4aHLDedXEBWULtBnpot0LYreyCd1bzSlQ/y7NsbajH0Pn53tqTuzuDdyhMY7wleTlTYJ94sIfK7KxlTiVIPhlt2SuZ+yVZjtrp0TMlUIi03BOrF3Zcds0Jme2Iz8OO5czZNIL7TaT2Gfm0ZNn9MbvfoNGNiqz64HGDrLDkgeYA/PJBfOtEIhddSJDDHQ7DQJlnOv3apPdx8UThX6eRZPye5bp+P9mJR1jVLR1q3fpftZvz1bCewtCV9OfpP3U/IQFhKE4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 11 Apr 2024, Haifeng Xu wrote: > @@ -1875,6 +1875,13 @@ static inline struct slab *alloc_slab_page(gfp_t flags, int node, > struct slab *slab; > unsigned int order = oo_order(oo); > > + /* > + * If fallback to the minimum order allocation and the order is 0, > + * clear the __GFP_COMP flag. > + */ > + if (order == 0) > + flags = flags & ~__GFP_COMP; This would be better placed in allocate_slab() when the need for a fallback to a lower order is detected after the first call to alloc_slab_page().