From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15B04C4167B for ; Sat, 26 Nov 2022 01:41:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 595D56B0071; Fri, 25 Nov 2022 20:41:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5459C6B0073; Fri, 25 Nov 2022 20:41:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 434696B0074; Fri, 25 Nov 2022 20:41:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 31A846B0071 for ; Fri, 25 Nov 2022 20:41:44 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 04400140933 for ; Sat, 26 Nov 2022 01:41:43 +0000 (UTC) X-FDA: 80173891728.27.321E1AA Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf23.hostedemail.com (Postfix) with ESMTP id EDF76140004 for ; Sat, 26 Nov 2022 01:41:42 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NJvZg47LkzHw7Z; Sat, 26 Nov 2022 09:40:59 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 26 Nov 2022 09:41:38 +0800 Subject: Re: [PATCH -next 1/1] mm/memory-failure.c: Cleanup in unpoison_memory To: Wupeng Ma CC: , , , , HORIGUCHI NAOYA References: <20221125065444.3462681-1-mawupeng1@huawei.com> From: Miaohe Lin Message-ID: <5474d574-08e1-f630-7ab2-f688e7e90e64@huawei.com> Date: Sat, 26 Nov 2022 09:41:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20221125065444.3462681-1-mawupeng1@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669426903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N7YH7z+jEshDr9Q/hNin3+6vhjKoZdDyGfPCakyiUnQ=; b=LJhCiBx55SVsfIux41FGf7CA0SUsA9O2scF6T4talCnigGVFNoZZvnFT/UlzhpytRPbnHa rPQc2eDCPGu82q5475UJUmY74OyewakTLItfMBMm+1pa9VYn3jvBYi3YRBJc9n/CXsK4gL 0AekfeuFa8BSAeFX4/+zs/eC6BV2Oog= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669426903; a=rsa-sha256; cv=none; b=Cx9zv8EqhsssY6WVWt5H44mWmoNFTPS6hA5As/FQENIbjjasn2JGXjb1vdFo/QZRYCy3v9 D1KuZiAiL6r/XZ7Z0YM20Hw3huZQz+U1CdOrxw2d6QkVy9I+IVmUPHVVPSbooaW2tjMnix bxo9go/EZRN6+z+SFZ/QltQpPWawxT8= X-Stat-Signature: yxwftjstzrtmy6abrdj1fanck6m5zwcz X-Rspamd-Queue-Id: EDF76140004 Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1669426902-348815 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/11/25 14:54, Wupeng Ma wrote: > From: Ma Wupeng > > If freeit it true, the value of ret must be zero, there is no need to s/it/is/ > check the value of freeit after label unlock_mutex. > > We can drop variable freeit to do this cleanup. > > Signed-off-by: Ma Wupeng Reviewed-by: Miaohe Lin Thanks, Miaohe Lin