linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: Wupeng Ma <mawupeng1@huawei.com>
Cc: <akpm@linux-foundation.org>, <pizhenwei@bytedance.com>,
	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	HORIGUCHI NAOYA <naoya.horiguchi@nec.com>
Subject: Re: [PATCH -next 1/1] mm/memory-failure.c: Cleanup in unpoison_memory
Date: Sat, 26 Nov 2022 09:41:22 +0800	[thread overview]
Message-ID: <5474d574-08e1-f630-7ab2-f688e7e90e64@huawei.com> (raw)
In-Reply-To: <20221125065444.3462681-1-mawupeng1@huawei.com>

On 2022/11/25 14:54, Wupeng Ma wrote:
> From: Ma Wupeng <mawupeng1@huawei.com>
> 
> If freeit it true, the value of ret must be zero, there is no need to

s/it/is/

> check the value of freeit after label unlock_mutex.
> 
> We can drop variable freeit to do this cleanup.
> 
> Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>

Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>

Thanks,
Miaohe Lin



      parent reply	other threads:[~2022-11-26  1:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25  6:54 Wupeng Ma
2022-11-25  8:54 ` HORIGUCHI NAOYA(堀口　直也)
2022-11-26  1:41 ` Miaohe Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5474d574-08e1-f630-7ab2-f688e7e90e64@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mawupeng1@huawei.com \
    --cc=naoya.horiguchi@nec.com \
    --cc=pizhenwei@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox