From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0867C04FFE for ; Wed, 8 May 2024 07:49:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 196D56B009F; Wed, 8 May 2024 03:49:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1471A6B00A1; Wed, 8 May 2024 03:49:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F29346B00A2; Wed, 8 May 2024 03:49:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D66866B009F for ; Wed, 8 May 2024 03:49:08 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 723271C1593 for ; Wed, 8 May 2024 07:49:08 +0000 (UTC) X-FDA: 82094452776.12.6674951 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf05.hostedemail.com (Postfix) with ESMTP id 8A581100002 for ; Wed, 8 May 2024 07:49:06 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="MbV/DHwt"; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf05.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715154546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j3dy4HI7f8Gt9w8DyqZ6Q2Y2Mgigf0cwtxl/Oe/lEUw=; b=Uq74zMK5X05gzkAAx1kASs+53bDEo1PJkjayll0dAE5fDo62Fyh4ClxzxJTh8m8+fT8znB G7mi/Msc0Jgv0wwrSYAPxzINbXWjJYIcx2ovVnxwxwfaOlqR/3OhNmFmlTmNVD/cr+vE8Z sBgmlQ1rVK/9WDsyf6J1CKC5LAvRYIM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715154546; a=rsa-sha256; cv=none; b=zIhupdo3UDmRNfyYXARrxkeU0YI1cXP2WMihMgg3ej9A/V09c38wyB0CdZVKxBIYbHhNHo YbE3NHcbPBhPorhvcbaC2f7orPHZuGUn4XlsrwiTKBb6WvZDQ+E3X1Mfp6hvvffUjyTSFQ MVq/gOEQUKPj08Pbx/iEnbYMN+01qe4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="MbV/DHwt"; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf05.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1715154544; bh=MofcZIwCP6uQfQVp6EE9HurxL3czn6diXGm18p/OF50=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=MbV/DHwtYAujOpXoDCW0s0KB5riHG/p4OMQuvDB00Pz7/gzHkZrQVMbWFe8RMvmKa E7/eZm+J0KkW6WdglkC3NhaZhrrqLwrLM/rN6pAvFjHBThsazg6zRLYCYBJKWtjUwR eLafdjBQjRl8tFVMXaPf7ETS5Spz1U0TN2/pXHhbkRMUKnerr3EUzBLw1LELesDSjx ww1UwcyShSZE5MdiI2h1EXPosoRI0u6sJbDL1yLfBCglfBakx0ihDdtGsu1uPdwGRy epZ0TaGCSSjrbxIQaccEYwAzomyOHcnd+TiIXNmGJ4FavJjakZ9om8hZy1/HJ08OvK /vO//iWp1Vbsw== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id C668C378107C; Wed, 8 May 2024 07:48:36 +0000 (UTC) Message-ID: <546aaaa7-d796-46af-8805-1612759aaaa5@collabora.com> Date: Wed, 8 May 2024 12:48:57 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org, kernel test robot Subject: Re: [PATCH v2 1/5] selftests: Compile kselftest headers with -D_GNU_SOURCE To: Edward Liaw , shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen References: <20240507214254.2787305-1-edliaw@google.com> <20240507214254.2787305-2-edliaw@google.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20240507214254.2787305-2-edliaw@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8A581100002 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: hutxurdb7336hatcxf4h3iwjr14wg7ab X-HE-Tag: 1715154546-254987 X-HE-Meta: U2FsdGVkX1+eXAHPdqxF2YRGtSl3MSvXrRPFLU2IlwEIqhY85SPnTYq4hJAXhThL73I9z3Yt3krQKDVmomo7ocNUJuBAlfLRy0uZWcP1BGC8NPvnxTXIdJOG3S0xZXbvZgpRzwsRc4HIULMyrhAzkSvtqQmU2+zwtQWhP3x0mb+l1tHtdcUYo0otiM5bzEHxCyel5C9CFCHCBwGRt9QOTfAt/QyaD389oRVQcUMUhnN9D7TR1GLjEsKKIzlj0ChQ07u+RLIZVmEwYD+Mao7W8jcJcnhUMv3aYTj3FC5vCxht6zL6BNmpmMMrfV1Atl4CMIJ9yrfNEWx18cvn4fXkdjgkVhc5d5IQHVLvdvPR+G/HW3xI0s4yw4PwXAhVWNXJ5QkzFDP6cSlYGxhoX2wri8KdV9/05XLRt6y2DN6mymGft0GvAGHFiUrejjcTmQqfTT2sQGOK5MmwMK4j1A7NXC0r+c4qN5RIqAW2hpcYNP8MJbLywLRDP4fNSWxYEIprZccLnUKgKEmqs2cDxuA/5/M3TbCpyKI6geuduMqjKb8qRGba0rShuPd3Kib0tc2ZWs1gSRJ0WUB8C83BFm9ysCGLSsD3W9CX4nvWZXAm+sYqMqjZIL+XfuDjLVrLklJb4lVbwmR+gYMWdYMC50CsSu1Nc2lbW5HqSYjuHCLNW+RD2uuGtYPw2WHJeDv6YXiQOUGDnmX68J/X4q4cdHNzphZxT3NsB9LWcC19lNtmip2lGMP27n+vWDDJMMblQaGuI45ZZk1aLVm9waYRcts6G7h8DahhjS6SwHk4MMjmBjmMHACOARVA+oxHAckLkBqUVBnSii5Xgs93wf34Wu0PMFGx4ghTJOS3/SAQDvcZZkvVH4toKLWKZRbUHHpiuyqU2gE8cHIHaDOSVccrCJcnLpOYy9nmnl95U49FtzztDPQc1aVJpHeFciLZygkj7T0O0I+FELSUTnIEYyQ/lmn blXkS2kZ uDGjouNUSNrIV8m00k5Ewm/A6wdjPKmyWDS+Bal/s+tWpfoG3LMS45Jcgte8Li4z7/qFrHBPqu46LQLVKTHXCoJzEHHC4i44s5oM7w5xN6MI6kooEQAXSccrYo4wDCWfvno5JcxSdEaNVPuXqgoExkVsH7Iz7YLXdkHk1EtSttZun0e/NRPWrvzArG2mBIqRBG3cawN3nYf+43iySp2Ta2iwk5HR1hSwVnAhuGk1BwJirOXQ5ZPofNqhvPge/ic0+N/j7zMfhCdKx9xMYBprDaHavlUd69g4DqCQQ+Boah5dzaNOh+0+4Ljd+huk0ieSRlT/0uPpdiDfd4yv6eF61/GH5N8jMwGhUZpKzMZTyqa3mpPIy2DrYyaaJNEGuUC3Ys+fqf+4ub+jCi2MAKMT/TWALiDDjZoGH+OHYGrdn+E79x9T4NoNelA4gd4gzvHP71B4dAckFI6J/wqh4ur/M9EmtGLLGDGPY9XTiEzec2XHjM5Oelp2PN/7MFwWeDfuzezxPo8dfbcgYGY0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks for patches On 5/8/24 2:38 AM, Edward Liaw wrote: > Add the -D_GNU_SOURCE flag to KHDR_INCLUDES so that it is defined in a > central location. > > 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced > asprintf into kselftest_harness.h, which is a GNU extension and needs > _GNU_SOURCE to either be defined prior to including headers or with the > -D_GNU_SOURCE flag passed to the compiler. > > Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202404301040.3bea5782-oliver.sang@intel.com > Signed-off-by: Edward Liaw Reviewed-by: Muhammad Usama Anjum > --- > tools/testing/selftests/Makefile | 4 ++-- > tools/testing/selftests/kselftest_harness.h | 2 +- > tools/testing/selftests/lib.mk | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile > index e1504833654d..ed012a7f0786 100644 > --- a/tools/testing/selftests/Makefile > +++ b/tools/testing/selftests/Makefile > @@ -161,11 +161,11 @@ ifneq ($(KBUILD_OUTPUT),) > # $(realpath ...) resolves symlinks > abs_objtree := $(realpath $(abs_objtree)) > BUILD := $(abs_objtree)/kselftest > - KHDR_INCLUDES := -isystem ${abs_objtree}/usr/include > + KHDR_INCLUDES := -D_GNU_SOURCE -isystem ${abs_objtree}/usr/include > else > BUILD := $(CURDIR) > abs_srctree := $(shell cd $(top_srcdir) && pwd) > - KHDR_INCLUDES := -isystem ${abs_srctree}/usr/include > + KHDR_INCLUDES := -D_GNU_SOURCE -isystem ${abs_srctree}/usr/include > DEFAULT_INSTALL_HDR_PATH := 1 > endif > > diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h > index d98702b6955d..b2a1b6343896 100644 > --- a/tools/testing/selftests/kselftest_harness.h > +++ b/tools/testing/selftests/kselftest_harness.h > @@ -51,7 +51,7 @@ > #define __KSELFTEST_HARNESS_H > > #ifndef _GNU_SOURCE > -#define _GNU_SOURCE > +static_assert(0, "kselftest harness requires _GNU_SOURCE to be defined"); > #endif > #include > #include > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index da2cade3bab0..2503dc732b4d 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -45,7 +45,7 @@ selfdir = $(realpath $(dir $(filter %/lib.mk,$(MAKEFILE_LIST)))) > top_srcdir = $(selfdir)/../../.. > > ifeq ($(KHDR_INCLUDES),) > -KHDR_INCLUDES := -isystem $(top_srcdir)/usr/include > +KHDR_INCLUDES := -D_GNU_SOURCE -isystem $(top_srcdir)/usr/include > endif > > # The following are built by lib.mk common compile rules. -- BR, Muhammad Usama Anjum