* [PATCH] mm: remove the useless gfp in __memcg_kmem_get_cache
[not found] <1416193909-25163-1-git-send-email-zhenzhang.zhang@huawei.com>
@ 2014-11-17 3:12 ` Zhang Zhen
0 siblings, 0 replies; only message in thread
From: Zhang Zhen @ 2014-11-17 3:12 UTC (permalink / raw)
To: Andrew Morton, hannes, mhocko, vdavydov; +Cc: wangnan0, Linux MM
The gfp was passed in but never used in this function.
Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
---
include/linux/memcontrol.h | 4 ++--
mm/memcontrol.c | 3 +--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index 6b75640..9481ee9 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -419,7 +419,7 @@ int memcg_cache_id(struct mem_cgroup *memcg);
void memcg_update_array_size(int num_groups);
struct kmem_cache *
-__memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp);
+__memcg_kmem_get_cache(struct kmem_cache *cachep);
int __memcg_charge_slab(struct kmem_cache *cachep, gfp_t gfp, int order);
void __memcg_uncharge_slab(struct kmem_cache *cachep, int order);
@@ -514,7 +514,7 @@ memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp)
if (unlikely(fatal_signal_pending(current)))
return cachep;
- return __memcg_kmem_get_cache(cachep, gfp);
+ return __memcg_kmem_get_cache(cachep);
}
#else
#define for_each_memcg_cache_index(_idx) \
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index d6ac0e3..1186e4d 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -3152,8 +3152,7 @@ void __memcg_uncharge_slab(struct kmem_cache *cachep, int order)
* Can't be called in interrupt context or from kernel threads.
* This function needs to be called with rcu_read_lock() held.
*/
-struct kmem_cache *__memcg_kmem_get_cache(struct kmem_cache *cachep,
- gfp_t gfp)
+struct kmem_cache *__memcg_kmem_get_cache(struct kmem_cache *cachep)
{
struct mem_cgroup *memcg;
struct kmem_cache *memcg_cachep;
--
1.8.1.4
.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-11-17 3:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1416193909-25163-1-git-send-email-zhenzhang.zhang@huawei.com>
2014-11-17 3:12 ` [PATCH] mm: remove the useless gfp in __memcg_kmem_get_cache Zhang Zhen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox