From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D20CC74A5B for ; Wed, 29 Mar 2023 23:38:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BABD46B0078; Wed, 29 Mar 2023 19:38:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5CC36B007D; Wed, 29 Mar 2023 19:38:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A27A36B007E; Wed, 29 Mar 2023 19:38:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 93F386B0078 for ; Wed, 29 Mar 2023 19:38:20 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6ECDC80FBD for ; Wed, 29 Mar 2023 23:38:20 +0000 (UTC) X-FDA: 80623551960.11.04831CD Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by imf16.hostedemail.com (Postfix) with ESMTP id F2BD2180006 for ; Wed, 29 Mar 2023 23:38:16 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=pal8pLcW; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=IwLM6OxT; spf=pass (imf16.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 68.232.143.124 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680133097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cQsRXxiiPSqjZq6C8GDBgXQmjTf9hI1i4Lz0u05BQgg=; b=yVtUIVqSV3DtvpNVSEQnIgub/+WGxPuL8vsLrEWgg8x7Z3rTeYLR27Tga3oLP7USn5YqXI 7IzEXuI71vF8l4oWoUBOAinlF6ECuD2OOYukO5EXdyi5jVP7w4YQS5bMJBLBudJgg+vxm9 Amyo36Viao+3gpf6a5nVlOgSy3HxKls= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=pal8pLcW; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=IwLM6OxT; spf=pass (imf16.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 68.232.143.124 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680133097; a=rsa-sha256; cv=none; b=eYJ5f7q1b1jSdW1bfrZsn/491qJrJ6j4modPWFOo6LcsdQbBIJALgY0b1MmfuX77u5OcvZ n7fS9quB935rjEKSHzjoOir3PtkUYbSDUrM/AdhoVaTpve9s0MscTs2vUC/PfXeNHIy5Vf Pq/XNVALOaMtlgNpZDgr+wejsIfy9hA= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680133097; x=1711669097; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=trSlsKzGDIdMPkatCLLhm/IW4lDqvQLyF89j6Acxt+c=; b=pal8pLcWdxq/0mAb1iBhU1FqZcJB/I44VQ4z3DZitZAJeI5gHWUL2CgV GG3f8zDyHFWEgCusnjw0hBFKgOMVp+KsmCseJzRe1T2b8ojnEIclRgcxE QwpasXEZZZ7fsYI6Zlvrj4uVpc73psO1wEv8RwnmQDAwbm/z8sYwVO6x/ m7VOIa2TzQ6KgmksyF+wq9iuAGcBqyJLixHIYt5KcdNWC14AeLMyjTCLT VcbtUdwnGJDsCZXvV+VgGWiRqXQUSHx64RLIzdciLeDnrp3e0irVCnc6+ bQjABLp50I+8Q+MQxxV3ttd5vE3N+0UL2IUx78fdDrV0TpTNu0rv2kk9U w==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="331274150" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:38:15 +0800 IronPort-SDR: 0qTrizD1I160ClcfH75GFJuDGYxmRwyVIwozHD9ve5JQCuZdYUxslbj6fPKCi7hw1sn4JXq++6 +Vh0WYzGwmFEUVlYFcrL87Ap7HDvhgE9e7MsHpR0pe1+UHdscZNbhqxs+1vEloEMdSHyuRota5 EfDdNVh/1qlY9izkhaJHFTZqciwgG/moVKsacpsD5vNLx+af3CCBCpm+0UZRnCiJukCdy5/yTO 8X2Yr7PMVn41GS7E/+5R+4WTDfaMu+VUhHIIPhqQoY2mBF1cqmbPSnTu+ywasFXK4uVliCmPe7 rXs= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:54:24 -0700 IronPort-SDR: W9m/PeRo0+0ywY18rE4Xz5MGXqRTKO/BGe43Dk3/+vOlwi8n7lOSZ2KahBmZ2+N4W43TWsKTgF O7v9dDlOnISdGLeLDJ4HBuz3gdqL5008PUzmWhRvUCKkCsOwgxrN68UdZrg0xP/QLlDj012tML zlX4+p1VcvRl7Pn7OELrTmJp1hP8ixxwKHr3VP/2eS7mgKoZBu7MUTAvf44o2q1zzJmCikSjXA Qotpc824IZn6+hXxGJIULJPOLsWjA/gsio67UgSBMM86UV6Rzw2SaherY3D+DlJMDqoNRbv6wX wyg= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:38:16 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2zq24mvz1RtW4 for ; Wed, 29 Mar 2023 16:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680133094; x=1682725095; bh=trSlsKzGDIdMPkatCLLhm/IW4lDqvQLyF89 j6Acxt+c=; b=IwLM6OxTQ5LWzxAC4NcyXZ1dr2nvfgOzo9MYnLjHJuGsYvXhajL hlDO/OUe2nXi2knwvLTDrpf7NjCBruC2QzmIpB4JE9IyVsUJJAG/YLLsSyvDJh6t qxwxrHBhyTsmBCFnvPnxGjsvWVabw/lioMS9Htl+JJJqa4JvEgAHA2zECs+RUwul t+dnEFKBLZOQyEWCGPk1uA6JA048hYHWTFe/WWVJRogq+WSguIeHywIZ5y4oQkjK dU94SWBhAlGUm9MArYUGt90AtfkGpTivTX688Qa5D0tXrxVoC2lWcu6DZA0NboRO DWfvkb0SzT2gUKXzOI9on0y1QnPiBSGbu9w== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KnHrYFnFC9jr for ; Wed, 29 Mar 2023 16:38:14 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2zl2Krzz1RtVm; Wed, 29 Mar 2023 16:38:11 -0700 (PDT) Message-ID: <546786e3-79b3-f9d0-008c-23d2de7eb3de@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:38:10 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 15/19] md: check for failure when adding pages in alloc_behind_master_bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <76f5748e386870c034b46e919101a878b87a79bf.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <76f5748e386870c034b46e919101a878b87a79bf.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F2BD2180006 X-Rspam-User: X-Stat-Signature: r1fyiaekkjhoagqsfe6ymjz1tteez8cr X-HE-Tag: 1680133096-730928 X-HE-Meta: U2FsdGVkX1+UYxh9dUUnAfdIiyLzCSarF9uqOiuMdbBl0eEsRTBox5NZv57+jGEdTXp7/4tZjPkPP+YWfXUQiVeGTmLscgfikU/+zjpv/JmFBsbvF2yaIYuTGXFzxbbLaGRqzBkQNuqJf/jgDVcYllMGOjLLwENRpmOzTIpRAx2xISyUWeHudVB2LCevcp9DGOFu685GZsmLVvKmbii8QLCUgir74q52hfvafU1nHFoF2b0SlENwYQm0S3/43lRJTaABLwrICiG9CfqD2YtOnE6KWTx1g+nCVh/ZETmT9Fe4hCVotVmNCuEsCjZLPhSdmsOyBF9mbBDulrHnxKzrhta//c5Lq3roe7LAVV7ERSpxhjtihsMFR3B4lkJOkCfupsliXqzEkRDKirJ2ma+YneRaKzUYSAsMaWU2J4biAKgzCOIfImCblpVq3P9ITPytXg0iD0R/AjRDWlo2sk8uuGRPNiANbnkfzlBAKVJrn80t6rNVFQtbDRg2r25VfiAhVJ/DZf9rRrY0+0KnrOyj6JUnjq5WNrHS3WVfVGYPGUa/DRIXnXQkZ9gr1jBYkkI7u2vQO/6tWtzYDRm85Dq0bgh6HjCTChdaHDul08j+YYeXHnCh9H3BCRvqFdBCGxOCOmQ4dRh4QZb9bdm6ua3RxZPrE7jX3fQK9eZn8YMx/an+0ul2exkAiFWKbyEU+BW6B6tTLBxl+RPqmW0znNg56wB5ck3gwAszSuTRb/NjNL5KyGr5T5Zyw1GmutLC7FncxdKzfbJ4rdy6Z+sjiew8Imr1zqWh4nTqrwDIN9sKPHIKTG8K3HprD9TBIDBnbG682fKAP1zDwKMmixqCSiAC/kmYqz1Q2a4lFo3d9u1yhUYJcapWl68atISdow5RCrOGq1Sq65nxT9Em7ydmzW+Xqc37oLlr5Bp3/u5LALxtYHnmqKf6xkmHDCk6m/kox2rikgRu0iNvb0X7NEyhs2J Pjq4BcRN GJkBn7p5b9GinxYG3oSxAKMa9DhS/xOZtKcIRIVTSGfjToUL1Lcy9URqJTj0jfrSYegYSIxa0BRaKeeFJw4xNmRORd/IDNdfCElFxicvWvoatUmQUOtnZ6yg1WFf8edegIY/P0g/uuxIs28zK9D2ghOfgDzHD7etNpvTW/WPWx5m1jwbfSdRG8MWUmw8sJICXZ6nmpU++zI0gk+hOkndDfnuOcCP1qWoGobhji4oRqgZ2/UlGuzPQvDnwm4+kisYKatWek2ApIol4XXTKK/UbVyZP/6VxomviTxBiVYQTuDxewd/jZiYvQKTZcV03/xiqS/Np8Dwmaj4q3jSw2RBLdzIvBhwr6AswbyJnyhM4HbYb/5G6vUfsbWzY6KxSI/VKzpmqjD+fhj/Aw/Tkg0UsWQdZXn4wYMYPddHSdkghBb0ia2gYT0xRBgRdTAUA3CRVtpVgjNCzT4F6a6g+d2Rd3EgqFe32TIibTkYrGqrobRmJXWTH4qjS9/EpHNN1352xhzShMsj/hMJaZTWw+lq5SBmw7/5lf8QFBknAzlPN/stP9Wezfsi5NpEXoBQLhzL35XadCVcjIyu9qsmEZ/2SfW+BSSBx36uNCrUObe9nCVPo+g+TFB0z5n+UrunkiNuEJtpXGXJWU/VSgRHNRmm6K02qA4cVp2OHNG0z/vnv6f1d8Ay4iP9odbyOPusM7nUIPHi0HswHQUjHZg/4pDQbylXCfw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:06, Johannes Thumshirn wrote: > alloc_behind_master_bio() can possibly add multiple pages to a bio, but it > is not checking for the return value of bio_add_page() if adding really > succeeded. > > Check if the page adding succeeded and if not bail out. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research