linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Masanari Iida <standby24x7@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, lcapitulino@redhat.com
Subject: Re: [PATCH] Documentation: vm: Add 1GB large page support information
Date: Wed, 05 Nov 2014 15:07:56 -0800	[thread overview]
Message-ID: <545AADCC.5030102@intel.com> (raw)
In-Reply-To: <871tphtftg.fsf@tassilo.jf.intel.com>

On 11/05/2014 02:58 PM, Andi Kleen wrote:
>>> >> I understand that there are some exception cases which doesn't support 1G
>>> >> large pages on newer CPUs.
>>> >> I like Dave's example, at the same time I would like to add "pdpe1gb flag" in
>>> >> the document.
>>> >> 
>>> >> For example, x86 CPUs normally support 4K and 2M (1G if pdpe1gb flag exist).
>> >
>> > Is 1G supported on CPUs that have pdpe1gb and are running a 32-bit kernel?
> No, 1GB pages is a 64bit only feature.

This is one sentence in a document that nobody reads, so we're all
putting way more brainpower in to this than we should.

We can't universally say that "1G if pdpe1gb flag exist" since a 64-bit
CPU running a 32-bit kernel doesn't support 1G pages *despite* the
presence of pdpe1gb.  I think that makes it a pretty crappy thing to put
in a document since it's just misleading.  We can't spell out all the
pitfalls or all the possible combinations, and it's not the place of our
stupid documentation to repeat what's in the architecture manuals.

	For example, x86 CPUs normally support 4K and 2M (1G if
	architecturally supported).

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-11-05 23:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31 16:01 Masanari Iida
2014-11-03 14:24 ` Luiz Capitulino
2014-11-03 18:18 ` Dave Hansen
2014-11-05 15:21   ` Masanari Iida
2014-11-05 15:31     ` Dave Hansen
2014-11-05 22:58       ` Andi Kleen
2014-11-05 23:07         ` Dave Hansen [this message]
2014-11-06 15:31           ` [PATCH/v2] " Masanari Iida
2014-11-06 16:40             ` Luiz Capitulino
2014-11-06 20:15             ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545AADCC.5030102@intel.com \
    --to=dave.hansen@intel.com \
    --cc=andi@firstfloor.org \
    --cc=corbet@lwn.net \
    --cc=lcapitulino@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=standby24x7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox