From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1489BC28B30 for ; Thu, 20 Mar 2025 16:02:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48563280002; Thu, 20 Mar 2025 12:02:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40D22280001; Thu, 20 Mar 2025 12:02:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28782280002; Thu, 20 Mar 2025 12:02:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 078AB280001 for ; Thu, 20 Mar 2025 12:02:15 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 226B8815F0 for ; Thu, 20 Mar 2025 16:02:15 +0000 (UTC) X-FDA: 83242396230.15.B28B0B9 Received: from 004.mia.mailroute.net (004.mia.mailroute.net [199.89.3.7]) by imf09.hostedemail.com (Postfix) with ESMTP id 2CD26140020 for ; Thu, 20 Mar 2025 16:02:09 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=GLJEwlp6; spf=pass (imf09.hostedemail.com: domain of bvanassche@acm.org designates 199.89.3.7 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742486530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L+t1vbF5G6CUMHJJ4SRep41Jv1AETPf0sQm4+Lu8AlA=; b=vIFrgrNpPYVM7jt9XU2BiQ8Qr05wFIs8H92YWZi/MdAFACH+8JRjCpRXFwb/ywNXyZuEKM r2L+qBEBi3FHCIux7wxcMF7mmfDUilKYzqC1CbPX31kmHG++Vz7CcGwqa4zEXf/cYudLEi FdVo4q71fKBKecniO6IPybuH7kQyolI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=GLJEwlp6; spf=pass (imf09.hostedemail.com: domain of bvanassche@acm.org designates 199.89.3.7 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742486530; a=rsa-sha256; cv=none; b=hX94djkrrFbkZkYGTioNjHCU2s3jDan+N08Zo+AMwrBOWPh05Nba19HoVj1xF9W+bAqhxs XTmtSxYNW8+eXYSrlWFOqBOPD1hRsWLXNHfw9L6NRc9u0uKi8IZRG/Jto0FnCB97c4HILf lZsRZfoswl/4SwNUG3b6xhNeY38AAuw= Received: from localhost (localhost [127.0.0.1]) by 004.mia.mailroute.net (Postfix) with ESMTP id 4ZJVhJ1BGvzm2sXp; Thu, 20 Mar 2025 16:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1742486524; x=1745078525; bh=L+t1vbF5G6CUMHJJ4SRep41J v1AETPf0sQm4+Lu8AlA=; b=GLJEwlp6gcF+mZvr6HrFHGcZhV356tgrCb1VIDzJ OcDLpHSnuELn6lcz38pcZxa0hlTZ++3UPatWxmWJUtLzJldFEOg8+Yd28BtYvQIb 4sBDyZG42ugs6C6phnsRntde6oiNsytdjQO/PS57tuhbXPWZ0Mh/Xul1X4gyeD3l FO1wLHDib6SPKX/JwQsiCPOJ/YJctX0TOmG++89mMBdsubySRkX1ze4ZSXQblTk3 F/8ZVra2U8AMICAfryDuV76SdSQHFTxZUvzi17mb8S5+Ho30lOIrt4WAnYasS+d0 HodS76jFKXbFD3XMXjQOfqU+enUGlu0ZYE//aOq4RfLv8Q== X-Virus-Scanned: by MailRoute Received: from 004.mia.mailroute.net ([127.0.0.1]) by localhost (004.mia [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id 7OPQbcCVP3Sy; Thu, 20 Mar 2025 16:02:04 +0000 (UTC) Received: from [100.66.154.22] (unknown [104.135.204.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 004.mia.mailroute.net (Postfix) with ESMTPSA id 4ZJVgx00Zqzm1HcN; Thu, 20 Mar 2025 16:01:47 +0000 (UTC) Message-ID: <5459e3e0-656c-4d94-82c7-3880608f9ac8@acm.org> Date: Thu, 20 Mar 2025 09:01:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 2/4] blkdev: lift BLK_MAX_BLOCK_SIZE to page cache limit To: Luis Chamberlain , leon@kernel.org, hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@kernel.dk, joro@8bytes.org, brauner@kernel.org, hare@suse.de, willy@infradead.org, david@fromorbit.com, djwong@kernel.org Cc: john.g.garry@oracle.com, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com References: <20250320111328.2841690-1-mcgrof@kernel.org> <20250320111328.2841690-3-mcgrof@kernel.org> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20250320111328.2841690-3-mcgrof@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2CD26140020 X-Stat-Signature: 1n6a4o4iqwdddukixkjmry4o4hz9ospe X-HE-Tag: 1742486529-510703 X-HE-Meta: U2FsdGVkX19I7fCKiassX+dG+l6gNZ2iWvpXYC0clmhoi94yP/MP/Rbqe8k/JnOb+V6hSmrwUNd5bZr1tvKaUodOmm5V45iebs8UUvIqgjRATaHiaJFmDzY++UpupOpKFMvWGi681pJoQjPHvA5TSWeoNyfHkeTBV65vhoM3Id3mejoE230qlsMXzB8wnznEq9dYhC8zu+hsOLUSN1kSyFZNPSJ+C5JFqOSwMdzKVJ1i0XECMkQgFI/Iob/kEilsc0yRZGa0pPi2MF7TIBRqL+E0sKj5Bg1oZKPlTGosHeFMTLfMctrQm9MXcxZP4+BAwVbGnga1+B1jXZv7vGE4RCACQ8DfyPd/wUOBgQiN4cDb0Wkv2eZn+OoVDBl0aNUWZCnTPgG5GeLfOMNcvN6l6LSMTwX4Pu9gJeH77b7eVLHMnf972I5YKT8JMqvi6MJYtnAltdMBMy7uueFlQ3apjxXbFpWVrMPmkId9WqqYR5Teptnvx/zhiFmy/46b+5v3zaqMRKls98Cj5jXU8glj3fzXVYD1+mTpz7ijYRavcWue4hVSjRd307SUurRVnikQW/v/qxKIAyiUp32kjKTohaLNbUqQracw6RRCFE3HfOJarjHhHn9kaIX6pUA6910pj6dpB2eXq+8P1/mdYzS6UnABM6c9kvIQ8ZcgJR+111noyrPBUzBMuihSi3Q4a6pFIWrHnuGDVX6e+8RluwFTdiM0y1hAhEV3T/4nvwCwrBZmqcBoly1IqBT3itU7qrGVSYvP7gieHMCBHFoQwH/P3qhgVoOIjCk3e/bVzUIwJdHVshVHx8f1ekjYgfILI0zqFc3MMQwNrFN/YYHNuqpHgmXT0vh1YIUkd1jcZ0DcwShTBn+bG7fZOV308yfdAR+bnA1BoZa/4XW/VOd31/KgQa3zpHYFP9Lujc855HJTfG68BN0Vh6q7BCNgD1aMuPNSdHlr6/DV6W4HF8UV9bK gzocMr9a aHU6GPE//I0RYKYn64zSmu8ZC3JPrc2rwhjpHR+FbpT0kcazI2TneqfrYNuHPQ14QBvFU/2BwF17UF8EZn4YYqcCFt5OGEhFcyZdnjwYeXpH3npdhILUfTlawu+Q8u6m4+KWMnWXah6RXAoFsZ/tW0CR7dqwhsfkJ2cwC4TVzLcP1NyjCgoQo1mIuOtL5CIPckhUic2VCrskyiCQ6edodjHQ8DI7YdqEx4zHhzby13TOJCc2OvugAt4OxS1nEAn8owPnn84Y8YJmlT6/tsPdbRH4bKnA1AQOZvERfT+A2tefP1Tie61+dGFcbmbNRxvK3++VvHgGzBk6AIyO06KW7otfloayT0Pp7cILv/m9/wZ9qr1vDPQ+I1Ji8wRItxfEyeshGnDlpo21bnqa9Em7+FPsXjA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000476, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/20/25 4:13 AM, Luis Chamberlain wrote: > -/* > - * We should strive for 1 << (PAGE_SHIFT + MAX_PAGECACHE_ORDER) > - * however we constrain this to what we can validate and test. > - */ > -#define BLK_MAX_BLOCK_SIZE SZ_64K > +#define BLK_MAX_BLOCK_SIZE 1 << (PAGE_SHIFT + MAX_PAGECACHE_ORDER) > > /* blk_validate_limits() validates bsize, so drivers don't usually need to */ > static inline int blk_validate_block_size(unsigned long bsize) All logical block sizes above 4 KiB trigger write amplification if there are applications that write 4 KiB at a time, isn't it? Isn't that issue even worse for logical block sizes above 64 KiB? Thanks, Bart.