From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 084A5C25B4E for ; Tue, 24 Jan 2023 07:06:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F4D66B0071; Tue, 24 Jan 2023 02:06:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A5796B0072; Tue, 24 Jan 2023 02:06:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66D016B0074; Tue, 24 Jan 2023 02:06:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 58C496B0071 for ; Tue, 24 Jan 2023 02:06:07 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2A20812041F for ; Tue, 24 Jan 2023 07:06:07 +0000 (UTC) X-FDA: 80388808374.28.0CF60A7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 571E6C0011 for ; Tue, 24 Jan 2023 07:06:05 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OWz+Zaqd; spf=pass (imf22.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674543965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rhCMs9O93TP3iVRzGs1BbEvUjRACrPO+EAB004pe+8U=; b=lgDF1QATk3jzo3tWQN6STpgEZUxO70vug9jZdp9Kg4WaDuNB1L9I8zZwtJhEyX5yEJ/suB SPqcLucCx3DFQMVUFYmYgfuxuZQ2Gm6ZYfnsBadc1CaL1EM2Xzr3tIG8BrX23Qn0wTh0Ai xZF0w/fuyByWC/VmVAJG7srJ7JUZyRY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OWz+Zaqd; spf=pass (imf22.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674543965; a=rsa-sha256; cv=none; b=0ejJEIepKhNmaVyvr9i1eJdYazuKAX53K8KOI9SKU9WsI7wDc7+B0gijhS0iUZXGzskpGH SkfAEbSNIO5F/YZ8O5tKmu7RzHqdFBU3O+BKU1rsLbJnzhflOzU/F8j7PDJO2BP/cxIcR+ 5nJ2RtyvznBPnul7a1slslQ0n1ybQxA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674543964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rhCMs9O93TP3iVRzGs1BbEvUjRACrPO+EAB004pe+8U=; b=OWz+ZaqdrJxJHhdMIO04YLM5xVI6fAeKVAYdvuR+l9zlsnp0Qg+WsM8tjyIfgPASnsl4Ey RMAMQCm88hfhhddPh4dJmUXlOJPzPxOup1Km0513XlTxhEqnH4/ivgUClq/3hQAJRNaZr5 js669rSuv3YpEbBlRjK+Pj50ipJg6js= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-134-E8IQKbPzP6aPaqoZBUn9Iw-1; Tue, 24 Jan 2023 02:06:00 -0500 X-MC-Unique: E8IQKbPzP6aPaqoZBUn9Iw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B9D02811E6E; Tue, 24 Jan 2023 07:05:59 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83142C15BA0; Tue, 24 Jan 2023 07:05:57 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com> References: <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com> <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-11-dhowells@redhat.com> To: John Hubbard Cc: dhowells@redhat.com, Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , "Jan Kara" , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, "Christoph Hellwig" , linux-mm@kvack.org Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <545460.1674543956.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Tue, 24 Jan 2023 07:05:56 +0000 Message-ID: <545461.1674543956@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 571E6C0011 X-Stat-Signature: ypsssgdxqr7pdiqunp9dyj4h9udymbsx X-HE-Tag: 1674543965-65050 X-HE-Meta: U2FsdGVkX19YOvB6pBQIAXek51B6FBRPn0QCfvQAQ+/rqU4WnAtcVyrMzKy2t0+tuPoe90UpHC1BLFWPOSAAVaOAPDKZ0nLqZ8B65LRYLIod2CoubtKaEVvNR/0krCVUxoBR2QRkvKVBUJ6HdZaqEebOfORHua/4x35fCt+7eGBCyiitKecXAS+kwq61BHev7i1hV1+bXrLDPPWhUbopmwSHgiIYFci+cWYEwnFYHfPPm5QLBsxpAZ6mA3u6Krealvt3pfTH1NhzXwQEc0XI1Or3sHm9uGaUn8QQQkaMZabLJaPxNZ5B71myfZFu6Qh951ANuy5kDpJDMCvUZHSIXo3Y1fRGCj46ouSfGwi6PvXsLahc0gIKxEckOjJUiOXXrPB53BJgf8+DGn0ZcOS17M8VucOM3d7wlUa0PqpdXBxx6+CN+lANM8MQG/bszzzjQtD9rbSeonrbO0Awh2BbpRs28oPXbCf0wgaMDyhilYoUOmnAP80CWzYprJSygZ4+RTho4OtpmZ85zY5Ax0aP8+AQD6+0gxLfJsHtso1XstbmV2cAkNf/JfUZa2AB+HvXLaJOwZLbp3YNw7PCHCrxfeg1D+cG6Cykh6WJR9zBWKReFxYdvoRfqAYKP/jYCqV6Z3ZnDlDnDEYIIRiHKrsnYaGXybvRr6cZNp/6sly7vxtfzH4nlAwI4V/EFukUFx5fS3OiWHH/kGI9sCDehOjPW6I9aYfRgx+++5ZDGaR9+SckfRj2s7C2UM2e5jNvc3LyjVFUFLIUSdQK+iMM0go23P65ozC1+HpIm+Cz4Sf4YGGMByZF0PGKKki5MxOuAULBqSdaAMEdreZ6ugLP0JM7IV9OO9XsL09iE09cSbyJH8dcGxCYu7p9L/CbK5V7q/ROtxt/1VM1P7LHmy2wQfpouSW385lVCSTJIZq24FkbZFuJ3TUgowX8ZWOGrY/7x+RO4YrgM1/xtjjLpvGzaVb 6Pv2Tbqn j447I4yNjZCuPmaS5/QdwNKXjVCw7CbAEdrmFlzLAIHgrw0nbN7cdQQzNPF6h/Xn9Z8Bclgc+WCJOICKRI6in+edpGGXnfP7ZWXHADpa+4HYFdohZhLZ3MaWg7LVrMUgOtL6Ekp/EMPtLXcWxniiVWd2PzatZlS4ZAxt/5LdkUVqHCwA2hor+mHru0wSoT+mbxzF1GCdXWQKysyGoY4Dw4h+bsFBxGNzvcgp3DFzb4YwNdZ2U/Y/3NM1b+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: John Hubbard wrote: > > Renumber FOLL_PIN and FOLL_GET down to bit 0 and 1 respectively so tha= t > > they are coincidentally the same as BIO_PAGE_PINNED and BIO_PAGE_REFFE= D and > > also so that they can be stored in the bottom two bits of a page point= er > > (something I'm looking at for zerocopy socket fragments). > > (Note that BIO_PAGE_REFFED should probably be got rid of at some point= , > > hence why FOLL_PIN is at 0.) > > Also renumber down the other FOLL_* flags to close the gaps. > = > Should we also get these sorted into internal-to-mm and public sets? > Because Jason (+Cc) again was about to split them apart into > mm/internal.h [1] and that might make that a little cleaner. My plan was to push this patch by itself through akpm since it's only an optimisation and not necessary to the rest of the patches here. David