From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2558C77B7A for ; Thu, 25 May 2023 14:12:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B5E8280002; Thu, 25 May 2023 10:12:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26634900002; Thu, 25 May 2023 10:12:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12E48280002; Thu, 25 May 2023 10:12:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0009E900002 for ; Thu, 25 May 2023 10:12:16 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BF07C40B5C for ; Thu, 25 May 2023 14:12:16 +0000 (UTC) X-FDA: 80828967072.02.8D46FBE Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf20.hostedemail.com (Postfix) with ESMTP id 24C341C01AA for ; Thu, 25 May 2023 14:07:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=FYZ4Qv3l; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf20.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685023666; a=rsa-sha256; cv=none; b=LGe73XlbFu1yvngDn3NJGNGYLugyW47pKlXn7VxJgkmtdV5FUsEAvJ4eW/bvYdcPxuZljB T3Ha/k9VkuF37FQpoRaBtZN8D+BiWsKtl64lGu+zOLGhucySwuDcGf7bdbJ7BIs/ITf96/ thQvmnL5kA2NaHXSBtGhdQyKPAYwoBM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=FYZ4Qv3l; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf20.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685023666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c33tBT8cy9JPPgdRV9qNDNmoB5Xhj3TMTGSWoBJRi6Y=; b=RVfoG6vpTAO5Y3DMyFMM3SWprojoqatcBoR6UJf9in2GkA+eRgFRLdhryeI5j8P6cPjCIj RaXc+0rEstSRZQOS46tgQR/56QGEBANDqdX/XA9pb9BUqODnCRzKG0KVtf6Lprg7obF5Mg mfsIxpvxQnpk6LlvagCbpCFF3kPqaFc= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1ae3ed1b08eso14496565ad.0 for ; Thu, 25 May 2023 07:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1685023664; x=1687615664; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=c33tBT8cy9JPPgdRV9qNDNmoB5Xhj3TMTGSWoBJRi6Y=; b=FYZ4Qv3lhHI2M6JlMLNPzk+I50IUxOLOyogHAdzY/9dAsG8hcofW6kRBUtQtqme6eF El9ACrF9m6b/U1v8bIU9e6ogQnPYpCAlIPROFX03fQH6TtFmc+NpjRypzzUfvLQcCPgA IMmLH6zkb8bityx6mv4Sc2Ngs1jHgYVESI6kU386dGSu1gtYkoe5zYsIezw/Lbapda2D nzPd62vGlE4aAG9wK8L5blxg5ilcUkQLkzhsgEsNhgv0XLZ251TEbnLh/AN6hpKUPdj/ oCrWYI+n54m3SyBU4d/ncPb8TQUouvgBEbP8YkzUCmoCXR0LG38N128QLQtSZRlCobg6 IAWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685023664; x=1687615664; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=c33tBT8cy9JPPgdRV9qNDNmoB5Xhj3TMTGSWoBJRi6Y=; b=J9e1UYTlsYxLk0UqtB43IIesI0fPoBq058/eCooeoJfbwrdN7b9xhBjSMafqor+fQV 74Aa1K5/Qa+8rX7b8xV4YW4xyfXUSUpXc4pJuiINt46oUMl28SL5bBeR7YT2QInyG0gb HVkxbeOAOQ6FhRzBmtt37rcGQM9w9rtfzHSw/sx4kUp3hUanrOYN4N05kT2LsbGHycYq gD7cVRfnB8Bg2TqU4fikHlgCsOMw5euGtvpoiL1FscIHRAoziC3YTkEn+dpvB3yaGuYC t1pag3Nxud8G1dW0aZGR4JMsYS2eqK+x0bJa94ZsbkSikXevGGHheDU1xxJ3bm/4GTxs y6hQ== X-Gm-Message-State: AC+VfDzmnsRSF917h8pi0FhxADmxv4t6dmQ9mDir3t3nDGzyLBNoJf9L dAd6zPQ2BhBsXHH7VZby5OCl7w== X-Google-Smtp-Source: ACHHUZ45yFuJ/9A4MCbSl44XKJvuN/lObdaSmxg20qFmfGTxUn37ZhJoyCioHCu8T2L7XphJ/xFaww== X-Received: by 2002:a17:902:e88b:b0:1b0:f8:9b2d with SMTP id w11-20020a170902e88b00b001b000f89b2dmr856962plg.29.1685023664547; Thu, 25 May 2023 07:07:44 -0700 (PDT) Received: from [10.12.184.48] ([143.92.127.226]) by smtp.gmail.com with ESMTPSA id v11-20020a1709029a0b00b001ac5b0a959bsm1478099plp.24.2023.05.25.07.07.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 May 2023 07:07:44 -0700 (PDT) Message-ID: <5453d94d-c231-6d50-02bd-a510109bb306@shopee.com> Date: Thu, 25 May 2023 22:07:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/3] mm/mm_init.c: remove comments in zone_spanned_pages_in_node() and zone_absent_pages_in_node() To: Mike Rapoport Cc: akpm@linux-foundation.org, mhocko@suse.com, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230525040150.1588-1-haifeng.xu@shopee.com> <20230525082444.GT4967@kernel.org> From: Haifeng Xu In-Reply-To: <20230525082444.GT4967@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 24C341C01AA X-Stat-Signature: ii38raeray31jhsd8qkgxtyoc8gom95d X-HE-Tag: 1685023665-137171 X-HE-Meta: U2FsdGVkX18zfBaleEcVPz/MNEUw2lPk9XcIZ0ztLTCbKDQ0MB07fedeUWinazzqgU0O1UAMecZ1QlooTO42N9ieEDeWcGzeuhZ/7bPsFfI8wk8YiAqC26sHhnSiIiz7Htgko/vw2J4IJR+OJxQ+Q4NRufXrYJqhnTQmyesCgFbeR97N6o9v6N/ApYWAl1fVl8o81dRrzFtC4ET90V9Xwn4866jZJgd5X4zt2DPqxiKHCrOV3aSgP2itKZ4FlSaaxw5Db2w20JC6NyV6Yf+UMqK/770zz9idFJgYsVUQLJxPY3IX6ViPRL6tFB6gZe3HxJkz6FYu5Xypy541qfOExDo00exz7yfTFUnoxLu/5/2xFcrsMpWkVBwOlK1QP8bKdM4Q02SPAom7durLPvSIH24ImvSy4USTtCas15hmQLQLMZBxDcyvMtg2EaKT+4nR4Fon7P6FkH5QcNHjMP27uo6dcqVJPBfs8iMAqc7hNuwKOXKir7/KQ7P8sX3L+Bq5Q/Z/Qz+SA9C+uTBIUKZsMBFYEOPWhvhgl6LegkmQMPt8k9hQOHSPetHh99Xm3lvgXGiKnaafOI6ZLmXvZX2mOU53oRdyE7RGHbBHSvlTXOWIM1XCMBqv661Yj1As5n67G1MfZkfVznftLuzVmNu65jMtz1wUKUcJHbwAB58Oe8vqyXJfaOeMcq077P7KVETKwa+PgbtUdskR/9GcBQXKDnTnjFgkjnCJm2hyTzdOGf62hg8L8NQ91ny3AiUUIlJH+SjKJVlDssmPWKbmJ7fjltvai1ts8QM2pMsbmOdLWk7BLPYPGLH+eTR6n+g7IDRIdrEjfhcyVljgp+SBdGX0UxEUQ5J6/+y+5FDmkVUnamshs2+u8fJI2ZBoQM8wKS53RZSRUGb10OG0KrheZC7OEl0isVzSOvRBMTU0ODtOf3ED5TmeKt1zPWEcGQo4N/iBBPykrDRcvyGw2uff+nz W/+ZqJv6 6wdq38i1ev4lQ3RkCQ9K5htw+WsfetIomUzUWAR9c9lPoBhQL/ROPJfaL5/Utidu8xuKkxOi3xdaEFefyrwdp7K0DugC5tPxnYE2Lgp9C1uSCz5/VEK7aqYAZLpo1pRLBRR+qj4pnfFOawd2RrvsydQ3wzYyleswrx6hKswjFS+zAagcy7pTdV4k4nSDAniNI29aqG75+ikwKLypabddjI1gp9H0YgROiMEFJg62dj/54n3KKTVYwFuh0E/O4F/OEHrfORQ3trfPNKvfFkUWsDNb77YOFGM16AmUIVG5sdWEmVvh1VxDm/v0nK4c3SQHcXKqAzfR9gasnYWkQnPTp3Uf+zEMhma78dA761yC0Ml3KShgUGfYllgSX4qbWNwBg5+H8plMVgh86u+GN8RpnUIK0XHoLqfWPti1zfdpBpKBEbqc17DsZAgqYByzdjgL9KPByTUPEya6wmVM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/5/25 16:24, Mike Rapoport wrote: > On Thu, May 25, 2023 at 04:01:48AM +0000, Haifeng Xu wrote: >> Since commit 03e85f9d5f1f ("mm/page_alloc: Introduce free_area_init_core_hotplug"), >> free_area_init_node() doesn't get called in hotplug path anymore, so >> remove the comments related to it. >> >> Signed-off-by: Haifeng Xu >> --- >> mm/mm_init.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/mm/mm_init.c b/mm/mm_init.c >> index 7f7f9c677854..cf55bba04b23 100644 >> --- a/mm/mm_init.c >> +++ b/mm/mm_init.c >> @@ -1174,7 +1174,6 @@ static unsigned long __init zone_absent_pages_in_node(int nid, >> unsigned long zone_start_pfn, zone_end_pfn; >> unsigned long nr_absent; >> >> - /* When hotadd a new node from cpu_up(), the node should be empty */ >> if (!node_start_pfn && !node_end_pfn) >> return 0; > > I think it's better to call calculate_node_totalpages only if node actually has > memory and for node with no memory we just need to make sure all the node > and zone page counts are indeed set to 0. Yes, it's good advice. > > Then the condition here and in zone_spanned_pages_in_node() can be removed > along with the comment and patch 2 won't be required at all. Regarding to patch 2, if the node has mmeory but contains zone with no memory, it can avoid the calculation of absent pages. I thik we can add a check that whether zone_end_pfn is equal to zone_start_pfn in patch 3. If it's true, return 0 directly. So patch 2 can be dropped. Thanks! > >> @@ -1227,7 +1226,7 @@ static unsigned long __init zone_spanned_pages_in_node(int nid, >> { >> unsigned long zone_low = arch_zone_lowest_possible_pfn[zone_type]; >> unsigned long zone_high = arch_zone_highest_possible_pfn[zone_type]; >> - /* When hotadd a new node from cpu_up(), the node should be empty */ >> + >> if (!node_start_pfn && !node_end_pfn) >> return 0; >> >> -- >> 2.25.1 >> >> >