From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40C07C32789 for ; Mon, 22 Aug 2022 09:21:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB7B48D0002; Mon, 22 Aug 2022 05:21:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3F526B0074; Mon, 22 Aug 2022 05:21:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E0198D0002; Mon, 22 Aug 2022 05:21:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7AEFE6B0073 for ; Mon, 22 Aug 2022 05:21:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4F150401A6 for ; Mon, 22 Aug 2022 09:21:50 +0000 (UTC) X-FDA: 79826686380.12.93E7A6F Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf06.hostedemail.com (Postfix) with ESMTP id 75546180035 for ; Mon, 22 Aug 2022 09:21:49 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MB6J13D1RznTl8; Mon, 22 Aug 2022 17:19:29 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 22 Aug 2022 17:21:46 +0800 Subject: Re: [PATCH] mm/hugetlb: remove unused local variable dst_entry in copy_hugetlb_page_range() To: Lukas Bulwahn CC: kernel-janitors , Linux Kernel Mailing List , Mike Kravetz , Muchun Song , Andrew Morton , Linux-MM References: <20220822082525.26071-1-lukas.bulwahn@gmail.com> <08fec67b-788e-1c9e-606e-903db3bcad67@huawei.com> From: Miaohe Lin Message-ID: <5450a153-382d-7476-8674-4a615d08eebe@huawei.com> Date: Mon, 22 Aug 2022 17:21:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661160110; a=rsa-sha256; cv=none; b=Ig5kOdV9nVy0y+FqmmD77bbhkdYX81h6Nn4UmF/14r8GKq2/+zxJcMXk0XQVDJ79wdBDgR d2JKd+x/6wRqi029pm9jCVCR4Rn1T9Obu+a5nFoc251slAZ0zLEmoP1j4hcUnhbSZDACxY YjNlD7kisPaAfoopaapMApzc0t16XO4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661160110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aUUdkvmUab1O1lyyQyyxYd0HsouSqSL19eqsHsmoRFM=; b=EK7YkNZIjNptYABqwOSovfW6rmqDXPzr3jAPGx+Hy9TGbkQDz3J0z8Vt22SDMg99IOkOV0 32/1WKvAPKmjM7PzgU/PI8H7Uru00UWbhAVd8TQdpkvaM0JUAgfZwNIfosoygpyrFvg6ds 2FIyHRrPC7iGvoMyTA5iWxbBRWIoPgo= X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam02 X-Stat-Signature: eudqgjf7qqwsrc4nrwaqcgbs1atk5ba3 X-Rspamd-Queue-Id: 75546180035 X-HE-Tag: 1661160109-548577 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/22 17:05, Lukas Bulwahn wrote: > On Mon, Aug 22, 2022 at 10:51 AM Miaohe Lin wrote: >> >> On 2022/8/22 16:25, Lukas Bulwahn wrote: >>> Commit a0e4f7b82610 ("mm/hugetlb: make detecting shared pte more reliable") >>> modifies copy_hugetlb_page_range() such that huge_ptep_get(dst_pte) and the >>> local variable dst_entry is not used explicitly in this function. >>> >>> Remove this unused local variable dst_entry in copy_hugetlb_page_range(). >>> No functional change. >>> >>> Signed-off-by: Lukas Bulwahn >> >> LGTM. Thanks for your patch. >> >> Reviewed-by: Miaohe Lin >> >> BTW: I will send a v2 of that series soon. So the above commit id might change. >> > > Feel free to just squash this code improvement into your next v2 patch. Will do it. Thanks for your report and cleanup. Thanks, Miaohe Lin > > Lukas > . >