From: David Rientjes <rientjes@google.com>
To: Alex Shi <alex.shi@linux.alibaba.com>
Cc: David Hildenbrand <david@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>,
Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Song Liu <songliubraving@fb.com>,
Matthew Wilcox <willy@infradead.org>,
Minchan Kim <minchan@kernel.org>,
Chris Kennelly <ckennelly@google.com>,
linux-mm@kvack.org, linux-api@vger.kernel.org
Subject: Re: [RFC] Hugepage collapse in process context
Date: Mon, 1 Mar 2021 12:56:10 -0800 (PST) [thread overview]
Message-ID: <544df052-f9f3-f068-f69e-343cc69d994b@google.com> (raw)
In-Reply-To: <25d9347b-9359-efab-e1e3-f98bd0012af9@linux.alibaba.com>
On Wed, 24 Feb 2021, Alex Shi wrote:
> > Agreed, and happy to see that there's a general consensus for the
> > direction. Benefit of a new madvise mode is that it can be used for
> > madvise() as well if you are interested in only a single range of your own
> > memory and then it doesn't need to reconcile with any of the already
> > overloaded semantics of MADV_HUGEPAGE.
>
> It's a good idea to let process deal with its own THP policy.
> but current applications will miss the benefit w/o changes, and change is
> expensive for end users. So except this work, may a per memcg collapse benefit
> apps and free for them, we often deploy apps in cgroups on server now.
>
Hi Alex,
I'm not sure that I understand: this MADV_COLLAPSE would be possible for
process_madvise() as well and by passing a vectored set of ranges so a
process can do this on behalf of other processes (it's the only way that
we could theoretically move khugepaged to userspace, although that's not
an explicit end goal).
How would you see this working with memcg involved? I had thought this
was entirely orthogonal to any cgroup.
next prev parent reply other threads:[~2021-03-01 20:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 4:24 David Rientjes
2021-02-17 8:21 ` Michal Hocko
2021-02-18 13:43 ` Vlastimil Babka
2021-02-18 13:52 ` David Hildenbrand
2021-02-18 22:34 ` David Rientjes
2021-02-19 16:16 ` Zi Yan
2021-02-24 9:44 ` Alex Shi
2021-03-01 20:56 ` David Rientjes [this message]
2021-03-04 10:52 ` Alex Shi
2021-02-17 15:49 ` Zi Yan
2021-02-18 8:11 ` Song Liu
2021-02-18 8:39 ` Michal Hocko
2021-02-18 9:53 ` Song Liu
2021-02-18 10:01 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544df052-f9f3-f068-f69e-343cc69d994b@google.com \
--to=rientjes@google.com \
--cc=aarcange@redhat.com \
--cc=alex.shi@linux.alibaba.com \
--cc=ckennelly@google.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=songliubraving@fb.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox