From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1507FC02185 for ; Tue, 21 Jan 2025 07:46:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D6966B007B; Tue, 21 Jan 2025 02:46:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 686376B0082; Tue, 21 Jan 2025 02:46:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 500C96B0083; Tue, 21 Jan 2025 02:46:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2C3FB6B007B for ; Tue, 21 Jan 2025 02:46:14 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9AB731407FB for ; Tue, 21 Jan 2025 07:46:13 +0000 (UTC) X-FDA: 83030675826.25.F229383 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 16EE71C000B for ; Tue, 21 Jan 2025 07:46:10 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LHD8IrZH; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737445571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yf3Yi58DQb9qNm+rQFMRrAIPu7GSswztWbh56zFGwbw=; b=VqobwLIlUiFCqd0ewe03rVBO1pHz+9qHlrFq64rBpV/B5No0tLJnqiHWd4C53gnQTHljoA j32rvglSGSy3A+7JLjTNcksjx4TySCtAvBHxEfEGYCsE9I1YGN8bOfa7FMokxZ9mxNfRCu DaHfxQvOZqOD5sIlOoQFrk4SrFpjQdE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LHD8IrZH; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737445571; a=rsa-sha256; cv=none; b=e0FtTMqP3kTQgxYMzt5mb98CSCYc3ZeOfs+iFQUZ2CbU2LLpVxPFt0pHKFWZu2rEyNvZME E1C4iPb+/387ljg3xAYM26ezckO/Pe5zAEVqFPtDKNWmKtU1+QzCjeFFut+vruZi9rvtoR MWZWdWkVubmRf139FceMdxf6eFJ/sos= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737445570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Yf3Yi58DQb9qNm+rQFMRrAIPu7GSswztWbh56zFGwbw=; b=LHD8IrZHSzZIqPu1URLn0h75bi+1eq8//QWielS7R2wrW0lyakZmzN25UV6bgqdCk/ND1m P/mWeukrVpPJRpCs4J36JdKkBsHjU1coWVs4inJPBUk1tzjxcFA7bk49yLch8bxBkOfwgO aSkOXH1vU9i6WIoewf8Hr/iipMo2k18= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-aM6K6S6CMsatbae9FBx3tw-1; Tue, 21 Jan 2025 02:46:08 -0500 X-MC-Unique: aM6K6S6CMsatbae9FBx3tw-1 X-Mimecast-MFC-AGG-ID: aM6K6S6CMsatbae9FBx3tw Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4359206e1e4so41199035e9.2 for ; Mon, 20 Jan 2025 23:46:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737445567; x=1738050367; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Yf3Yi58DQb9qNm+rQFMRrAIPu7GSswztWbh56zFGwbw=; b=lkHaGFg1Tbmi868JNk8cgXLqzuQCjHm68bt6IyGfJf9QtgtgnxHJtIWPINLDiAktrx ZD1BwXBDYRnDya6tzbE3PdIDjyus2SBllC85TEGRLL+7QaKUHW9v71EXYnMHcvUP7lV/ ciV1d+qBTWm2PVq8prgOnyffqZAJeD/Q0CgSEQ3uDrVdontsOX7ZMobmGCoU7U8QwhvN dKGtKZhmAwLC8UUzjf226lhERD7Q2C5BFnMYTy078ZacO6J2vGHlbSWb3jjRFphJ8blB 4tHoCbNQhpG/QITYfYuRVGHctA/h+o+AVBhjS3uzgycbYQrTD10aF9hzP9v05ZFZIMuG xEcA== X-Forwarded-Encrypted: i=1; AJvYcCUjTgTrz3fxoxDdxwFNkf7P58d6Rovnz6/tjBZ413+qYeoyk42vb5gUHufCaXwoPua9NltQ/suxJw==@kvack.org X-Gm-Message-State: AOJu0YzyMo4aVMY9946Fr2Vd57OKxxS4GEcoijEAlAQHc4KPN8Y7ac6i LrecANzaKHVzkDj4EwXbJ507n+CHOn4DM3D7RU6H/ddHooUZkVgI/DlMwJ9bzEbgvB3LUENvSfH y66SrAuZ/BrTCh8R9LdtQaabntRLo6dFQfmx4w7QracVA7po7 X-Gm-Gg: ASbGnctMgffnlWRCzhkyZrnPsYdy+MPqJVfAzUQlVvKb3BGtW8FLj0g95g7QDEdTIo3 kZ0xTpz3L8E2k7CFfFRrtbczeyA1iAbjC2mbREjCHcC4LKXOgPbrEyfkd7IAewifANLK38GO20v w59kaH52OXacNFI0LMFiISTItnzX+6RYs+6NWySo8t0geb6aq5WKTl3evZY1qFD4E5A/XJEwpAu rJK7hCdcF4HUwpu70HQSN6wCFRqZs4gStCuFFVUtTyOzYI5EtHP+7y7tddPDDlvswsIna/+i08h t+2YQVK/yA9hKmRdlriAwYJLlDXjLTxmsgMhfyiB2ybVhE6NYnL+xDBRjmTmHz4j8J3hA91+zSC PFre+bWLySVaBHV21RcJrSQ== X-Received: by 2002:a05:600c:4e06:b0:434:fddf:5c0c with SMTP id 5b1f17b1804b1-438913c60e1mr148812985e9.4.1737445566829; Mon, 20 Jan 2025 23:46:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGyFH1h09pH1NiPwE1Wsrq6pqR8JPgmQvMS7dudaGRFQGkAGW4K49yhLRa/JeQy52wtjU0MWw== X-Received: by 2002:a05:600c:4e06:b0:434:fddf:5c0c with SMTP id 5b1f17b1804b1-438913c60e1mr148812775e9.4.1737445566471; Mon, 20 Jan 2025 23:46:06 -0800 (PST) Received: from ?IPV6:2003:cb:c709:6200:16ba:af70:999d:6a1a? (p200300cbc709620016baaf70999d6a1a.dip0.t-ipconnect.de. [2003:cb:c709:6200:16ba:af70:999d:6a1a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c0f03984sm174495205e9.0.2025.01.20.23.46.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 23:46:05 -0800 (PST) Message-ID: <543a134e-26ef-46c8-9f4e-c37e24dd7a25@redhat.com> Date: Tue, 21 Jan 2025 08:46:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 02/12] x86/mm: remove pv_ops.mmu.tlb_remove_table call To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com References: <20250120024104.1924753-1-riel@surriel.com> <20250120024104.1924753-3-riel@surriel.com> <8de49f2c161085fdc63d8cc883cdebd3451df47f.camel@surriel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8de49f2c161085fdc63d8cc883cdebd3451df47f.camel@surriel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qJG-MmsK6PkY2MmVJLl4f9_cfAsHpmhzBeIwjrdWZp8_1737445567 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 16EE71C000B X-Stat-Signature: 7bphho7h5yub7y3ccx9zwomcd636os19 X-Rspam-User: X-HE-Tag: 1737445570-169898 X-HE-Meta: U2FsdGVkX1+SYLYMhpExnmxDWtWKSmfwz4WlBgqE1CpLUhXmCRqrgqhQZBK+wVtaJjZ8uEet3/7dIzrFxVMAeDxJB0/f1WoEOBB8M2IJ5efcE9vM8HKcgAEE08gC1eV+PRUEwjYDQFKglqDmH3u+V5AObRGEhQS6W0Ed4EYgQleMnL1M3sbz0XCtijiN40EpHaF6q9T+BkFw4HbOe35krlRX/NVZnx7p0KNGlPS6ZMubggXgnULI02s3dVGFKPw1YY7Ksn5YBwix/DPJxz1n8DSqEsSX1CzP5WdPc2XwKgwxulu5UsACXxqQnThpcx2BIBMDWSHhQ+lYNJD/Q6XFTsvvaof2HMnsUBADP7hAST1USQUjj6yMkkaYYJTGg9nlLRuM2lOUJSb0c5Ure2U09S5VdRanK5g29+rWQxAGMXGO9NM39e1W665ykSr/gDPHip1yL4/Lga2ru4HXXEaWdKLGduIBtVrygD4OCbcdSrJ65WpsYDd79xMPoMUZyaYbon5WYg3YhIwnRHi7+ACDezSYzZNTWW8b9WvJP+JKFvn4uNFyE3alQnhFtIVhG5LICR5NI84wWp3ZVgZTOKawQYwiNVWNHp/Q2xzjDU6x3ts43MXjdtOMsQ3aXPbcv+NB1kfRvCVmdNkkOkf55VF02UnRfFn2fEHTf+N4NhnUvbC85x5sfdRYZl5h9ZxDTrICb/Rrpf6XsIJ/efZjju2n2UoXHk/G9WlzMl+Ff854toHinMOPvqncFehoJ80/hvDee2o/0O9704kUILljmAXg7sFxp/ley7cu9yA8oIQ07M4W3nM/4jwDCUoFhChvD+TSKkoravYm6v/uqPyQ2fleNvypaSKZ1hGau+di/l8kSxqLucd/romONlbdWZ+BYJnSatxMR6IWspr7j9GtbDnxozAUO9oks87ZJ/kWtVx8+fUiKApfyi6X5o4X01BC7OXcgqG6z8nDuET8qbBczkS hrON/4F0 TPi5H29R/CAwL3tjAuUmuBQyz/6P54NOllV/RZRQNovk9LG5fwGLThm62pOkMSHhuYMV+Gf7ogrM9lLRravPGxaRgUExcSz/eemfqQzQ7rH81Lv8IVrp17hwqriKPfx1YozcFcX4Z/e2nr6RsxLr1xs3n4sjU6K+yMoSp5FXQlY7v0zKbNskOLgs1+95X8O/T1V9ZZFqu+xjt4NJTQ1KLik01EomqcuCK4Ldl2l/h1e0JPctnNJyouwjIp82i8d3LgiNnYMGUBWU/XxQgv+oAyCi5/0RDD3BO4/B1KbTENQuTWG6RKN8ECHwRoHZj1KxQKhHYh13Nj3JLT9XS3XP0UnCdU2lV+q89OPHSzTC0dmbw249Qbvznab8e6scxPyhPvya8H2O26kmyxHO1nb3cmFUUY/N7Mdt2iztvb+SYEdnZcc9OqfWnibuZs2CzkUvF3RuDG0KyCjIElmmRnW8z37sZKUaHu0W5Vy/GbdDvowcXHtlJJrMkazh72vmwRFVePLPAcuSFmeyFK5Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.01.25 02:03, Rik van Riel wrote: > On Mon, 2025-01-20 at 20:47 +0100, David Hildenbrand wrote: >> On 20.01.25 03:40, Rik van Riel wrote: >>> Every pv_ops.mmu.tlb_remove_table call ends up calling >>> tlb_remove_table. >>> >> >> Indeed, but the !CONFIG_PARAVIRT variant paravirt_tlb_remove_table() >> however calls tlb_remove_page(). > > Patch 1/12 from this series removes that. > > After patch 1/12, we always call tlb_remove_table everywhere. This patch contains the hunk: -#ifndef CONFIG_PARAVIRT -static inline -void paravirt_tlb_remove_table(struct mmu_gather *tlb, void *table) -{ - tlb_remove_page(tlb, table); -} -#endif - That is the source of my confusion. -- Cheers, David / dhildenb