From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AC36C433EF for ; Wed, 27 Apr 2022 10:48:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E1AC6B0071; Wed, 27 Apr 2022 06:48:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 492C46B0072; Wed, 27 Apr 2022 06:48:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3360D6B0073; Wed, 27 Apr 2022 06:48:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 24B686B0071 for ; Wed, 27 Apr 2022 06:48:22 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F35F925EFB for ; Wed, 27 Apr 2022 10:48:21 +0000 (UTC) X-FDA: 79402334844.10.EB5FF42 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 5BE62A004E for ; Wed, 27 Apr 2022 10:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651056500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZaWDcPzanxqO+4p6Cp0c6BIcDLXXugLTPyjUIyycszU=; b=LwnKesIY6CUOeu+OXbkGbdISyZwoNVeoR+jCZi+pj1airbwGEyNSOxOUVoKHs69yanitSr Tp10CCYpP3CRATG2MwxnTyWAJ7GK9Vf4VHVD9w0res3j/4YF05NXHb2zDLkC3PlkYjYb1s 7iPmRBXe9LQYhSO+3ObdTlWzBINlTnw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-15-_7vkLcY3NZer0jAjLdz8jA-1; Wed, 27 Apr 2022 06:48:19 -0400 X-MC-Unique: _7vkLcY3NZer0jAjLdz8jA-1 Received: by mail-wr1-f69.google.com with SMTP id w4-20020adfbac4000000b0020acba4b779so589448wrg.22 for ; Wed, 27 Apr 2022 03:48:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=ZaWDcPzanxqO+4p6Cp0c6BIcDLXXugLTPyjUIyycszU=; b=6qYybDC4wbZpa16yfdPSqZQISOeozxqZ7wlF+tjfMwbmJRRGcTIlEcrq3u83DxBzdv drHuSN0V60PI/9JWUYMpp20oUmJbmOFmTp0cYCtov/XVMvsGDhAiy2PwDpLJD2ILLuTF ezh/1ncC+N+n8CYM3CLt+Us2d4b25fGMnrqCkjisqbFRDToI5CSpwb8icV2XhxkxpIch DGmTlQSKA4JxD2HQEsqz/8Ncd3ozUSQ0O8rJvAS4qwC3SLIMJwAeoV9oi4NYIU8F/n4x rsT0CfsYl8WmTTaYTQQF57ANsnMgApySYZNXRkNC0t/QXVcNDW09kbquWLFarfbhSECQ Uj1A== X-Gm-Message-State: AOAM533n9NXiGWVYoMkHsbVfFipDDGJ/5/zyJAjyxZuvDXVUaO1dvlum t9xX/jKHDNEvTgWpimCuAFNLGM6E40v3eC6irZb18EWIf51BeD1MwKiI5nR8zVTRZk/kTJIQtyf zB+lHSibqu3E= X-Received: by 2002:a05:600c:512a:b0:393:f143:efd5 with SMTP id o42-20020a05600c512a00b00393f143efd5mr8523470wms.109.1651056498534; Wed, 27 Apr 2022 03:48:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKaPyZzoxOPSDrT/Z7/O3FY3jGo+DaIfVsgKbkLBQT+Xz115qXPmI/iyhE/pLJuVgn9GUfYA== X-Received: by 2002:a05:600c:512a:b0:393:f143:efd5 with SMTP id o42-20020a05600c512a00b00393f143efd5mr8523442wms.109.1651056498212; Wed, 27 Apr 2022 03:48:18 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:f000:f1c:858e:6a10:ead1? (p200300cbc705f0000f1c858e6a10ead1.dip0.t-ipconnect.de. [2003:cb:c705:f000:f1c:858e:6a10:ead1]) by smtp.gmail.com with ESMTPSA id q15-20020adfaa4f000000b0020ac7bd4affsm16622191wrd.0.2022.04.27.03.48.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 03:48:17 -0700 (PDT) Message-ID: <54399815-10fe-9d43-7ada-7ddb55e798cb@redhat.com> Date: Wed, 27 Apr 2022 12:48:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 To: Naoya Horiguchi , linux-mm@kvack.org Cc: Andrew Morton , Miaohe Lin , Mike Kravetz , Yang Shi , Oscar Salvador , Muchun Song , Naoya Horiguchi , linux-kernel@vger.kernel.org References: <20220427042841.678351-1-naoya.horiguchi@linux.dev> From: David Hildenbrand Organization: Red Hat Subject: Re: [RFC PATCH v1 0/4] mm, hwpoison: improve handling workload related to hugetlb and memory_hotplug In-Reply-To: <20220427042841.678351-1-naoya.horiguchi@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 1hzu5uxw73nsx3u9aic147nscf5s7yi8 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5BE62A004E Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LwnKesIY; spf=none (imf15.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-HE-Tag: 1651056496-755663 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.04.22 06:28, Naoya Horiguchi wrote: > Hi, > > This patchset addresses some issues on the workload related to hwpoison, > hugetlb, and memory_hotplug. The problem in memory hotremove reported by > Miaohe Lin [1] is mentioned in 2/4. This patch depends on "storing raw > error info" functionality provided by 1/4. This patch also provide delayed > dissolve function too. > > Patch 3/4 is to adjust unpoison to new semantics of HPageMigratable for > hwpoisoned hugepage. And 4/4 is the fix for the inconsistent counter issue. > > [1] https://lore.kernel.org/linux-mm/20220421135129.19767-1-linmiaohe@huawei.com/ > > Please let me know if you have any suggestions and comments. > Hi, I raised some time ago already that I don't quite see the value of allowing memory offlining with poisened pages. 1) It overcomplicates the offlining code and seems to be partially broken 2) It happens rarely (ever?), so do we even care? 3) Once the memory is offline, we can re-online it and lost HWPoison. The memory can be happily used. 3) can happen easily if our DIMM consists of multiple memory blocks and offlining of some memory block fails -> we'll re-online all already offlined ones. We'll happily reuse previously HWPoisoned pages, which feels more dangerous to me then just leaving the DIMM around (and eventually hwpoisoning all pages on it such that it won't get used anymore?). So maybe we should just fail offlining once we stumble over a hwpoisoned page? Yes, we would disallow removing a semi-broken DIMM from the system that was onlined MOVABLE. I wonder if we really need that and how often it happens in real life. Most systems I am aware of don't allow for replacing individual DIMMs, but only complete NUMA nodes. Hm. -- Thanks, David / dhildenb