From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90419D41C0B for ; Wed, 13 Nov 2024 06:52:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 221486B0093; Wed, 13 Nov 2024 01:52:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D1656B00B5; Wed, 13 Nov 2024 01:52:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 049D46B00CB; Wed, 13 Nov 2024 01:52:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D8CC76B00C9 for ; Wed, 13 Nov 2024 01:52:40 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 92B561A0819 for ; Wed, 13 Nov 2024 06:52:40 +0000 (UTC) X-FDA: 82780151874.27.C69DE1D Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by imf09.hostedemail.com (Postfix) with ESMTP id 22DE4140006 for ; Wed, 13 Nov 2024 06:52:08 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qsVi7EC4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of hughd@google.com designates 209.85.160.46 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731480582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fGhFZqKZR/ZhRGabJrEH+0qwfjhlpjiKCYeavpG2VVE=; b=SnfLku2+UfevI3Ts3xwkht54ULykMZP4drBrzZbAe7fJEeqtZGYT3bGL33ZXKFS1RRKjfl DaL4GGBl3pZbJeMNih+8RX9UzfKwzUpa+gEjHnlIUlfpiurKDbhVzsyzAab/+RZDobz2ZA YHMs+Ws0+1p4TDGx+FQAp2R1S9YOckU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qsVi7EC4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of hughd@google.com designates 209.85.160.46 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731480582; a=rsa-sha256; cv=none; b=t8WEHvp0UZde3wQdCjY+N0NJomrytwyKJTcGeDK3B5UcbtjJaDFv53jwt1Z9PlaQzCTqMp /Dz7Tjn1fGVngKV0juwLuclnwl/1gSaGOG+loiUeQmAeNK1ANqLtToUzbf1j6kUdBQAzOi IBe5yoGXV9qx2l5Xs4NMqeGaqiFink8= Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-288c7567f5dso2894112fac.1 for ; Tue, 12 Nov 2024 22:52:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731480757; x=1732085557; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=fGhFZqKZR/ZhRGabJrEH+0qwfjhlpjiKCYeavpG2VVE=; b=qsVi7EC4dJT+w1fHUzxaM9rxofMQIAXAYlmDjoP0SZBnIK60qiut8baRuVAxzU9JL9 kLWSo8RiuwU+2VVoXhFfbSWxh4A84S1dTr4C374tMnhaa+NQYa0W1XBi4b+e2rpZ2SGc MKqfP6wkIuoTMH6vyk3FWyMNWJ3VrUdmdA6nU4yQdnc7PCWO8amFSTUqmM4QDsyPUni1 h0zmj+IyS55CmkBq4QB+ESPCFkhvimcrI302lHJmQ9cTWhWTOgg+9goNkjU88pLSJV6r koq5OzKbltL93cmcx5hroSdmFkIXtklB2e6+DC3GzM1NO9HLzt8U9RJzqmo3fvjpl+bd 299A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731480757; x=1732085557; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fGhFZqKZR/ZhRGabJrEH+0qwfjhlpjiKCYeavpG2VVE=; b=NpFkVBw3GmwhdzyvAQg7Pm++HzOLkHo5vsWMKQ9OO7uMKtQvYKA2FRL2/ayKwFu1Wp eenSYZdz2KQlWEEx2Q3qf/bh1uPm9jU2GyArKl5uOrs8mEUH6RAThQaE453BWrvriXft TOUEozg0D9RYL4r/2IGQMTieeM/EEj03eFjat2qio4wMs2ZHAw23zn62Q0mmhAOcs2CZ xTes8MeILvepnDKyzmMJ666pV+e+HeEdSVz2UREZIXurjn3nK/7xgb4wF6kEMgL+jaLf yYBdZpwUnQwFdz61T+UpMD2vadziLY0qm0sCIqipg3zd5pSDFT6jVlGAKfWPbzokjOCL j5Zw== X-Forwarded-Encrypted: i=1; AJvYcCUimwAsessEC8VmBlg4CDusBoRubSZ/k9VRv/8SZhksoRWGM+xOJgFlp/jFYkMNFO0ScOCkkXKgew==@kvack.org X-Gm-Message-State: AOJu0Yzsux26gkS/BqefXnTgqm+e7nvjLzalgCMwpyt1ZSoYqVsLPxP0 r0PgJHkhXZmns9Gk7lznV06YlDQLhT9WSt231SuSe9Q/BWKLOrIaLzILtm86hA== X-Google-Smtp-Source: AGHT+IHdFbj5No4qa+yCdLxViIJNf9IDXVZV0S8fnMlAUmokHxO5o/bcmslNN/vBlSeSBSYRaX38aQ== X-Received: by 2002:a05:6870:e99f:b0:277:f301:40d5 with SMTP id 586e51a60fabf-295602f1396mr16219291fac.31.1731480757477; Tue, 12 Nov 2024 22:52:37 -0800 (PST) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-71a60079dc4sm344747a34.56.2024.11.12.22.52.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 22:52:36 -0800 (PST) Date: Tue, 12 Nov 2024 22:52:24 -0800 (PST) From: Hugh Dickins To: Suren Baghdasaryan cc: Hugh Dickins , akpm@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 4/5] mm: make vma cache SLAB_TYPESAFE_BY_RCU In-Reply-To: Message-ID: <54394536-da24-d01d-e4a7-2ece22b1ddab@google.com> References: <20241112194635.444146-1-surenb@google.com> <20241112194635.444146-5-surenb@google.com> <6d0c5c2d-2963-489a-2376-8edaeb064de3@google.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463770367-550729047-1731480756=:2748" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 22DE4140006 X-Stat-Signature: 84ittkxtwtkexpn1sq7s4tj3xzcygt47 X-Rspam-User: X-HE-Tag: 1731480728-472526 X-HE-Meta: U2FsdGVkX1/baroMRHXiZBtJSA5osuniYN3Q7h1+pzHMYvXaa1WRjQK2WRstav0e3XYBiE/7yP0uRUAF6zl8WgXf24Fk5Jw8JCBqE88+HE5HJsXVPn39YvE8W7HYRKMvp+Q5e33RJt8Y6EGm0hjD4MsgmiPxEEm0H5I6UCP6z3v0beZDRqWcPAyIZIwObjXtcUOBrlNjzAla+ciC26wcdB1d1b24CBlOTGMpez13z5sl9M7MO2wb0uxDQX7qStV6ZjpGKnBPy33fp8R9p5OfkUVQv+tfB8ZH7L4EFO7Xbj9QswuP/nkRh5T38cbJdmo0/9S8lkcrirduj221+qmJZDCW5z0zp+VMwwYrdK+4kURKsvKFsPz39Wq07JMN2rl5a5zE5Ik7BK3jeSGs/BER0KR/9G4zB/ObGy3th/PfOdZIPFwowrAsWtuGUt/sIdy9rTU+Leb3nVxVLn3/rV39uXPqUwCHCf7ef5ysFbKn4SuFmtWWlMHdB3uDUcCxf6SDPHU5Hzy/J3Hl2an2uKWtb9kdV6JS9bEwbQFSMHZRQo8CQiD4z4X/vVINoK8T7JszaKFAySpTL0D3LgZWUnH66Kdgt5n+lE49XQxjhCBxiFehvMppwMxOhHWms+U/tQnkV/rsjDeSUXiUrpeUR39Sg7gDzQQ8hGxkkPHfHn67uAmparzm4bY/yleXYAdQUYYKzI29XBfhjKli+YU/ii+PSIaXpLU3jrPaXMQm5b4rIpsSO7JkQxdnOgRP2cBYUh80pbjJMpCfd4xaDe/nUqszM3POmCMDhNGcIjoLfVcGboVQ+XGsjVib4G+wmXJORdahCIjooQ+0PZpEfTPUK6QJZrS/hjfjpTyF0BuTGRIw+3gWGiZQUSnhHon+xloz2NbmssCqZGLMKU+CK/Nv0jIM8t7rzmtKokTWTMJh9V/EZ9+NbazEcsDUmEK6dnlsrvp2nVz4ed7KompZP6ZAO5R U39Xw1Ie 5T0zJy1Wm7QsQP6TmiKPLwADFspfbo4ZWc7uFcfsZILniwnkVVM/D3c6bYfansfTFFnjh8l7o1NXf6e0L3aCA3xhfoTNwVxqKWIjFl6bqkeu27HWAAfhBb4n9ShJNrCy7SEZG1wcYTxkp4TwfFUgbPQG7m01CG5M0pX79Nr8MXf+4XMtVr9OmIAhTPpyQFAgCCBye4gr49bKqmL45CNBoTJO5n94YFR46yl76FxFpKanppBtpwe0HOtqYqJAg9f85BxnqYLlz8KJ2uqz3VQJz/gtL68XEarKWJEFI72bdbO+wXhCSkPxz/D9J71XAAf/3Dpi3kILk8dMnYOdMp2/YaT6IABheZsn7EDnepW7NNdjo/SDSnwVqpTapjZiIR+LRf2zHYjAniYawZdIpwHXRRWonfwN/0znn1Uhe4oRhoDDagkDOCYDg8mgNo2mYbzgWoNsk/MrRaAe+e91NqXL4ushQGu2acbdcFKLmG5BVSBiYJGexWaGMSALXHgwSjpXUzwmF8SYoJulw3LzJq5T79b/s7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463770367-550729047-1731480756=:2748 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Tue, 12 Nov 2024, Suren Baghdasaryan wrote: > On Tue, Nov 12, 2024 at 9:08=E2=80=AFPM Hugh Dickins w= rote: > > On Tue, 12 Nov 2024, Suren Baghdasaryan wrote: > > > > > > Thinking about this some more, I don't think this works. I'm relying > > > on vma_start_read() to stabilize the vma, however the lock I'm taking > > > is part of the vma which can be reused from under us. So, the lock I'= m > > > taking might be reinitialized after I take the lock... > > > I need to figure out a way to stabilize the vma in some other manner > > > before taking this lock. > > > > (I'm not paying attention and following the patches, I just happened > > to notice this remark: forgive me if I'm out of context and have > > misunderstood, but hope this might help:) > > > > But this is exactly the problem SLAB_TYPESAFE_BY_RCU was invented for. > > You just have to be careful that the locks are initialized only when th= e > > slab is first created (allocated from buddy), not reinitialized wheneve= r > > a new object is allocated from that slab. >=20 > Hi Hugh! > I'm looking into SLAB_TYPESAFE_BY_RCU implementation and trying to > figure out if initializing the lock in the ctor() of the cache as > mentioned in the comment here: > https://elixir.bootlin.com/linux/v6.12-rc7/source/include/linux/slab.h#L1= 27 > would help my case. I assume that's what you are hinting here? Yes, if I'm "hinting", it's because offhand I forget the right names: "ctor", yes, that sounds right. Just grep around for examples of how it is used: there must be plenty now. but anon_vma is what it was first used for. But given the title of this patch, I'm surprised it's new to you. Hugh ---1463770367-550729047-1731480756=:2748--