From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E17DC3ABBE for ; Thu, 8 May 2025 15:06:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FCDE6B0089; Thu, 8 May 2025 11:06:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78A306B008A; Thu, 8 May 2025 11:06:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DF476B008C; Thu, 8 May 2025 11:06:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3AE0B6B0089 for ; Thu, 8 May 2025 11:06:54 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EDF4FC07DA for ; Thu, 8 May 2025 15:06:54 +0000 (UTC) X-FDA: 83420067948.08.1DBB97B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 734A4A0008 for ; Thu, 8 May 2025 15:06:52 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jG7Xom5n; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746716812; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WojHMjyPBrrPO+Jk8CPiqCE+pjkpTeWIKKEKQdKl8Bk=; b=DWAyTU6Tcq2hX9yYKHrof4H+AVGaDTqv4k4mzJzLb8n31hnZBbWYwLA+VzFm4ZKMke863n Baz3WE7lPtH+T/+1fDWH+c+RaLBf7uro3XsNSiAlQTO5BjsN1Dr7QHPviAabwZmg1hl8zi m1EV0LHD13uEWnrYSgeBhlWo//oAYOM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746716812; a=rsa-sha256; cv=none; b=01UjnHaSinmcnkYsjX1JIeeiYn7eqm7Evbyrs/8xWqikZ1Kvy94VA+QHWzhM3wzji4amg9 UklU5nYkZ4j/NdBpIM2HRDUfZqJT8TNsLsDNWuxGeP7U2NZ93U+2LKbG3BIiKdhAqU35pt 9sq90iDtVTTrQHIrdvtyIIILWHNVp0k= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jG7Xom5n; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746716811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WojHMjyPBrrPO+Jk8CPiqCE+pjkpTeWIKKEKQdKl8Bk=; b=jG7Xom5nQHvaL5ryO5nXUeK/1J2qj27faBOLrjPYDgNot8V+NemQWaFXDV5qllJi9nD27o NQSre0unW9aT8IK9uNsbkHDsqPQZ+o+HyKAG0Ukm6QLdvMIZ/Df6CgOYhVS86rO329qlNZ GBCqAkD4Fbv7eXBb+fxHwXHPtzQhmqg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-VqGU2fUsOF-ZpKEoLxeICg-1; Thu, 08 May 2025 11:06:50 -0400 X-MC-Unique: VqGU2fUsOF-ZpKEoLxeICg-1 X-Mimecast-MFC-AGG-ID: VqGU2fUsOF-ZpKEoLxeICg_1746716810 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-440667e7f92so6465245e9.3 for ; Thu, 08 May 2025 08:06:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746716809; x=1747321609; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=WojHMjyPBrrPO+Jk8CPiqCE+pjkpTeWIKKEKQdKl8Bk=; b=ewZvLy94PGlkcR1uYkMdauRYXrYngJZxuRCpJD9SbnluOmH4P0Lvg6aP4esHHbBc0C A30msJY5L4cGxr3BwqnFuSXUDiK+20IA1DXWtsjLUNwaB3URaqOd/Aa992k6Gix71dE+ GUKT8EAmqvrzd9KkmR1Pdq3MFQdD63OkUeLQRbIcuU7hC31m6OZGe3DJFXOsSWFIkzUT 6LBuMm3+kFKaXklCKbddjk3mOpCzLxyCgGkaMyhECR7RB0VzFGiX4FEH6bD8Ak/Ap4NF yp+ao9tLzuBrJaS9Q9nROqQkrKhtoTJHI469P6BAAB1CbGNh61s3uooqW1BvkBVVoUqZ lI5w== X-Forwarded-Encrypted: i=1; AJvYcCWYEiYCR8cggDyhXSiQX36K+fLes6OhsptAMatDo+IrZkUktl2ZJw+fVOuV2tsAPbx2kK98lideng==@kvack.org X-Gm-Message-State: AOJu0YyCgNQG0klUYbFa328txFAgqS1WjaWzeWQWInYGz4nCPEZ02RP+ GjcJpwrVPKI6VhQ10HO8e8ugQdX/nhKzC0ccmNUFF8cUIcbT6kRYSfKGSL59UQu7XVtUCOWB0S3 U8C1Rdbz1ialopm/tz/vAoJz5JTeCHYELiSxpapvWzULkRlFu X-Gm-Gg: ASbGncvCpzeyYV5q6r7sXRBF0B9GW6BhKMDRfP7geYY65x9Yri3Kc5qmyv8a8XvraDr TXo2+SrbP53XRFakAJJKlKpYEFnaUyZqhLg6ypWzA/qkExnn6G3zgNwQ5C5iDhBv5lZkZmoRiWQ fZoIWcQtXWBy95gjXiduO0/n+5wjsCvAwn9tXAiai15Ls3xrW88Nu05MEG7YCIEOGUeXP2N3M1b 6oPEVsMCczyfnNYFccf/q4f3tzMIKlXC2L0rmD5IKQ1f7kwcglb090rIqOPKcIMiUCrJBMTzMWI e3iw9arpYMfQuEkxYWuMqyBToYIYE6YposPagNXbX4CYKdbZvsmQUrGXxWqXwnfePsane1KPYyz IQll6Ti+H5wxQJPwnI4qOI6pJKxeE60LTsAOqXGk= X-Received: by 2002:a05:600c:190d:b0:441:b19c:96fe with SMTP id 5b1f17b1804b1-442d02eca3fmr38304725e9.10.1746716809269; Thu, 08 May 2025 08:06:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF143S986Zr+zy6TZomrZa18YRN14BhDxvHl61b2vWZ60lgG1PwAE+taz59cOILHyClnvuF2w== X-Received: by 2002:a05:600c:190d:b0:441:b19c:96fe with SMTP id 5b1f17b1804b1-442d02eca3fmr38303945e9.10.1746716808542; Thu, 08 May 2025 08:06:48 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3e:5900:27aa:5f4a:b65c:3d3c? (p200300d82f3e590027aa5f4ab65c3d3c.dip0.t-ipconnect.de. [2003:d8:2f3e:5900:27aa:5f4a:b65c:3d3c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442cd3285f9sm40935875e9.8.2025.05.08.08.06.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 May 2025 08:06:47 -0700 (PDT) Message-ID: <54385633-b320-4586-b5bc-dffbd2ce3b03@redhat.com> Date: Thu, 8 May 2025 17:06:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: madvise: make MADV_NOHUGEPAGE a no-op if !THP To: Ignacio.MorenoGonzalez@kuka.com, Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" Cc: yang@os.amperecomputing.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250508-madvise-nohugepage-noop-without-thp-v1-1-e7ceffb197f3@kuka.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250508-madvise-nohugepage-noop-without-thp-v1-1-e7ceffb197f3@kuka.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vww167SfjbiAIIOgQEiwqjFj6Vqt1WUhkEkewPCtyKE_1746716810 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: htpafh6t59bhjzmz6ry58jckpjhb6uuu X-Rspamd-Queue-Id: 734A4A0008 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1746716812-882328 X-HE-Meta: U2FsdGVkX1+Mvx5FH1UpNub0/BPpKmkSqDTbpelkdhr9jup21Ga9KbtV91+RXS46EXQMYkD40uEC6CLNXHmfjei/RoEMZphX4gSdS7Ixhe4u0/Y/8yLg9yY7YFH7Oh3wcUQKTRs/vMJB3CpGoy2c86ntwt9QnOqJNeofcZann6eCEgMf8mcDODx/SKqNrO5DPNXaM4v8RmAt9IHJMtBxgN2kMeCKOIxJVAesS+cZ1JMB5/cDD3myLx98UYJvKaNIYtu0FISPhV2gn4MMRYOG+4pJ+R07y2hGqwrfELgAVZ3YgI+stRWsH3Pn5IU/khqLTTXofSet4f0dgKuCAHXcHTwVd7+4NKqt/dHTFgo5fdbBA7ZSmXIk9lfetCypzDLKNhsGZ0A2wUFGIFuuUhSoN8j3XRWlUVGi+GzVv2jFMivqFIZnuJ28Radv6GzqNilZy1NxV2KbMRqnFOjgKpj51gCkmEeCo/s/BMlUNn+iyvs7k5kTHl4aHDEXU3LSO/7HXb8JRyNRpFqja6bmr3f3hOcC56CAMe+YKfg/DCkI+9an8duDpDFXgCqZf/o0MtafViab5HBAuqfrX9tpeDWMJC7Kb2jsoMgh1fo7Yi23GZTGs+CTgME456f4m0w1p0MFoe1OFak1mOoCbvK0cGJDpyOEACx4jaMoP7BH/gCJN8GW8hEpo9AIgzvWMgV0g18EQjV3ZOZ05QUeXZyU4w2upuXiP4POxzmpCn8HKe0kw9eATZhCmRKkS+qRuVQy5FLTD7vmc+mRWn6IlaJQOmiwGQmr4Wx+iwpTcHUMBefihY3IWbYQ6J8DVUD0KQMiflFpahuMBhrXRNLimr4AgykVC+hiIkPuPseal0dgtL5VDY7LwByMrl6QbS60bOcZ7csr7DMQzzJl4qBcRGBfLwO/AMwhdtnfb+awZUtgKZZmBZxM8YG/jYYYrLXo9TlhxJJFK7IP17VaodBx9QDb8JZ FSuOYB9b nJF2zx3awQl8/Wue1gDmSB6ALcHDYUXMg4o9OeR+q+9M6IMKg4V9c8VEFOZ8dNXFOQi1FI0YOii66Catmys67MkpS/EKlBTKqZAcpeRoRDG2U+4w5PZlfEgUQIcziqIJwQuxt/rrHUsWmXHiBnmu3HWjrQ0GkjF3g6/7aBZeEGNd/p7arBi9+AxonBoUOhrBw8uS/+HMEWF2ycFUwzrso/4d/qlvTALkXd7qK3JnwRDA6fyUpa/4LAuMx5BrSrbiE/qgeWo1NnFN6ERO2N8/aegSmNznTjbe3fa68N1xyLTpisOD/5NmoxaFnUf/342S8KzmTuBw/il9f3BFqMBDrdgOeBXZfgk6y8fMbu/g1pT2CH2OnFSk0HMTmH1JTJqX1LOqoJ1qpy3yiXShFvSZn1/23cKbvLHXSBvajPsYeZDQ2yilPS9/EKJilgL6GYxiQd9/idKWLupYTXM9Sm7KhC56QKjTGiA95wkv+MHI7OOyhDA3BIDOlYSrXvFuSmEusRdJOAUdcvEMZQMsQ5738Ss3tjWgCVu53ZRbpD6LfjF/YxMQ3eqYCYMA2KIZitbCbZhLuSg0t31plDLPOkgBuw7a19CdDRAP0HcV6eMjSRr5B4MR0H89/bmTUCsmHb1M+fSHyTjKWiOJK7vgEkkqnG2I8CA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.05.25 12:20, Ignacio Moreno Gonzalez via B4 Relay wrote: > From: Ignacio Moreno Gonzalez > > VM_NOHUGEPAGE is a no-op if CONFIG_TRANSPARENT_HUGEPAGE is disabled. So > it makes no sense to return an error when calling madvise() with > MADV_NOHUGEPAGE in that case. > > Suggested-by: Matthew Wilcox > Signed-off-by: Ignacio Moreno Gonzalez > --- > https://lore.kernel.org/linux-mm/20250502-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v1-1-113cc634cd51@kuka.com > > Here it is presented as a separate thread to avoid mixing stable and > non-stable patches. > > This change makes calling madvise(addr, size, MADV_NOHUGEPAGE) on !THP > kernels to return 0 instead of -EINVAL. > --- > include/linux/huge_mm.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index e893d546a49f464f7586db639fe216231f03651a..5fca742dc5ba784ffccea055b07247707d16cc67 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -509,6 +509,8 @@ bool unmap_huge_pmd_locked(struct vm_area_struct *vma, unsigned long addr, > > #else /* CONFIG_TRANSPARENT_HUGEPAGE */ > > +#include > + > static inline bool folio_test_pmd_mappable(struct folio *folio) > { > return false; > @@ -598,6 +600,9 @@ static inline bool unmap_huge_pmd_locked(struct vm_area_struct *vma, > static inline int hugepage_madvise(struct vm_area_struct *vma, > unsigned long *vm_flags, int advice) > { > + /* On a !THP kernel, MADV_NOHUGEPAGE is a no-op, but MADV_NOHUGEPAGE is not supported */ > + if (advice == MADV_NOHUGEPAGE) > + return 0; > return -EINVAL; > } Acked-by: David Hildenbrand -- Cheers, David / dhildenb