From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
Received: from mail-oi0-f49.google.com (mail-oi0-f49.google.com [209.85.218.49])
	by kanga.kvack.org (Postfix) with ESMTP id 02F8A6B0069
	for <linux-mm@kvack.org>; Thu,  9 Oct 2014 00:14:20 -0400 (EDT)
Received: by mail-oi0-f49.google.com with SMTP id a3so980142oib.36
        for <linux-mm@kvack.org>; Wed, 08 Oct 2014 21:14:20 -0700 (PDT)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com. [119.145.14.64])
        by mx.google.com with ESMTPS id js9si1140407oeb.32.2014.10.08.21.14.16
        for <linux-mm@kvack.org>
        (version=TLSv1 cipher=RC4-SHA bits=128/128);
        Wed, 08 Oct 2014 21:14:19 -0700 (PDT)
Message-ID: <54360ABF.9030302@huawei.com>
Date: Thu, 9 Oct 2014 12:10:39 +0800
From: Xishi Qiu <qiuxishi@huawei.com>
MIME-Version: 1.0
Subject: Re: [PATCH] driver/base/node: remove unnecessary kfree of node struct
 from unregister_one_node
References: <542E750B.4000508@jp.fujitsu.com>
In-Reply-To: <542E750B.4000508@jp.fujitsu.com>
Content-Type: text/plain; charset="ISO-2022-JP"
Content-Transfer-Encoding: 7bit
Sender: owner-linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>
To: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: gregkh@linuxfoundation.org, akpm@linux-foundation.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org

On 2014/10/3 18:06, Yasuaki Ishimatsu wrote:

> Commit 92d585ef067d ("numa: fix NULL pointer access and memory
> leak in unregister_one_node()") added kfree() of node struct in
> unregister_one_node(). But node struct is freed by node_device_release()
> which is called in  unregister_node(). So by adding the kfree(),

Hi,

Is this path?
unregister_node()
  device_unregister()
    device_del()
      bus_remove_device()
        device_release_driver()
          __device_release_driver()
            devres_release_all()
              release_nodes()
                dr->node.release(dev, dr->data);
                  then which function is be called?

Thanks,
Xishi Qiu

> node struct is freed two times.
> 
> While hot removing memory, the commit leads the following BUG_ON():
> 
>   kernel BUG at mm/slub.c:3346!
>   invalid opcode: 0000 [#1] SMP
>   [...]
>   Call Trace:
>    [...] unregister_one_node
>    [...] try_offline_node
>    [...] remove_memory
>    [...] acpi_memory_device_remove
>    [...] acpi_bus_trim
>    [...] acpi_bus_trim
>    [...] acpi_device_hotplug
>    [...] acpi_hotplug_work_fn
>    [...] process_one_work
>    [...] worker_thread
>    [...] ? rescuer_thread
>    [...] kthread
>    [...] ? kthread_create_on_node
>    [...] ret_from_fork
>    [...] ? kthread_create_on_node
> 
> This patch removes unnecessary kfree() from unregister_one_node().
> 
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> Cc: Xishi Qiu <qiuxishi@huawei.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: stable@vger.kernel.org # v3.16+
> Fixes: 92d585ef067d "numa: fix NULL pointer access and memory leak in unregister_one_node()"
> ---
>  drivers/base/node.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index c6d3ae0..d51c49c 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -603,7 +603,6 @@ void unregister_one_node(int nid)
>  		return;
> 
>  	unregister_node(node_devices[nid]);
> -	kfree(node_devices[nid]);
>  	node_devices[nid] = NULL;
>  }
> 



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>