From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 313F9C369D5 for ; Mon, 28 Apr 2025 20:50:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEBA76B002E; Mon, 28 Apr 2025 16:50:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6A076B0030; Mon, 28 Apr 2025 16:50:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BB6B6B0031; Mon, 28 Apr 2025 16:50:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 142836B002E for ; Mon, 28 Apr 2025 16:50:42 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 74FC4141558 for ; Mon, 28 Apr 2025 20:50:43 +0000 (UTC) X-FDA: 83384646366.10.3A95A10 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id C8C024000F for ; Mon, 28 Apr 2025 20:50:40 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HHyQD1D5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745873441; a=rsa-sha256; cv=none; b=JEt1b1ZA9nzieceM5VWSkxub5xiOrBVG5MT7+wxKZe7/aLt5w4xWo3ntZeVWNsHG1POZ+U C3p41qhsRrR5M7yQFCFKpr0UAdP+lTV1i2tOJ/RcmJh418kUyrDueFyvIKmvc/tRBwuCLD Tu/dp8XivKa2lAekc37LT6/hpYH0mkE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HHyQD1D5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745873441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XbMvGOhD9vaJiD0OBv6udKVu/Ls/zjaBXiw2McAVVes=; b=OCp+ybY1fjc0mibol3g8GksXCxQNkotTM8NPpqwYUNnfsYOq4l9blWu7T/oSLNtEjgMkyU koGLBKYBCYinTH8gikYWHMuAP3DnL+EpDax+V5MSq6zsoKVzJjWLkWLMP6OTyIoVK9vK9k 3JIZbcRWhKVdOsbCK0nSHaYTB3En19Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745873440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XbMvGOhD9vaJiD0OBv6udKVu/Ls/zjaBXiw2McAVVes=; b=HHyQD1D5YcjkLUV0sqtXv4RbqIjFi39EmCuCnxW12VIRzXm1iXzSorWtCBQv/crdX7WRqL LOGC+NIV32pf4jV3+LxTJLI44x8tFkSgaYToNgcAypeam9mFmaZ2x9982DLVvrG7pa0bn/ xO8VvS1dJ/YC7ghwyCscK/E7w83lEdw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-371-wTAB3Wf1OkSbn9uuTJ5AGg-1; Mon, 28 Apr 2025 16:50:38 -0400 X-MC-Unique: wTAB3Wf1OkSbn9uuTJ5AGg-1 X-Mimecast-MFC-AGG-ID: wTAB3Wf1OkSbn9uuTJ5AGg_1745873438 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43cf5196c25so27879355e9.0 for ; Mon, 28 Apr 2025 13:50:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745873437; x=1746478237; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XbMvGOhD9vaJiD0OBv6udKVu/Ls/zjaBXiw2McAVVes=; b=gAtNIiUtg3pz78HNnEh+9G3ka7SfNYp1glQYk8fiVKqSBcYVAM0dFbwtrSevjVrgXT lEWzC4Tv0tvg5iLQxldXLQFo1g30T9SEVHWSPCu9oJ/p2rWddkqyK9pvyDV0crEefg3I XJFbrytP1Ro1mBAXe6HxsNPG4JxRUiBJF/UVJlc41HtpB3GMDupmXAxHOqWfKjtXzgPz Tc07DVg95LbP289yPwCIq/qHGWe7xiXhaUmhWHKz4+w30BDOWtDG1IWE5Nu43CTu4YKm V+IPnR7lFNsirx2tFM+6/zhwhC7+akC6c1HfLzLVT4MKWjF9+3ptGuORHLbyhQNrqTJo uxAw== X-Forwarded-Encrypted: i=1; AJvYcCVrHBS2BYJijZt364nQ7jbg6z52jIt1J+pFPm/iVpJRUGF8LGKaU3/r2l5vbzJHSgnUaDDosGzpyg==@kvack.org X-Gm-Message-State: AOJu0YwAFWPOT3AWFFQnoYef7LQafM8DVKD6A/u2C963KU7USYzIBnMQ kA/uKSEI/YBY26ba2da8A0n/QRYh/myfAoICbi7i/+zsYNdzwcJIEgWMGzwbDgwlGVDmxCQlynr AvZ4jPuFA5Db29a6AUH4X5u+E8BbpJzCsYMWvSWWpcVVtcrbV X-Gm-Gg: ASbGncuLy2GwoBO/849WCUsHZTAO+lAKDza5T8xnATeB3I3D0iLOSttC/seocwN5ROM b1u0zsGXtiCXg2QVOM/MXnsZi+ZnoLouRzImcEJGWDOTzYRbNjwKreOhrvtAzMdhk4DU8F49RuK yTz4LhkuhgVTcNVrx9D2BmC/2gCfrlOg/TakpDHRxRcxH9IeAAoz+e+39NG8dCIv/C0ppKiacB0 mB+ecouE/7GxcSMVMxZqAVCYuJ4iyQC5kCQU74bnk1byRYMExw/AFd+oN8G0wMBkawAcWjT2Czj f0iiKtoATcaHl4YJLc3spyM4U+VcG0gnZKouRDSC+m5GvZb7ja/AGuzNYddyQvmMAtukmyEV2Bo K7sRL0DRRh3jI3RBmyyScqxSLdfWnC0KnkLCqbS4= X-Received: by 2002:a05:600c:548d:b0:43c:f70a:2af0 with SMTP id 5b1f17b1804b1-441ac85dea6mr8003945e9.16.1745873437658; Mon, 28 Apr 2025 13:50:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFZZSA4A2JK3uwnlhYhPt9NEmaCHGim2OUmzKTYO87MCB0WmeSSjAAxfFgoiLVeJaZPK6LCwg== X-Received: by 2002:a05:600c:548d:b0:43c:f70a:2af0 with SMTP id 5b1f17b1804b1-441ac85dea6mr8003715e9.16.1745873437361; Mon, 28 Apr 2025 13:50:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea? (p200300cbc72fea002f00e7e58875a0ea.dip0.t-ipconnect.de. [2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8cd7fsm12083934f8f.1.2025.04.28.13.50.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Apr 2025 13:50:36 -0700 (PDT) Message-ID: <542cf4a3-b1f3-4ca1-82b4-56514f9b86ca@redhat.com> Date: Mon, 28 Apr 2025 22:50:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] mm/hugetlb: Refactor unmap_hugepage_range() to take folio instead of page To: nifan.cxl@gmail.com, muchun.song@linux.dev, willy@infradead.org Cc: mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni , Sidhartha Kumar References: <20250428171608.21111-3-nifan.cxl@gmail.com> <20250428171608.21111-5-nifan.cxl@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250428171608.21111-5-nifan.cxl@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3QmhHULCJwjuseuwCUdxIRTZuwvufXIegCgJsw9bjys_1745873438 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C8C024000F X-Stat-Signature: sub1w349h5651bkqp891aw43uctrgdik X-HE-Tag: 1745873440-85429 X-HE-Meta: U2FsdGVkX1/4LZ2+hPHgCKwsejLJA9Z5WXefEMdRzh+gHirXoX56GjlalrKmFD9flr98ii2Bvrm/2fEPWo/wSMnc/G6IsPsSPBVKdXOX6pjU8EePHGMpgjKgEwXBRrHD6Y7E/7oo8BwTeITLU+6kaJNqfc+rX73b6KVy3i0k0PrpwYCqUsxSdPF1uscKtxTrTHGtVhrI8tkwSHUlPnqlxR6ujWCMkCNuLe7DVcmeOiem6SUy4PFk1ZrZEmOiNbmCIzML877/mwEnY0FoaexZHuukaE+vBiCOFtnsG27Oa7tMGVS9nznsa4pLVQnPRUQgFOdXkU+OZx0knHtAMreSQBLi8xRAVBmxnhXag51S60jsBTWdSiVwOuuAPXKhTUQtjrmV6jNxroM1w2Cbr2y1A5Ynd7Cej2PHg+2x7cUgJ+xpExWWL5N/C9f75XomLjuxjhxFFZAZWFbqTd/+izhLcEovRGklX+jsBjC1ANUwC7XQg9pIsrvfFjPd2odRszWBPW8lCXBciuwV8EqFZDocLoRQfO/tzzWLQPIepaaM8nNLjSnl2kR7eZNDLo8WpMC1MnRIXliTGaTpFfuQx/t+GrgQ8zRM5DjMy6O3G6aKIFinH619ovRzm9hUAnHMg2DlHTeKj8k8FrWDM4x7P8znkjHU1T7wdsA8vHE3RreyrWeDu/BaCqabmUsEgqxfVGGWeGzfZaONGl6JeehVMZxrZNEQX2iuhYwihN5GOYfRdk5g6oyqd6HHX+eSJMkui6ZEp/FgFp0kPftLg5ZPz/8aH7fCMwibp1e7zXQWrIemgI0NMnBdxw3LDkdiWNLWHrRgvXazPyAOhKj3f6QswxSZc6WgsZBGFFqZ2ezQSmGfpuem4Z1aOLl4nocLq87v8F2KN+LK94iFQQHSMuuJyjXVILLk+RS12Q2ujnGZvmsihxe4Pgv5JIkEmOOZWIt1IWKSVgxUJ9dLofrWdislAyW sy3HOANz iO8RP5dpbFGjFcjTNxNPgKFhmprNeTAUcXTn9JbsKspB7WvotC94nFYzVUDHnI1OK7pczAlK5Iz4D6/ohXTX/bUty0uG+p3F42XblVreL0DOUbDWJlXvfh4dgYWfZWW57MhgGwgvR9Xwp1M5predjl0SyyBbKeFyLnbQauOlfSBcalAKPxYt1gSAnYYmePJQHXdG/AX9q+zYq8uy+pMrGDW9Te2uhfOVaLlBcCDJbY8preE+cjQ64FleKL8Qv8iExQomJJtqgLLwOja8aproaIQ1aUe4qQ5POoP1517wQnfrc+9MEkIgR8gLVTR5pmhtKUG8mkuKb3G6LcdQnmOFuVSEBuTweBucr0Au9kb0zjbSEYNsU4569Y1yPSx9vYrqK1HK5BrV/dq1kxZOoshRuIbcVIfqQ0k8xwWNrpuhkDSqsWBjDWsi5OR86wnj8zU39OFyk2KiZqmiCmEnosh+HQZGrRbOTw2J8R1ny6pH6jxXaXYbtoYh1nRziPHmM6hOwDFKBJJh1qmP2OosNqdA58CzfhFoWfbNaptKl310sNO5toWLU7Lo+vqIkh3Ur6HICFL9yGFcE1xeiAgB6oSm4Q1PTpNyipceRxJUhNhR7L5FYaIk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.04.25 19:11, nifan.cxl@gmail.com wrote: > From: Fan Ni > > The function unmap_hugepage_range() has two kinds of users: > 1) unmap_ref_private(), which passes in the head page of a folio. Since > unmap_ref_private() already takes folio and there are no other uses > of the folio struct in the function, it is natural for > unmap_hugepage_range() to take folio also. > 2) All other uses, which pass in NULL pointer. > > In both cases, we can pass in folio. Refactor unmap_hugepage_range() to > take folio. > > Signed-off-by: Fan Ni > Reviewed-by: Muchun Song > Reviewed-by: Sidhartha Kumar > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb