From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C6CEC54E41 for ; Thu, 29 Feb 2024 09:33:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2AE86B00B0; Thu, 29 Feb 2024 04:33:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BDAEF6B00B2; Thu, 29 Feb 2024 04:33:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A55746B00BF; Thu, 29 Feb 2024 04:33:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 910316B00B0 for ; Thu, 29 Feb 2024 04:33:52 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5B4C1A1B6D for ; Thu, 29 Feb 2024 09:33:52 +0000 (UTC) X-FDA: 81844329504.11.9252ED7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 0E5F714000B for ; Thu, 29 Feb 2024 09:33:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ey5GCIHi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709199230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=prefAyBiswb2rkdRNkhVYEjSOkqtek6XfQCd+pZ1+gI=; b=rv4r4irNlRmLV66gZTH5P+iYxP4QicWCC0prEwQcyasTFqkEz742vpW5hX9hzQsDE52ZKa zZMs0ZPbjZXKaBaS77DOARtP0gjL9g3A+SeUhEe/8cpsriVquys5BihRsolxMMa297KU6K W7duqKC2zmd9rgWbNPfrxUGdEh55UAA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ey5GCIHi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709199230; a=rsa-sha256; cv=none; b=eJmgRUL0arSZa9PM4i3PxkUyeqwDnjuBswg92+AQyJI0RUprtrJEWTK6GiQSHi6d9BDM+G 54WkaSi20tjlrVIRfhUcYMGr8x0GDxpuelsZShhK3YMeO6CotWq2oF5y4qdrzOJTnOFly9 DMOtTOLU3okjn1ZOuhF1OWmMYPMi3uE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709199229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=prefAyBiswb2rkdRNkhVYEjSOkqtek6XfQCd+pZ1+gI=; b=ey5GCIHi7/iX3rCEF9pZM9tzMfXQBK/oPpZj97BGcSUqxezI8xQ+rp0tnjY13SdCF/AqJA 5V9UOp5YSv3KlmeJdHaF8WBrxPPXb5o1YOBkZgtJlEr7bpiBenc2luYE37U4rTIae5rRzM XzyPfFiPi3z361BcJKHIQWUXHxPYj/k= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-t4X0XlmzPVOcTytqQOWvKQ-1; Thu, 29 Feb 2024 04:33:47 -0500 X-MC-Unique: t4X0XlmzPVOcTytqQOWvKQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-33e10eda176so132620f8f.2 for ; Thu, 29 Feb 2024 01:33:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709199226; x=1709804026; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=prefAyBiswb2rkdRNkhVYEjSOkqtek6XfQCd+pZ1+gI=; b=HNsXVDB58Hsp4RYLf0wJEnGxJSixgImErAYZs7RCItYxCo6P1nZXhyPjCn9CPQZw9G 7Lm2+LG75OcTvgK10lr+3I/0O0EHi1AM385m5JS8ErQx+iouN/RNcmDRskxOiOtDC/um PMe3paUFsgWcA3X5Q30FRoHF8XRlkH0kr9lg1IdsyrhHQJhN1lGrX1SCW70hfjXrlA+b 3ZbFjnTeicV+mnsEkklUovZhvGezrUT3VBw8UdBiiD5ZVrASrf8ivJjg2M0goHdFoJv8 UjgwnIYFL0dSnIjtY65Aaa69yomHyA7UC9HJORdIynC2+WQRmqBPuOcZu0ve/5AMcFg5 9Lfg== X-Forwarded-Encrypted: i=1; AJvYcCVNfp+tlI6YlDosU2EphifTYzcrbnDg+fJG+PCHp7wWs1E3mQr+XBEC6ZRtVthT+sG8HjrLIk0u7WG8I61sHumtATo= X-Gm-Message-State: AOJu0YxB05VOf2qTmyeMC7AtKWJRBhBnFA7yEGq6Ui70KGTVLskyH/HQ 2kULfenLHlfXFMA9l4aQxUzqQPAh2rx/2VOyMlkrUQBiRIkIZ5j7Ou7pogE3i5P4NISLGEEr7Ey lgp4bouimEpcUfuVqqoJwR3GCNzQEHvCfPC6QGHUVqOcDxLxv X-Received: by 2002:adf:fd8f:0:b0:33e:d17:76b with SMTP id d15-20020adffd8f000000b0033e0d17076bmr1148226wrr.7.1709199226186; Thu, 29 Feb 2024 01:33:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHcKOOvPkmwcaE1L+/DihFaD9dENh0bBvEIbitWgvYAlReZ1BVBp5+9ybFpCKsI5ZaLYbmyg== X-Received: by 2002:adf:fd8f:0:b0:33e:d17:76b with SMTP id d15-20020adffd8f000000b0033e0d17076bmr1148198wrr.7.1709199225768; Thu, 29 Feb 2024 01:33:45 -0800 (PST) Received: from ?IPV6:2003:cb:c707:fa00:74f2:89da:ed65:8b50? (p200300cbc707fa0074f289daed658b50.dip0.t-ipconnect.de. [2003:cb:c707:fa00:74f2:89da:ed65:8b50]) by smtp.gmail.com with ESMTPSA id i10-20020adff30a000000b0033b6e26f0f9sm1237401wro.42.2024.02.29.01.33.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 01:33:45 -0800 (PST) Message-ID: <54053f0d-024b-4064-8d82-235cc71b61f8@redhat.com> Date: Thu, 29 Feb 2024 10:33:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH v8 0/8] Reduce TLB flushes by 94% by improving folio migration To: Byungchul Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: kernel_team@skhynix.com, akpm@linux-foundation.org, ying.huang@intel.com, vernhao@tencent.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, rjgolo@gmail.com References: <20240226030613.22366-1-byungchul@sk.com> <20240229092810.GC64252@system.software.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240229092810.GC64252@system.software.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 6jkio5wgk7ozhc6qz1tqrrzi3s4ezzop X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0E5F714000B X-HE-Tag: 1709199229-779749 X-HE-Meta: U2FsdGVkX18kAlEIkYDC9reLFqazHyExuFmab70t3naYukczv46R0eQaoaZCGULZfY1OAJPCCKcCcGaS6V1FH3m/dybyVrT5bJqiw+aR2+vQX9Vs20hgcGTILgGhE+dJx7k+Eh7nKvfPcTC0ssmP8uHcttmDK93iL+6RHYCpTyzj+Y1Mzy9kEd55WgZPdnEd1V4yoECYPjyIqFs/xixfBS9o4qWzQFxgrcrbwjGVAfkYUkmQi9wJzeD4RPdp4N8BWQS2sx7LuGv2y4I0c2EeOMJnOeMRAYtRUCogMR2GUVAoNmc0jikyS/yheOb0Zq4j84L/WSLgk/qSYNx5PrNwzf13zk5gMSzcIMDV/QyKk4B/VbbkZ/cocTHmAhCxq/bN2dnl9EjV0+ynisfMyf8L8j6VMSTGWVdVDFdOWG7jCqgzyD0rIfL95SyW2OERgyUes0vprhSU8P44E/FSdAjEhJ3X9rFNzgH8DX1LI1OfE2pP8llVBkpIIbc8v/s4JIZqBWANbP6gSxF6fDk1Cpq7KuMGTliwoJS1qWgicovEU7ve1QQWiUFI36G80JyoKovIuVFkJUbzg1QcXdaMe2rECWWXoG0eUAEAyLwpDtDMpbdpv+gIziuhGwW9NZme5i+XYZVO1nWnYo0qZWZDyVTwVcc+/BjpYQRez7+Djpa4E1rp8I3RB6Epiil1J2/O5/6F99jU8syHHnh9IVqwVzcrlvZ2eAxTk5XDNrr1JHyrp5KDS5KuBbiAyCkhqkJskIeVwyIx226KXD6uKi2LnrZAhCkDgdRX2cLN4WfwMJBeQkJwV16jnf0YBvFkcRL5SwU6AejeI97UoaK8dSN3Kp/oB2OR8FLtEz+3cVHhdAR7qn9VmFagVmJU/5X8q0PDWCAOwKO0xuaUd/+lHPR8+yiAYoFsIhSGsHsEVHJLmdKW1Z6bvUlv4TaJj8DFhcrusrk6aGy2zl2Kq4XVu+yAVzN jM1M3/LR NtgT6wnSgq8TgrYYBj2RlKFOf76ZZQgUlbO1xuGBJ0R3nOYFTo55lpsjSAWPJphW4TUyF0qSf+rivoZSUbXsodkxm8eH1mNcellgIWE9Yhpw+DiqNT471MpGjUmBvPPYP+nn8u7kXrLOwWp0K340xLkJJ7vN9HpElEBS246ythvMOfzXS4D1YCwmALx81V1IkPTvLPvrVb1ebucaT1TceGWnmocaE3BgdzkMHg5n1dzl2fxL4mcf5KKrCFVJ+gtoNWinIJQiW8+zXkk7tVfN/6eCZ0Xk+mmW+xq0mjmJkYPDJHeiSUPul44mFFMHft8byRHJHBJgQFWhlX/YkE1L87tuvL1e7enwlfZSm8T7eYVRCzmb72Cl3ex9njLlfu9tMXinlOogaKxVTdv1lNyE//MRNU46QKiy7VUV2SKVos5rcYInfbb/EmwIQd7buyUH0nEpSFkO3iOrp8HhxvTYNu52koPzV2D0cAw0BusZuvuhv6PKpXXVnsvedn1txZ5jj5BxX4QeOUZ3oMRQl7ii5sD7n67BjSL0RjMoa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.02.24 10:28, Byungchul Park wrote: > On Mon, Feb 26, 2024 at 12:06:05PM +0900, Byungchul Park wrote: >> Hi everyone, >> >> While I'm working with a tiered memory system e.g. CXL memory, I have >> been facing migration overhead esp. TLB shootdown on promotion or >> demotion between different tiers. Yeah.. most TLB shootdowns on >> migration through hinting fault can be avoided thanks to Huang Ying's >> work, commit 4d4b6d66db ("mm,unmap: avoid flushing TLB in batch if PTE >> is inaccessible"). See the following link: >> >> https://lore.kernel.org/lkml/20231115025755.GA29979@system.software.com/ >> >> However, it's only for ones using hinting fault. I thought it'd be much >> better if we have a general mechanism to reduce the number of TLB >> flushes and TLB misses, that we can ultimately apply to any type of >> migration, I tried it only for tiering for now tho. >> >> I'm suggesting a mechanism called MIGRC that stands for 'Migration Read >> Copy', to reduce TLB flushes by keeping source and destination of folios >> participated in the migrations until all TLB flushes required are done, >> only if those folios are not mapped with write permission PTE entries. >> >> To achieve that: >> >> 1. For the folios that map only to non-writable TLB entries, prevent >> TLB flush at migration by keeping both source and destination >> folios, which will be handled later at a better time. >> >> 2. When any non-writable TLB entry changes to writable e.g. through >> fault handler, give up migrc mechanism so as to perform TLB flush >> required right away. >> >> I observed a big improvement of TLB flushes # and TLB misses # at the >> following evaluation using XSBench like: >> >> 1. itlb flush was reduced by 93.9%. >> 2. dtlb thread was reduced by 43.5%. >> 3. stlb flush was reduced by 24.9%. > > Hi guys, Hi, > > The TLB flush reduction is 25% ~ 94%, IMO, it's unbelievable. Can't we find at least one benchmark that shows an actual improvement on some system? Staring at the number TLB flushes is nice, but if it does not affect actual performance of at least one benchmark why do we even care? "12 files changed, 597 insertions(+), 59 deletions(-)" is not negligible and needs proper review. That review needs motivation. The current numbers do not seem to be motivating enough :) -- Cheers, David / dhildenb