From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23831C4345F for ; Tue, 16 Apr 2024 14:14:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74D526B0083; Tue, 16 Apr 2024 10:14:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FDCB6B0085; Tue, 16 Apr 2024 10:14:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59E486B0087; Tue, 16 Apr 2024 10:14:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3BC596B0083 for ; Tue, 16 Apr 2024 10:14:56 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B2AC4C0A1A for ; Tue, 16 Apr 2024 14:14:55 +0000 (UTC) X-FDA: 82015591350.21.EF3E2AD Received: from wfhigh4-smtp.messagingengine.com (wfhigh4-smtp.messagingengine.com [64.147.123.155]) by imf28.hostedemail.com (Postfix) with ESMTP id 770F9C001A for ; Tue, 16 Apr 2024 14:14:53 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=PhuHidJG; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=DwJzTEWO; spf=pass (imf28.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.155 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713276893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KPzLCaHC/pj+3rFajrw0i7S4P/VVkta4Rje0fImd0yQ=; b=7rq0haLWDByPGU50KfN24aVw4qRUkAr4+oET7tj+l9/4N66wsegbtyb6AfBTmQNlGIygqO OZ1qrCQ39REWwAKZ7zS3exKpCgYvo7UMLuI2GPXrY82KI9fHcewMTMuoMLK6Y/Pptm4Vuc ILk25cPOvn3mo6VX+KqUeTZ0IAFtB8c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713276893; a=rsa-sha256; cv=none; b=holfhCaZPmldR8Sk+Xf4yLHmj2wqA3sd6U5/PMFgFzFjWJwZeQosbCx9CMw81tfWcA+S07 YrEfQMG6q+VzhGEepGBpEWEBUfdi0ixFhMXxG2GNeldlpa/PgM4wVvC5FklTBTG+1g4GSF jMOdxnmJ40CyBLkaEPii0gBoI5kilw0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=PhuHidJG; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=DwJzTEWO; spf=pass (imf28.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.155 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.west.internal (Postfix) with ESMTP id CF4801800101; Tue, 16 Apr 2024 10:14:50 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 16 Apr 2024 10:14:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1713276890; x=1713363290; bh=KPzLCaHC/p j+3rFajrw0i7S4P/VVkta4Rje0fImd0yQ=; b=PhuHidJG8VxEaleWcSvfT8RrHw TcYpy++V74uv3QKWGOlpgpgf+SyQ5ZMUDqJLv+ieUMsuc8Pmtiq++dNE663y9Uad LvrAN0HOtT2qs+A/f4aq+nVonFlt/VwdOkU2nanJjNa82ewBH8oB5aLebg7I9L9Q MQ35Lsqa1E3jBtPSDHEtJJYSzPk0kEH2oNsZ+DH7YzOAgG77pfREDjIKDZK0OlU1 ykJdeMBcVae2QG9+ALYmi6W5QL9dT2t1oSscxO7e/VEwRsVmEZ0C2f4Zbh9vjVw+ W7IpXT1f6uaR8m9elp7Eg6QbzlD/0IGMBHFJTDDTj/YgkNWa9g2+6a+UOAVg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1713276890; x=1713363290; bh=KPzLCaHC/pj+3rFajrw0i7S4P/VV kta4Rje0fImd0yQ=; b=DwJzTEWOX2Hls51YomwtsnXC6I5vZWVj1oEjCmZqd/w4 /BM9dctAypC3VAh4Oz4mY5kcs6zSW8fe8cAZRgBLT55bjA2fqIDMNe6WGNO2KRuZ Jjr3ZtAKKxCedEfxYPU1bazquw118noVHXdS6lyH410qPjgoLUJXE2hO07NqjAt5 8Hcs44ULBFzJak5+kCEL52Xk8RDeQY0GcG2jRLdtWqv3OJ6v8QIdpm0CMDrt/K9C lY5NoW7RWgLaOzRd+eqlsZnc4LwI2mzdxNykJ4pUQ57VU7MJEG9gzAjvcCM/7O3x +JWWrL+wX7/DQoBETaXJDPd5ndEqTBtJtmv+W+8xsA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudejiedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepjefgfedvgeejvdefudeuhfdtkeekvdeutefhuedthfegheelhefgleegkeeg fedvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghdpledqrhgtuddrhhhofienucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghr nhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 4BA4BB6008D; Tue, 16 Apr 2024 10:14:49 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-379-gabd37849b7-fm-20240408.001-gabd37849 MIME-Version: 1.0 Message-Id: <53d194db-c7d4-4026-9fbb-3b41de545849@app.fastmail.com> In-Reply-To: References: Date: Tue, 16 Apr 2024 16:14:29 +0200 From: "Arnd Bergmann" To: "David Hildenbrand" , "Miguel Ojeda" , "Huacai Chen" , "WANG Xuerui" Cc: "Andrew Morton" , "Ryan Roberts" , Linux-Arch , Linux-MM , linux-kernel , loongarch@lists.linux.dev, clang-built-linux Subject: Re: ./include/asm-generic/tlb.h:629:10: error: parameter 'ptep' set but not used Content-Type: text/plain X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 770F9C001A X-Stat-Signature: fwbbxggm77ndo4um5s5fmbzoxsxcr83q X-Rspam-User: X-HE-Tag: 1713276893-580426 X-HE-Meta: U2FsdGVkX1837/GpOOeVEI9LQDEd5m98JoFXhF8g1W6lJbM80a9mCbWwAXvwrlDKkJmlVD0MAr9hLeQcTv9dHwolsjLxlcIuuCdlGPhvkZT55TA4xoUNJHfQGBxcs8iDHdyQJR+TKMYkvbTOrjllcgQ3BK1/+57UESt6TMxNEl4h2FVOye1GzPml2r6hBaxIfPeCj1kCgSAdnmQeE6elvOj+2HEU/BdQT7uctBuT9MD6m+M7RFv4I6hU6WnlTEYWFEbT6lYkzSjRZMmw2pxZPvYOKZNoNxjShdV2Zyt8QFynrxziVge0H2OU2d5gSCqqV2onRzFSirTH1k86t3Y1XrocRy5qCQSMIuejf2I145XBNni4Q1Sa5qOsgibvLUq4D6pWcNDT6ctaa2wUWcvTbGXmsBLuATYDtIttlCYjkd/0bDzZnedR4dxnx/4UzOon6BH0x/3sWsUYI2+Brin6eGUMO2Lo2k7ClJmPGz3h3nvxjPlUNB01nyf0GKIwCaU2J0wXxcpcyTQro4coTRs3cHuBM55QseuBpjh7ZLTXgUM8su7bGaGhRJ1YItHKTVxf5qbZYXxMJj7tfJlJ19tcUfW8CM+7YeeKIdPz4W77QxQQRXcnXYcau3A7TAvDOB/HG425nxPLsDGc2w3/Xjq3a0L75rGzjOJncUGzOkGNgqDBDpZXB5QZYWb+sEBt5cA+u7JEe/NM6FFCcvkyaUFIweyMDbYXgLijfS7t4sm6WE+miIFWdqvB4LZyH1LfFpFOdxcKm1Kj2T4fI5WHLrZJy0Tfwr0EIaXJJmXrDGs2OEjZ0Vmq34NvcwEPAY0EbZJxZRxyNWlu+4+omykXiErIvLG8rERPymJpP6Yd31q5ozIFkt7sOSrYgoTLNkPUQGfS38Kv6jDAo7yutIREllNKwNUIqe2vWTfgw9Tj/ogHO6AL48MVjK0z2j+MY7dEN/qobMqDSbFkYsnGDNakaLP ZEmL25rM N+nmEoVUqwkk0i0s5W/XLMwuZKkKZiXOi4hTbdru12oNo+gLKJdUrnrIPfhHAJD1mvd4ySBvuuAFTp9WWQ6ykeNEZSYVuZCIfze8o/+sR80t+VSDdYbZu8AU5rXBx2h1qvditw6o49p4K60su2ZVxcx0g4WG8egIpN3pLuQHWFXDwT+gJo06EdUjO4NHvbVmpFsXX6WBzSBTiYeq8OKnWs5Pk26pvS1uo7uwGoRs4h2sAsm4TIMcD22aAEQ1Uev4pc5CR820WHZsj2olBc5+22t2L0eXY1h/05gneoC5YZu6iJCGAP0CDv29/xg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024, at 15:51, David Hildenbrand wrote: > On 16.04.24 12:26, Miguel Ojeda wrote: >> Hi David, Arnd, LoongArch, >> >> In a linux-next defconfig LLVM=1 build today I got: >> >> ./include/asm-generic/tlb.h:629:10: error: parameter 'ptep' set >> but not used [-Werror,-Wunused-but-set-parameter] >> 629 | pte_t *ptep, unsigned int nr, unsigned long address) >> | ^ >> >> Indeed, in loongarch, `__tlb_remove_tlb_entry` does not do anything. >> This seems the same that Arnd reported for arm64: >> >> https://lore.kernel.org/all/20240221154549.2026073-1-arnd@kernel.org/ >> >> So perhaps the loongarch's one should also be changed into an static inline? > > 4d5bf0b6183f79ea361dd506365d2a471270735c is already part of v6.9-rc1. How come > we see that only now on linux-next? Andrew merged my patch to enable -Wextra yesterday, and it appears that this one fell through the cracks with my testing, either I missed the combination of loongarch with clang, or I last tested it before your patches got merged. > I assume we should see the same on upstream Linux with LLVM=1, correct? On upstream, it only shows up with 'make W=1'. > If so, we should likely just drop that completely and rely on the > asm-generic one: > > diff --git a/arch/loongarch/include/asm/tlb.h > b/arch/loongarch/include/asm/tlb.h > index da7a3b5b9374a..e071f5e9e8580 100644 > --- a/arch/loongarch/include/asm/tlb.h > +++ b/arch/loongarch/include/asm/tlb.h > @@ -132,8 +132,6 @@ static __always_inline void invtlb_all(u32 op, u32 > info, u64 addr) > ); > } > > -#define __tlb_remove_tlb_entry(tlb, ptep, address) do { } while (0) > - > static void tlb_flush(struct mmu_gather *tlb); Yes, this looks like the best solution, and I can confirm that this addresses the warning on linux-next. Tested-by: Arnd Bergmann