From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C78BFE7718B for ; Mon, 23 Dec 2024 20:22:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEA456B007B; Mon, 23 Dec 2024 15:22:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A99146B0082; Mon, 23 Dec 2024 15:22:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9897C6B0083; Mon, 23 Dec 2024 15:22:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 79A516B007B for ; Mon, 23 Dec 2024 15:22:34 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DC7DEC0EEC for ; Mon, 23 Dec 2024 20:22:33 +0000 (UTC) X-FDA: 82927345410.23.8EC646D Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf12.hostedemail.com (Postfix) with ESMTP id 59CA94000D for ; Mon, 23 Dec 2024 20:22:15 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734985323; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q2S262BxR0T/gwDbq4fc6mQ8zGfBDLouAQU5cit78Mc=; b=PKDhj/FKBzKgd08ll9OUVeFlZGl/JaizIV8c2JLLfI3dl/32GxCaL0HbgrF2RrWMyn5f9W uS4W9Hji2AsuzwJiL83cj/wCyTiz9/i3NkjIgHbqDsJlvFVRjhYUP4jm4qJJN9eextDItM bDuarOn+/MZ1Q2k1AW4Iyxjg9TMB+ZM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734985323; a=rsa-sha256; cv=none; b=LSZZXqF0nzmxgb9liWMcyrlGMoGIpxKKqm976SNe+dJT21lQDFMcyKFQrpKwyeaFau/SBp n9czyUd53hmGQxegp29ymxqkGcI+hBPdqFkpO16Ptd8y3ShpvUefRPdhorXf+0NaLCyAWr rcNAoylu+EylgeHXwdOFfK+2ti9ck8A= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tPouf-00000000619-3vev; Mon, 23 Dec 2024 15:20:25 -0500 Message-ID: <53c9c3784a8136f41ac3c6ec3725af406f5394a5.camel@surriel.com> Subject: Re: [PATCH 01/11] x86/mm: make MMU_GATHER_RCU_TABLE_FREE unconditional From: Rik van Riel To: Qi Zheng Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org, linux-mm@kvack.org Date: Mon, 23 Dec 2024 15:20:25 -0500 In-Reply-To: References: <20241223025751.3268975-1-riel@surriel.com> <20241223025751.3268975-2-riel@surriel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspamd-Queue-Id: 59CA94000D X-Rspamd-Server: rspam12 X-Stat-Signature: 1inmtqdq4rdyky6j7zt9kss11prsthdi X-Rspam-User: X-HE-Tag: 1734985335-161254 X-HE-Meta: U2FsdGVkX19UK6DfeUpLtp3GroCnnF/1wWz/PpuuvaLfyXi8Nvf8f3pZD96fWcCR1oyj8MrW2q//Fp1mU7BriKn5PcDxcRvZSnptahr2KUbv9sMCv2dyQksOZenz4/acEPxPXavx968x5dFQIE21ESIleU+9FZyfP+ZzQU18Zm2lI+Fkjbwx/sNsUhCGKQc6eO7zJpFX/vV0Q8B/1M5v05utO6bmdrJk1wcoCPyuM0FSO4ugID72ylfDNHCji0b9V7wJYWEByqnfGlpAfdE3j3C0210EidPa7tQDy5oQ0+38izs//oiH7Yu+r7rxJKNwICc0NaMWAPbwL2CKW2tCzf8ehkoRsi6UppFCGuj2Gbp1zU+L4WgH7mXVe5IftlQ2sXsanU1/WeIJ99v185Fi/MPGoURroMQLmUzc5i+8Cv57y8NveFKuBTFctNPIrGS0OkGyxf9EjOijIVWhmt/R41lDoeyaJmYVx0ggk5AUmapjDzET7O4nKsIbJj8V8ncNaecfZynUj/Vfp4srqmrORrH/GG8wcNdMLAMQqU0/PMsVNU8Jhoyq54oBVcuL4NXEFLzPAksbRCQGsGRIhMpj+hUqgwkTLl1JBLVF756Cx0SZ2J11JrDG1vqdaeigQPNRP3aBHCTA+F4ZEfyfRhQp9vGLdDSi0rTKOMoXRC+boNbq0owXehb1i1+7mSgihJz6UIXyVuiZakclDjNBqQzejwSwL4X/2SBFdU1ZFSnecL5RIW+Wl8zpfsX24DDALhE3XC0yRMfS8yXE17QXClIdmfB7MUN2yp3B0Jznc2N+iHvLhIvuR9et+XbyHTwlO3M0jnkKvYiMn0hCpd3nDlTr8qQrO4Hp2G+iVBllGmsolOjkeZUCyOOAsW6Eu5DCo8sb3bWwNARdEGwlc2qREd2N7448OLVdMRunAFd9CsIHAmWXxLEueEloVi0dFOj4SEIX2U75Hzk4QYwEEP+3ZUk P+btnBar AAehXaZ/4y4MOQxaoZkdWg1oCFiYg2fPlgFKAXLCGndmwfkdw8tULbhfuuIU7iakiUytXtIcbJvtpSnyOrV1lscvb77Xjev5HvypwYhoapgwAUJUFnnMGU7AKn9FeoK5YFRFQjFPj6iF/rW/cPJozln/7MuFfqOaeoUdbCaiEnBYq1K8S8wOtgeU2YRAcGLjmRAzNGFzn7ZQZ/rRsA+vV2FLsnOx+KaINmOAJsPGhV2b3y9tePhS+Mi5lA7H/96VVxvziA03friCi8uV5CM7UTQH2EsVX2NHzrcyssWLAh8s2JcgukjQES2OCKzDeWavRunQY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2024-12-23 at 14:01 +0800, Qi Zheng wrote: > Very happy to see this change! >=20 >=20 > > @@ -191,7 +186,7 @@ struct paravirt_patch_template pv_ops =3D { > > =C2=A0=C2=A0 .mmu.flush_tlb_kernel =3D native_flush_tlb_global, > > =C2=A0=C2=A0 .mmu.flush_tlb_one_user =3D > > native_flush_tlb_one_user, > > =C2=A0=C2=A0 .mmu.flush_tlb_multi =3D native_flush_tlb_multi, > > - .mmu.tlb_remove_table =3D native_tlb_remove_table, > > + .mmu.tlb_remove_table =3D tlb_remove_table, > > =C2=A0=20 > > =C2=A0=C2=A0 .mmu.exit_mmap =3D paravirt_nop, > > =C2=A0=C2=A0 .mmu.notify_page_enc_status_changed =3D paravirt_nop, >=20 > It look like this patch series is not based on the latest linux-next. >=20 That is correct. I based this on tip.git x86/mm, since that seems like the most likely destination for this code. > In addition to the above case, maybe the paravirt_tlb_remove_table() > in arch/x86/mm/pgtable.c also needs to be changed to > tlb_remove_table()? I'll get that in the next version. Thank you for reviewing the patch! --=20 All Rights Reversed.