linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	kbuild-all@01.org
Subject: [next:master 6807/7059] fs/proc/vmcore.c:343:5: sparse: symbol 'remap_oldmem_pfn_checked' was not declared. Should it be static?
Date: Thu, 17 Jul 2014 19:17:51 +0800	[thread overview]
Message-ID: <53c7b0df.yqSb/wPd+JtR6bKk%fengguang.wu@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   b395397b3a268e96061feca8dbed5e70f777e9a2
commit: 456979f56a5872619f70f7ab5ceaa65f1b0cc3dc [6807/7059] mmap_vmcore-skip-non-ram-pages-reported-by-hypervisors-v4
reproduce: make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> fs/proc/vmcore.c:343:5: sparse: symbol 'remap_oldmem_pfn_checked' was not declared. Should it be static?
>> fs/proc/vmcore.c:394:5: sparse: symbol 'vmcore_remap_oldmem_pfn' was not declared. Should it be static?

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[-- Attachment #2: make-it-static-456979f56a5872619f70f7ab5ceaa65f1b0cc3dc.diff --]
[-- Type: text/x-diff, Size: 1117 bytes --]

From: Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH next] remap_oldmem_pfn_checked() can be static
TO: Vitaly Kuznetsov <vkuznets@redhat.com>
CC: linux-kernel@vger.kernel.org 

CC: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 vmcore.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c
index 405a409..566e6f0 100644
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -340,7 +340,7 @@ static inline char *alloc_elfnotes_buf(size_t notes_sz)
  *
  * Returns zero on success, -EAGAIN on failure.
  */
-int remap_oldmem_pfn_checked(struct vm_area_struct *vma, unsigned long from,
+static int remap_oldmem_pfn_checked(struct vm_area_struct *vma, unsigned long from,
 			     unsigned long pfn, unsigned long size,
 			     pgprot_t prot)
 {
@@ -391,7 +391,7 @@ fail:
 	return -EAGAIN;
 }
 
-int vmcore_remap_oldmem_pfn(struct vm_area_struct *vma,
+static int vmcore_remap_oldmem_pfn(struct vm_area_struct *vma,
 			    unsigned long from, unsigned long pfn,
 			    unsigned long size, pgprot_t prot)
 {

                 reply	other threads:[~2014-07-17 11:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53c7b0df.yqSb/wPd+JtR6bKk%fengguang.wu@intel.com \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox