[mmotm:master 181/478] mm/vmstat.c:1248:16: sparse: symbol 'cpu_stat_off' was not declared. Should it be static?

[mmotm:master 181/478] mm/vmstat.c:1248:16: sparse: symbol 'cpu_stat_off' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   233caf2762158b2e2a7c03ba1d17e57a87f0670c
commit: 28ed3dd4a9b9f990a4131631ec2ff74233e2ebbc [181/478] vmstat: On demand vmstat workers V8
reproduce: make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> mm/vmstat.c:1248:16: sparse: symbol 'cpu_stat_off' was not declared. Should it be static?

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[-- Attachment #2: make-it-static-28ed3dd4a9b9f990a4131631ec2ff74233e2ebbc.diff --]
[-- Type: text/x-diff, Size: 906 bytes --]

From: Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH mmotm] vmstat: cpu_stat_off can be static
TO: Christoph Lameter <cl@linux-foundation.org>
CC: Johannes Weiner <hannes@cmpxchg.org>
CC: linux-mm@kvack.org 
CC: linux-kernel@vger.kernel.org 

CC: Christoph Lameter <cl@linux-foundation.org>
CC: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 vmstat.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmstat.c b/mm/vmstat.c
index ababac7..a3a5cce 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1245,7 +1245,7 @@ static const struct file_operations proc_vmstat_file_operations = {
 #ifdef CONFIG_SMP
 static DEFINE_PER_CPU(struct delayed_work, vmstat_work);
 int sysctl_stat_interval __read_mostly = HZ;
-struct cpumask *cpu_stat_off;
+static struct cpumask *cpu_stat_off;
 
 static void vmstat_update(struct work_struct *w)
 {

Re: [mmotm:master 181/478] mm/vmstat.c:1248:16: sparse: symbol 'cpu_stat_off' was not declared. Should it be static?

[Christoph Lameter]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 235 bytes --]

On Thu, 17 Jul 2014, kbuild test robot wrote:

> >> mm/vmstat.c:1248:16: sparse: symbol 'cpu_stat_off' was not declared. Should it be static?
>
> Please consider folding the attached diff :-)

Acked-by: Christoph Lameter <cl@linux.com>

[-- Attachment #2: Type: TEXT/X-DIFF, Size: 906 bytes --]

From: Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH mmotm] vmstat: cpu_stat_off can be static
TO: Christoph Lameter <cl@linux-foundation.org>
CC: Johannes Weiner <hannes@cmpxchg.org>
CC: linux-mm@kvack.org 
CC: linux-kernel@vger.kernel.org 

CC: Christoph Lameter <cl@linux-foundation.org>
CC: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 vmstat.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmstat.c b/mm/vmstat.c
index ababac7..a3a5cce 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1245,7 +1245,7 @@ static const struct file_operations proc_vmstat_file_operations = {
 #ifdef CONFIG_SMP
 static DEFINE_PER_CPU(struct delayed_work, vmstat_work);
 int sysctl_stat_interval __read_mostly = HZ;
-struct cpumask *cpu_stat_off;
+static struct cpumask *cpu_stat_off;
 
 static void vmstat_update(struct work_struct *w)
 {