Re: [PATCH V2 2/2] mm/migration: Add trace events for base page and HugeTLB migrations

[Anshuman Khandual <anshuman.khandual@arm.com>]

On 1/25/22 3:11 PM, kernel test robot wrote:
> Hi Anshuman,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on v5.17-rc1]
> [also build test ERROR on next-20220124]
> [cannot apply to hnaz-mm/master rostedt-trace/for-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Anshuman-Khandual/mm-migration-Add-trace-events/20220125-110944
> base:    e783362eb54cd99b2cac8b3a9aeac942e6f6ac07
> config: xtensa-randconfig-r031-20220124 (https://download.01.org/0day-ci/archive/20220125/202201251716.ncCstDar-lkp@intel.com/config)
> compiler: xtensa-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/f1100840c009fceb20d26ac4564c9d4c9c23c729
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Anshuman-Khandual/mm-migration-Add-trace-events/20220125-110944
>         git checkout f1100840c009fceb20d26ac4564c9d4c9c23c729
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    arch/xtensa/kernel/entry.o: in function `fast_syscall_spill_registers':
>    (.exception.text+0x253): dangerous relocation: windowed longcall crosses 1GB boundary; return may fail: make_task_dead
>    xtensa-linux-ld: mm/rmap.o: in function `page_remove_rmap':
>>> rmap.c:(.text+0x11b0): undefined reference to `__tracepoint_set_migration_pte'
>>> xtensa-linux-ld: rmap.c:(.text+0x11b4): undefined reference to `__tracepoint_set_migration_pte'
>>> xtensa-linux-ld: rmap.c:(.text+0x11c4): undefined reference to `__traceiter_set_migration_pte'
>    xtensa-linux-ld: mm/rmap.o: in function `try_to_unmap_one':
>>> rmap.c:(.text+0x135d): undefined reference to `__traceiter_set_migration_pte'
>>> xtensa-linux-ld: mm/rmap.o:(__jump_table+0x8): undefined reference to `__tracepoint_set_migration_pte'
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> 

The following change should fix both the reported build problems.

diff --git a/mm/rmap.c b/mm/rmap.c
index cce5dbae07f2..cae1c46440d6 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -76,6 +76,7 @@
 
 #include <asm/tlbflush.h>
 
+#define CREATE_TRACE_POINTS
 #include <trace/events/tlb.h>
 #include <trace/events/migrate.h>