From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45CE6C3DA5D for ; Fri, 19 Jul 2024 07:06:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC4796B008C; Fri, 19 Jul 2024 03:06:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B72FB6B0092; Fri, 19 Jul 2024 03:06:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3A696B0093; Fri, 19 Jul 2024 03:06:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 869756B008C for ; Fri, 19 Jul 2024 03:06:37 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2CC1B1A0469 for ; Fri, 19 Jul 2024 07:06:37 +0000 (UTC) X-FDA: 82355619234.23.9970D8E Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf04.hostedemail.com (Postfix) with ESMTP id E158A40020 for ; Fri, 19 Jul 2024 07:06:33 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=j4w6zoeH; spf=pass (imf04.hostedemail.com: domain of quic_jkona@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_jkona@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721372738; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cSFCnhTLYq+7gO4dH4MIElWjWBd6oBuSpudE9Awk79A=; b=VGKMDIcSJzE70C17VIu0uefZYZJRQzYcwzueWJBW/Euk4uesoWUJ59bC62ek1HiCYlQSzA L7Tj+G9kCYGk4iDGEAkSAaGD2ax0b4TRpXxC5MrShr7TcwYn1ftc5U0+o2nqxiTwo3ageB 34zK0WAgoI1CR9wiHNGBF/yR/6aFrYU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=j4w6zoeH; spf=pass (imf04.hostedemail.com: domain of quic_jkona@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_jkona@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721372738; a=rsa-sha256; cv=none; b=5KzQojgMddCZYBafKiESumlRrG36j6ACfQ0BWAyKXfo6ef4OGsjReu2NKcvKlJTXQpEGOm /bdfdUAmzD4IJf7wAOBN+6j8oic1k52G6Q33zs53EAQnIdLul4BvP2sT5knGQ47j5rB3Qb 13c4uZvFopvDGQVB0vFwM7lqT43aIh4= Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46J0tIa0032736; Fri, 19 Jul 2024 07:06:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cSFCnhTLYq+7gO4dH4MIElWjWBd6oBuSpudE9Awk79A=; b=j4w6zoeHPJe3kgmu pCc+ywWHdwYw6zw6qERTL13ps5fgxHQTd2ssor6rkxtBSKjgmdw1p7ytVaeObAfx 6W2FS3GgYnbeQUtcE1RTJ2bbi/Wz8sucbtQ96Ou8BnxveAVcxktGiPSROh0mg+GL dFOmu0uSsV+Jv4i/S2lKbBhKNlhQFRREfWw7EvIeq+bANOebu1g1xorjv2v1O6VN Mp89usq+2Gg3f0dr61RQUuf80sEHz6O4IsKU8xxTU4kZYL4OGHVT3G0KlhkMK9bF TXIDXpFfPzPq1tlSN/FcHouDBT7IIJUUq6ERdg4uIzRBsJxvK+Zw9jqnJVtJkWVU k7eilA== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40fe1d8kw7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Jul 2024 07:06:27 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 46J76PW5010722 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Jul 2024 07:06:25 GMT Received: from [10.217.216.47] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 19 Jul 2024 00:06:21 -0700 Message-ID: <53c18dbe-930b-4b0e-a134-7210bf61c8e5@quicinc.com> Date: Fri, 19 Jul 2024 12:36:18 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master 7766/10451] drivers/clk/qcom/camcc-sm8650.c:3573:29: error: incompatible pointer types passing 'struct device *' to parameter of type 'struct platform_device *' To: Krzysztof Kozlowski , kernel test robot CC: , , "Linux Memory Management List" , Bjorn Andersson , Bryan O'Donoghue , Dmitry Baryshkov , Vladimir Zapolskiy , Taniya Das , "Ajit Pandey" , Imran Shaik References: <202407072331.baglL4Sd-lkp@intel.com> Content-Language: en-US From: Jagadeesh Kona In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: yhIPqF3NGaCqvucUbY2y7al7XXmvFZxE X-Proofpoint-ORIG-GUID: yhIPqF3NGaCqvucUbY2y7al7XXmvFZxE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-19_03,2024-07-18_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 suspectscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 impostorscore=0 clxscore=1015 spamscore=0 mlxlogscore=999 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2407190055 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E158A40020 X-Stat-Signature: bkmxsbczjqbxam7gfzowsk7teb7urw6r X-Rspam-User: X-HE-Tag: 1721372793-54700 X-HE-Meta: U2FsdGVkX180dFGZmy8pO/HRWzrTCfXxAyYYEF9xSbxjYmlrYbPWN0PtEemPVSmgTOFRD48rQZvxYte2IQ4MclrRKj7LgizJkuMLh5zHlUGSW2i2wPHC1KI3M/HIhGEotTdWugU8oOyiO1E4Kdk6cfwSdk/Ou3YkfdKqn4NnSosjoCOOQ2CdX+G60l3rHcA3qLucOL3nMDqylauGJvXCGHx3zbqY3D56IZ/4dWCaceQJqfhmLzJKi84Z3rJEsMaC2wbfCjWMmAYmTYVwt0f850QsurF6FRnoiz1gdHXjdWnPLhDAQZvDbz0hvd/JldwkpSgkF8IUztGfqrE/4FGTQQrEQKxNKsvLFHLnsswe5fqFjPgOAiRphjhzdPctpJnihsEBElk62GUgjnkQRz+GikkN+jlv6mzQcpJi8HE5aKVSIOpUC18N9+IY7Tndl1Hj5UR+ZDDsN95HEHF227lH6+la2AEgXatFOWwhDEXgvcqYZ83Lfr8bCqPBvG9TzHp3xr6o4VVdfBlBqQPo5gpbJHlZPOPsWkFhb1PEUAxl10iHnWzW2+aajUeecsolXmnBkkH9AMqKFaJrE05C3NqxYt1vf61A4KvNZPlOnz3fpQ3XSkcyLb6u08w1ZYIJjn3T83TEFhK22VtPjPLblhHFJIa9qvujrVNpRyBr459LbdEf6PyANbftyU+KPVUa1BYBgq3CTrMhnEuA1El3aEqkAKLyP0LWUoVm2X9ka3ILIYYlYFH/G/a2fceq3H7Ksz9Ryl9/zyNBcNE10VU9XcCT2ERJYS8MYSLK/Hx1qaJ6C9JFS+c1vO0bkgHFth5QH7zhexzLUNgJ2lEiZDq8L3y9nhSvanxoU8cGkAu7TnykLE+HmMieDZkknZitgI3g3PmltZim3xB35KT1NBepDXjoupNrYOwK488N2RSN/zhAK86v6izY4Pzw7Y1bsAAvzWWQCcQC7VSwrT3+uTH4XOA cp/sBNyA ohWdiWUSIzkLszRv+gHkgF8qyRQYZQoumgoNeoT6vGXwiw8ICSZCLh8XVrwj6ZiWJ+EHF0/GoDqYEOOyfyyuK41srXfSmvMa42YqYbZEgMH7VZPlzs7qqfrdMclQtyfu6vrTo8NhJQqu+Rp/sMUMq9jdmD6X3gbI7scGTNnW4Y2KSNfKGjl3ATsXIoqRosN1cY0nFOWbn0DVjTgS7+NeiAQ6oC26hnOWZIiRhqYsuvRqSJCRPCJWpBFkyR9MtXnsHnmuLDp1tzlKGNl39yp+pQWZBaKDuaWYYQz8R9Wxg3lkliicu06S2iKSLNDqBLWaGEstwnT/Qfz8rW4gF1QBUvQNUcC2PsrBWkOOWUpHtWJq+GDdSYMw5m7w6+WQ9jNDozqFWJjHoV9KJy3WaVixSPsOMFJUFikWJlEt1nAcp1/vH8KVKjWA2AyIhr5ePyD9mf7G39HU4VywadwyRVZ6+lV/jpe4NeHokxBt0GpMZRoVTmWA0N6kCczs0mg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/18/2024 3:36 PM, Krzysztof Kozlowski wrote: > On 18/07/2024 11:48, Jagadeesh Kona wrote: >> >> >> On 7/18/2024 12:18 PM, Krzysztof Kozlowski wrote: >>> On 07/07/2024 17:20, kernel test robot wrote: >>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >>>> head: 0b58e108042b0ed28a71cd7edf5175999955b233 >>>> commit: 09ea421652a832083ea380a72addf383965f3682 [7766/10451] clk: qcom: camcc-sm8650: Add SM8650 camera clock controller driver >>>> config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240707/202407072331.baglL4Sd-lkp@intel.com/config) >>>> compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) >>>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240707/202407072331.baglL4Sd-lkp@intel.com/reproduce) >>> >>> This and this: >>> https://lore.kernel.org/all/202407072212.WptVaUDt-lkp@intel.com/ >>> >>> are reports on linux-next. They were addressed to you/ >>> >>> Jagadeesh, how did you respond to public reports that your commit has >>> build failures in linux-next? >>> >>> It reached now Linus' tree causing huge rant, unfortunately not in the >>> direction we would like that rant to go. >>> >>> If you receive a report that your code does not even compile, it is YOUR >>> DAMN MOST IMPORTANT TASK to address it IMMEDIATELY. >>> >>> I don't think such code should be ever accepted if contributors do not >>> take responsibility for their commits. >>> >>> Krzysztof >>> >> >> I initially submitted my change [1] by passing pdev to >> qcom_cc_really_probe(). Seems like due to [2] which changed the >> qcom_cc_really_probe() parameters from pdev to dev, my change was >> updated from pdev to &pdev->dev while applying. >> >> When this issue was reported by kernel bot, I checked out the linux-next >> tree but I didn't see this failure since the common change [2] was > > So tree is not bisectable but that's fine? How about telling the > maintainer: listen, your tree is now broken? > >> already merged into linux-next. I apologize for not reverting the same >> over the email thread. >> >> But change [2] was somehow missed and only my change [1] landed up in >> Linus's tree, which led to this failure as Arnd described in [3]. > > Nothing was missed. That commit should have never been accepted to that > branch, but, since it happened, you claim that dependency in clk drivers > should as well go to DTS branch? No, that's just wrong. > > Mistake was that particular commit going to that branch and kernel robot > told you that which you (and Bjorn, but Bjorn is busy so it is your job > as contributor) should investigate. > Yeah, it's my bad that I did not point out this issue. I will be more careful from next time. Thank you. Regards, Jagadeesh > If that's how commits from quicinc look like I am afraid to take > anything. I will be on my own, stuck with such issues, because for > contributor "it is fine". > > Best regards, > Krzysztof >