From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Dev Jain <dev.jain@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, Mark Brown <broonie@kernel.org>,
aneesh.kumar@kernel.org,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH] selftests/mm: remove virtual_address_range test
Date: Mon, 19 Jan 2026 11:11:18 +0000 [thread overview]
Message-ID: <53c0f278-6029-45f3-b3db-e2b70f323abe@lucifer.local> (raw)
In-Reply-To: <f7ed83bf-3554-4bfb-8d77-30ed4785a4a8@lucifer.local>
On Mon, Jan 19, 2026 at 08:59:01AM +0000, Lorenzo Stoakes wrote:
> Anyway.
>
> Practically speaking I think there are two ways forward here (not mutually
> exclusive):
>
> 1. Implement something in kunit or similar that explicitly tests
> get_unmapped_area().
>
> 2. Add a _new_ selftest, named something sensible like mmap_hint.c or something,
> that runs only on relevant arches, and does NOT try to do crazy stuff like
> mapping the entire VA space, but instead simply tries some trial unhinted
> mappings some hints in 48-bit space, and some hints in 52-bit space and
> asserts things are as expected.
>
> If you do point 2, please please use a. use the kselftest_harness.h to write the
> tests in a nice way (see e.g. guard-regions.c for an example of how it's used)
> and b. use the procmap helpers in vm_util.h to check on VMA ranges, you can see
> how they're used in... the merge.c tests you so deride :)
>
> If you or others do both/either I promise to dedicate review resource to the
> series(es). That fair enough?
>
> Thanks, Lorenzo
It seems to me that the va_high_addr_switch test is already asserting all
we need unless I'm missing something, so unless I'm much mistaken I think
simply removing this test is the right way forward.
A kunit test for get_unmapped_area() (if possible, as not exported) would
still be useful, however.
Cheers, Lorenzo
next prev parent reply other threads:[~2026-01-19 11:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 13:20 Lorenzo Stoakes
2026-01-17 1:21 ` SeongJae Park
2026-01-18 7:55 ` Dev Jain
2026-01-18 12:58 ` Lorenzo Stoakes
2026-01-19 6:21 ` Dev Jain
2026-01-19 8:59 ` Lorenzo Stoakes
2026-01-19 9:06 ` Dev Jain
2026-01-19 9:13 ` Lorenzo Stoakes
2026-01-19 11:11 ` Lorenzo Stoakes [this message]
2026-01-20 5:29 ` Dev Jain
2026-01-20 8:43 ` Lorenzo Stoakes
2026-01-20 10:20 ` Dev Jain
2026-01-19 10:39 ` David Hildenbrand (Red Hat)
2026-01-19 11:06 ` Lorenzo Stoakes
2026-01-19 11:11 ` David Hildenbrand (Red Hat)
2026-01-19 11:16 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53c0f278-6029-45f3-b3db-e2b70f323abe@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=broonie@kernel.org \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox