From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A64BEC3DA64 for ; Tue, 6 Aug 2024 11:02:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3496C6B007B; Tue, 6 Aug 2024 07:02:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FA436B0082; Tue, 6 Aug 2024 07:02:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14C866B0083; Tue, 6 Aug 2024 07:02:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EB2456B007B for ; Tue, 6 Aug 2024 07:02:50 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4C9BF809EB for ; Tue, 6 Aug 2024 11:02:50 +0000 (UTC) X-FDA: 82421532900.06.EB06AFA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf24.hostedemail.com (Postfix) with ESMTP id B6376180011 for ; Tue, 6 Aug 2024 11:02:47 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dafgAsjI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=eaR+tEPi; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EHe7Ttnm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kw9g0X29; dmarc=none; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722942121; a=rsa-sha256; cv=none; b=dSGYpnTM7YQRBp6/ehoYc3g8z/cJAewQYF+M5qdO+VHhZreOQv/dsK/wG0p0PyaZrmIWr6 04Fwhp8wHb/JYNAez545wXH++Tgew7SDnStP8ZiGLpcd9ae30JKPR1KxZf/LmBOdXG0JMd FWO4CmSsVIJt40LHC+ItYMdppdkE+44= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dafgAsjI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=eaR+tEPi; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EHe7Ttnm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kw9g0X29; dmarc=none; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722942121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yMCXfwsD69mi8EaHLN1W8uTi3azOp475jm7XAaTLgJU=; b=4zLxup5bv+uo5SCMv+p7Db0YrtZ2FBR1R2SzTjnqZbbcXJe3eDkoyv43u7SEFu0Os9+pRv VxyT/xV5uH8ROJ06NYEgtu0yARI1IP6sKhQlhLIRRNtIPgAbJDiDEz0q6+PdEW7UhGcIyI 32XtTcrXbsWwYcn1PphH+zgfQFQrHXo= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D2ACB21B66; Tue, 6 Aug 2024 11:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722942166; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yMCXfwsD69mi8EaHLN1W8uTi3azOp475jm7XAaTLgJU=; b=dafgAsjIPVW4fEsg9Ao3huPn3114MBGHFEb4/+v/XKwba3tJhXhz1RQeLagPCaIII44YLH 1hdAZnGUL7QDXygZGYkhOHmCVYzpj2iu+xXp6KaLtIuY4jX79AGl8v2L5ILd+rro3JgngP PHQvz0WTH9ceMU1vMz4KPYBMw2PxY1U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722942166; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yMCXfwsD69mi8EaHLN1W8uTi3azOp475jm7XAaTLgJU=; b=eaR+tEPiYw6PLhXgIYHUuZ+CIqiD1tI8iLBrh3104ilFZBTZ8BVhqupSkz2dA5xFqv4tKi lYK/APMVsWMmcCBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722942165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yMCXfwsD69mi8EaHLN1W8uTi3azOp475jm7XAaTLgJU=; b=EHe7TtnmOGbpbRZrlQ12sZzb81Ozm+OVcyc7T0nTQAJ+p6W/mpoQSAEj2uWcvUSy1MkXZN +m7RxAPicfkapq+cXEsmLva7mjw7wLjoPn8e4bEOCyXwL+OfNjiScmgu2kxa1gIoB3PnqZ uQWVQiyY75kJxAiMpJtRKX9TKuXYbqw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722942165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yMCXfwsD69mi8EaHLN1W8uTi3azOp475jm7XAaTLgJU=; b=kw9g0X29zWnroPTIC+DfVdT6MYAtB+KgQo9jflwBc5zITL5NYm2md7KhJMGNtDAcfD4jlY fqadX/UZBprzabCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C1D1713770; Tue, 6 Aug 2024 11:02:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id RCX4LtUCsmYvHAAAD6G6ig (envelope-from ); Tue, 06 Aug 2024 11:02:45 +0000 Message-ID: <53b2e1f2-4291-48e5-a668-7cf57d900ecd@suse.cz> Date: Tue, 6 Aug 2024 13:02:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6.10 000/809] 6.10.3-rc3 review To: Linus Torvalds , Guenter Roeck Cc: linux-kernel@vger.kernel.org, Linux-MM , Thomas Gleixner References: <20240731095022.970699670@linuxfoundation.org> <718b8afe-222f-4b3a-96d3-93af0e4ceff1@roeck-us.net> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: B6376180011 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: o5jg9puj9wuo3jxr6ner86qdg3aj5w7w X-HE-Tag: 1722942167-798084 X-HE-Meta: U2FsdGVkX183xGiEg5q8exMdEGg5tlNumZF9qcdVUKRz4Fqk0IRGGzQYtg2bvzr9d7d1PqzMRV3O9IwcQcE77AKHIXqT9OTqTUrRJ/fkhmNVkadunydQmDHx5dBT4cXbr+/BVFLIrdPEczHDEHyUhyu7wa8FBIP9deUh5Jw4u3xFb6Nw+1o+7OxBSjIt2i+ckuyC4tIz85b5ElwQrX4zgKM2Vv+uqj3R4qf2UYQn/DpYUdJ6eFT/Y7lx82xoSZSVg6OBakdnAqTioU/NQI84NoYK1fnpLy1aINk9SkMwpqRyaLvz0whp04pZ8lPzjxrHYr+R7uxiHVEXo5cMh15rUyUE/xzvgPqqsMyzvkUIklJ0hCmCHGGmv1NI/u+/SAUa6oT3u/CjJhRMbs5xX0jrXfZ5RNkHF5MU6rxl0mxXprnPquCi+kJvrxuhBe9DJ0PRcus+yKsRb5x7zVKoH9OePhMs0hT4yes9wiEDdexSDhffUIA0LDsLSiqDNNnb03RGpEnT3BKWwmJDLU5K9pfGzPFM9Vko+52CnsDxRCw9FpoAZMQeNbe7H0aF6AojWWlD0bnNbKQV2b1K9gLm43CqzZxXFt8SdvP1nqwuSNgOjXTWjEfCrrzTaA9qy4Yu0twVw1wsqh8+BOd/A+nqMXVZVB+MNGkafIG83uKvxqkdT5W5/F3J0dezPm18JlXHCpta28+ASy0G+iCFMwH/a8ra6ob6AmMGm7VF9rELj7eT/xt0CtuNbjRmjXDmRzzK+T/1s1vPgOfCVNlLb54kt2iWxoxIyeli9sK8ykK+EQ8ogCQexEUoxQ4eJEuqMPCYHm1djKwL7pYjWKZ+0UkUfslTsaXcjv6Etmak5DjBuEOH6MlV5cpbWLFyBgC8+wzqSjeLd6CdyIqocTadDP4ZMdeLI1Dz3ilwf7/0abKI9fbodOQE9qx4EEpU/Jo7eE0U6i8lCGYYOjfQWS2axuidKcY 4YgB3fo+ vKOybzcv4FJ61MRBglTjkpJhIeqePWRJarFI6tLOOxykh9eIQJF2aVx187zctDaU3t7llc6pxcisi97v7H9ax+4MFZct5dgKch9nQRXKB1UfdMQUUp2VAJz36SeeKlkFZmCrGCzW/gFLN6eBQhdCTTNFISv6TrNrhGWTbnw7f7YmiGOZaSNfjCivPyiUhNbdbWn5AsN3ueajA9gbf36zwrQtt2n1g6VwumNRbtMutdcNtaBIk9LZ2R9kIN7F5sohfiTae2HvST8UrKOfJ9W4CwR9yeULdDdWkB3D9fRrs/1P89TO1sra1NQdoZpkbjTEkouHdXozVt7RfEOnlq0w0hcAlJfPcrKMG8wdCJSqpaVWdB27h5qvjGNbbPSVyhPXdB3Z4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/6/24 04:40, Linus Torvalds wrote: > [ Let's drop random people and bring in Vlastimil ] tglx was reproducing it so I add him back > Vlastimil, > it turns out that the "this patch" is entirely a red herring, and the > problem comes and goes randomly with just some code layout issues. See > > http://server.roeck-us.net/qemu/parisc64-6.10.3/ > > for more detail, particularly you'll see the "log.bad.gz" with the full log. [ 0.000000] BUG kmem_cache_node (Not tainted): objects 21 > max 16 [ 0.000000] Slab 0x0000000041ed0000 objects=21 used=5 fp=0x00000000434003d0 flags=0x200(workingset|section=0|zone=0) flags tell us this came from the partial list (workingset), there's no head flag so order-0 since the error was detected it basically throws the slab page away and tries another one [ 0.000000] BUG kmem_cache (Tainted: G B ): objects 25 > max 16 [ 0.000000] Slab 0x0000000041ed0080 objects=25 used=6 fp=0x0000000043402790 flags=0x240(workingset|head|section=0|zone=0) this was also from the partial list but head flag so at least order-1, two things are weird: - max=16 is same as above even though it should be at least double as slab page's order is larger - objects=25 also isn't at least twice than objects=21 All the following are: [ 0.000000] BUG kmem_cache (Tainted: G B ): objects 25 > max 16 [ 0.000000] Slab 0x0000000041ed0300 objects=25 used=1 fp=0x000000004340c150 flags=0x40(head|section=0|zone=0) we depleted the partial list so it's allocating new slab pages, that are also at least order-1 It looks like maxobj calculation is bogus, would be useful to see what values it calculates from. I'm attaching a diff, but maybe it will also hide the issue... If someone has a /proc/slabinfo from a working boot with otherwise same config it might be also enough to guess what values should be expected there, at least the s-size. objects=21 vs 25 also seem odd though used=5 with used=6 in the first two also suggests we already passed this code successfully for creating a number of kmalloc caches and only then it started failing, that's also weird. > See also > > https://lore.kernel.org/all/87y15a4p4h.ffs@tglx/ > > for this thread. > > I don't think this is really a slub issue, since it only happens on > parisc, but maybe you can see what would make parisc different, and > what could possibly make it all timing- or layout-dependent. > > Linus > > On Sun, 4 Aug 2024 at 11:36, Guenter Roeck wrote: >> >> With this patch in v6.10.3, all my parisc64 qemu tests get stuck with repeated error messages >> >> [ 0.000000] ============================================================================= >> [ 0.000000] BUG kmem_cache_node (Not tainted): objects 21 > max 16 >> [ 0.000000] ----------------------------------------------------------------------------- >> >> This never stops until the emulation aborts. diff --git a/mm/slub.c b/mm/slub.c index 4927edec6a8c..ec4ed5215f2f 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1386,8 +1386,8 @@ static int check_slab(struct kmem_cache *s, struct slab *slab) maxobj = order_objects(slab_order(slab), s->size); if (slab->objects > maxobj) { - slab_err(s, slab, "objects %u > max %u", - slab->objects, maxobj); + slab_err(s, slab, "objects %u > max %u (order %d size %u)", + slab->objects, maxobj, slab_order(slab), s->size); return 0; } if (slab->inuse > slab->objects) {