linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
	Stefan Roesch <shr@devkernel.io>,
	kernel-team@fb.com
Cc: linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com,
	david@redhat.com, linux-doc@vger.kernel.org,
	akpm@linux-foundation.org, hannes@cmpxchg.org
Subject: Re: [PATCH v1] docs/mm: extend ksm doc
Date: Tue, 14 Mar 2023 21:28:09 -0700	[thread overview]
Message-ID: <53b1194f-ae4a-87c9-5670-d1dbc298242f@infradead.org> (raw)
In-Reply-To: <ZBFCud+I8mVAoh87@debian.me>

Hi--

On 3/14/23 20:59, Bagas Sanjaya wrote:
> On Tue, Mar 14, 2023 at 01:45:57PM -0700, Stefan Roesch wrote:
>> +to cancel that advice and restore unshared pages: whereupon KSM
>> +unmerges whatever is merged for that process.  Note: this unmerging call
>> +may suddenly require more memory than is available - possibly failing
>> +with EAGAIN, but more probably arousing the Out-Of-Memory killer.
> 
> "... to disable KSM and let it unmerges ... . Note that this unmerging
> call may exhaust memory and triggers OOM killer."

I can't tell exactly what is being proposed here, but "let it unmerges"
is not good & proper...

Perhaps fewer ellipses and more complete sentences are in order.

>> +However, if the system is dedicated to running multiple jobs within the
>> +same security domain, there is a usecase where multiple instances of the
>> +same job are running inside a safe shared security domain and using the
>> +same sensitive data.
> 
> "... it is possible for multiple instances ... and share the same
> sensitive data."
> 
> Thanks. 
> 

-- 
~Randy


  reply	other threads:[~2023-03-15  4:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 20:45 Stefan Roesch
2023-03-15  3:59 ` Bagas Sanjaya
2023-03-15  4:28   ` Randy Dunlap [this message]
2023-03-15 15:59   ` Stefan Roesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53b1194f-ae4a-87c9-5670-d1dbc298242f@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=bagasdotme@gmail.com \
    --cc=david@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=riel@surriel.com \
    --cc=shr@devkernel.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox