From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44236C54E94 for ; Wed, 25 Jan 2023 02:11:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBE6B6B0071; Tue, 24 Jan 2023 21:11:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C472A6B0072; Tue, 24 Jan 2023 21:11:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9A726B0073; Tue, 24 Jan 2023 21:11:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9BB156B0071 for ; Tue, 24 Jan 2023 21:11:55 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 705CE1C63AE for ; Wed, 25 Jan 2023 02:11:55 +0000 (UTC) X-FDA: 80391695790.30.CC1E533 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2084.outbound.protection.outlook.com [40.107.102.84]) by imf18.hostedemail.com (Postfix) with ESMTP id 594621C000C for ; Wed, 25 Jan 2023 02:11:52 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=I0h5NHFi; spf=pass (imf18.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.102.84 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674612712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WUIE74bK5U/gwMlsUy99UtOkQxcexmYCN38LeCbjxZA=; b=QUaDgI/fHTJO2lItClyd4aw16YaRzSXXp+i3OEdsVHx+hbZHTm+asIhIcUs8DHdvPF9s3a TtsZsen9rOOf0jiKLaL5ZFffp2wvKW9QPlNLd/ChMBOOs4l7E6VEcMflMFS+tUArEP+3Vs cHBXIKXiSAXLvYq+pB/uuag4CKHpJhI= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=I0h5NHFi; spf=pass (imf18.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.102.84 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674612712; a=rsa-sha256; cv=pass; b=8lscntcr6P0Dhx48zkXV1po8xEDg5zZE6nGhe1QGjwb2YPTScWJBDeDbTlNt2nogt8+KBI XWNQZ07Zt25E7QgPJheADAwKNHsbYSI9CcVAyAjNxNEhFv9Vbl6wF68yOsuIihnmeWUIGy Ije0coT6jzhCxVAlXxB6WFGpru+KRjw= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UU4c3FIv3XUuKdLjHqMX0rzSvYhdyhUvBaEO+mRLe6+A9HejfeQetiY9wtWaf4osLuNshb6z2frP+pQsxC79lUNF/2971cz8rqmYWh6zo27GNxl1lhCoXFNrgA3gLuAJt7qL+ZrsQ0JsRIyM5vlFiXvowEi2yp4sezC3hcbmDawyvsbO9vWja4j1y7euZmONQuA8sCzpu796oiA0di710YdFEuMIHlGRoqUxhnnB0+UkNcwfyLWJJ/5MAiqQzJedAUwsiAbT4NuK+w1okMJ3fan8lxInxmwtXt1VZYswGir1yQhkpZJvBXlMQluDrgpYBbk/OsYuTT7KGMqmuYQGdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WUIE74bK5U/gwMlsUy99UtOkQxcexmYCN38LeCbjxZA=; b=OZehZ0i+RPltdlm6gSnC3bW1nECjWBQwm043uBuzQCyeur9A2xK2cxnObYJOLVbwUe+mcY/RUuWajFH5yOytbC+8AFjexFI7xS+9ehskKakEG882CCFRgqBQeg5RhN7Yh8O4B8qP9w1fIbsEIj8zY726wDQd357osr/CnhnElD3ZQsz7EW+J3ru7y97oBMjIqBLrUzapcD2cO3IXl9nVo/PaxHG4SVww4seUhQhAvBRfg1zKhjae1jnLN1ht+/lkeddb2UT8VYUsqbp5W+GbPc2+yS2GQkGedzIdFIZtZSS5irknSasag7FPBlKL0wxNlJqEwnEk0sPXzt2NPYlkLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WUIE74bK5U/gwMlsUy99UtOkQxcexmYCN38LeCbjxZA=; b=I0h5NHFinopLeTzh/7+X1kYABUMqXUQ7e4V/hejsKRinPd4a6l5DD4SAqf9SK8WqH7A+FkccfdfSSPDJpVfajNikABVfir7OKBWllzoVL21yDjescVkcpsEgTrR0mMocIFsDlLDSXW8+vR2K+8aUkquwQP1mFRneXth/aRF8otajE2E4oZykt2RgGuBPvl55zvX/vDjL9zZQLhy/EfJH1aIDMluV22iVjRz4eAOBvrkHwBi7Lh2johKqOJ9teOt4C/QNHHLn3fhxMzfoX1wH6wT/UrvaLHCT/X4DSIHddUv+vkqSJWeMi54rsEdCA/6kibeqRwrIrh57E5c3Q4VlMA== Received: from CY5PR19CA0083.namprd19.prod.outlook.com (2603:10b6:930:69::21) by MN0PR12MB5908.namprd12.prod.outlook.com (2603:10b6:208:37c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Wed, 25 Jan 2023 02:11:50 +0000 Received: from CY4PEPF0000C977.namprd02.prod.outlook.com (2603:10b6:930:69:cafe::8b) by CY5PR19CA0083.outlook.office365.com (2603:10b6:930:69::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33 via Frontend Transport; Wed, 25 Jan 2023 02:11:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000C977.mail.protection.outlook.com (10.167.241.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.16 via Frontend Transport; Wed, 25 Jan 2023 02:11:49 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 24 Jan 2023 18:11:38 -0800 Received: from [10.110.48.28] (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 24 Jan 2023 18:11:37 -0800 Message-ID: <53ac3700-6532-a609-ceff-d0840469e532@nvidia.com> Date: Tue, 24 Jan 2023 18:11:36 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 01/13] mm/gup: have internal functions get the mmap_read_lock() Content-Language: en-US To: Jason Gunthorpe CC: Alistair Popple , David Hildenbrand , David Howells , Christoph Hellwig , , "Mike Rapoport (IBM)" References: <1-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> From: John Hubbard In-Reply-To: <1-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C977:EE_|MN0PR12MB5908:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c639989-4f63-4c05-02fe-08dafe79849e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kSp+iEu4fmik05BSk5l/B8e5kdZL95iBKS/8ttvKxlu2Ntmx4m4Pdscg/qQn6CsOLpCQM0di2LrWS6dJgfABLlOhH7XvssHk9Mp5tmW+pZTj4c2HwJlZ5V7ZiNdIAQLOahBwKaecd87GBwfd+dTX2b2RhoLZITGOd9Nng3e4dbNjQ4yg8Pm/ZXSrsDcE0DYwMx1bdffSadKNR+colVoYr2P+zuUm2i3UJoOFHJsz1ab5kYTDGLXZ4BWfxuT6sKCwBd3ZLAH0ihxMau9mUqiKY8brltwru54SYZG1nFSe6xTqOhrwfGV/yglZy1ZL33WJKmts/YDQMMm0/18Lg0VoOAfsgi08kStnh0VHlsCu4ETiYi1xI5M/mQHAiaJB20k7NYUWLXWSvAAVcIQ+khS6F3B+9uiTf1xavXyImQWC+NXLBgyIq2KJBWKXlcxc97hXDNKg6TvhrLYCcXZPxK6bIu2ndGRuNDQlOtmm7/b7JEFdqwQgi3VrRYFsFVWylPF6J8wSP8Ry1WDn/ieR4+h66rAZAhldkg619CqQHPIE6nQEQY3jd0eUhl1cLr2vxA2Tk2Tf/8bUirIQNAQTCGPNcg8sfIluyGz39pMcy8U1tpcBgPaB4nDThNtdgesqThg728usB1FtU6F4dwqCQzVamR40mwx7AIB7P7kGpL1TPaHtlSkejV+DSBSzT/yKVvMmkd1UcQENNk1niz5pX3jlqcHf7CtqQVCMx4WB6I7gbb3bWUEwoii6F8ilmkLrnD0tCmlEdICvccQZ6Hw4pDHrPg== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199018)(36840700001)(46966006)(40470700004)(82310400005)(82740400003)(4744005)(6636002)(4326008)(86362001)(36756003)(2906002)(356005)(6862004)(70206006)(40460700003)(70586007)(186003)(8676002)(37006003)(31686004)(26005)(47076005)(41300700001)(426003)(16526019)(54906003)(336012)(53546011)(40480700001)(16576012)(5660300002)(36860700001)(2616005)(7636003)(83380400001)(8936002)(478600001)(31696002)(316002)(15583001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 02:11:49.4542 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5c639989-4f63-4c05-02fe-08dafe79849e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C977.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5908 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 594621C000C X-Stat-Signature: 368511y69y3m7rz99msa8s5zmx1mtruc X-HE-Tag: 1674612712-757156 X-HE-Meta: U2FsdGVkX18qnB6MOczi5PeGgXcQViqgoIx6yUlxLCZE5NxUD6XeSPqIPjQn1Q8Hf6zXZUqo4ZlJPIHl+saohxmJSdBI3h8exJTih+tJQm2yN2Sx1ErkX2ixGHGye1CVdlnQzBoVqa2EwuH7f7Ybqog1rOFi82BOr7js10BA+Q/EXpbBXW7OdJzqGm+xxTY5SQ9StubkPSaWf2/2wcrtn5kfXipZD3DKScV66YmyH1K7G9r25DoQnU7UKT4svNvy00G8Rxpd++DvyIVqRcDQswgRrg727ocKhgONGWXQKYquTpH9tHJevkzn5ESowMG7C4Cywk3yi4vDmAZkJzcNcNhs45H+H4jIqSYWAsfVCugRcH7MGq181w53Lw0nnnIUiTRisPwHfH3fnJjXRUs9TK73L+FG5CrlHqB6GT5fGN2j0PjmZazIeNvNFWnrrg5xUMtTXok6A92hP2UrVH8oqk7HR0qSDyaIusaXRdsK+MjDuUdhFJ4FygkrHjG5gFpSas5e4BwSCjZCV7ccTIVod4uCDVEKEwtegLaJtRUVGh6MRgb7n7ylDxQvuh7ahBsVHHcGmnguIYCWSZVgT+9xljUuJ+eF8QSLBus3lhbBf8BkKtHpq/trrvKTJxA+Uk10gIiP0mDLkgssNAJZWJ0Ky+FR+7YGaDGzd5QVlMRS7N1FqICQI8zmFDb9oDXWwd1ec1QpGRuxyzvjpvsZ1rS2m9yx4P+NTcwVF2zQDFUWSPVHldFDuYjpNO3OPwutdrNvXAPtMmKOsPkmB8b61nmJFpn9OOrwBimYPI93lA7VF/t4iteVvrYdpHPrClXX0bTtwE5b6HjRIeBDKJuw5dxQm6+0nKqJ8kfrI/Au44pGKmoPRR1xgAQwhTfHDMXJcxAV+SjsQ0wN6oHB7lEtc39PBfrdPqftvu9JSb2dQ2mUwYqeEn7OFBw/nLavBTtmn6SBfaw0/dYuOPjl0CpOg/J rnZkrGbi 1/zAym9FK2RrFrtVfH80MR/gaWrLCJGRKgRKgX7r4sRC7jd4o+xCkk2dhw8truYugDy1YZMBtktSUHJjBcbnX+erGmsoDhYhzd2XK1EVl134PDXbjWk8r+h0gioCL0npy/qty7h+7I+cUOEMxjBSdqpuBT276qvQtNRsnDshyEi5xLZmhxT3xUnSAXB18PB84QC2nBf1+tPLswuqKq0c70GNkE5NtmPTgm0+hqM3JFlzfosaGIHfIAYEPGb9EA0A2DAyn72yvgJnXj3BWANKTUqW2dWtSF9LCTNQI8pBAvb9dlRVRTcfdv3b9fdLUSd63WoiGYyl5KuJ3Z5UcJv6RbXZj+b2EyygNnAjAZPAHssgEVPs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/24/23 12:34, Jason Gunthorpe wrote: ... > @@ -3183,11 +3198,13 @@ long pin_user_pages_unlocked(unsigned long start, unsigned long nr_pages, > /* FOLL_GET and FOLL_PIN are mutually exclusive. */ > if (WARN_ON_ONCE(gup_flags & FOLL_GET)) > return -EINVAL; > + int locked = 0; > > if (WARN_ON_ONCE(!pages)) > return -EINVAL; > > - gup_flags |= FOLL_PIN; > - return get_user_pages_unlocked(start, nr_pages, pages, gup_flags); > + gup_flags |= FOLL_PIN | FOLL_TOUCH; I missed this on my review of v1 of this series: the FOLL_TOUCH change looks like a mistake, yes? It should just be left as-is: gup_flags |= FOLL_PIN; Everything else looks good. thanks, -- John Hubbard NVIDIA