linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: Vyacheslav Dubeyko <Vyacheslav.Dubeyko@hgst.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	kbuild-all@01.org
Subject: [mmotm:master 212/319] fs/nilfs2/sysfs.c:256:1: sparse: symbol 'nilfs_sysfs_create_mounted_snapshots_group' was not declared. Should it be static?
Date: Thu, 26 Jun 2014 16:38:15 +0800	[thread overview]
Message-ID: <53abdbf7.4djbeHCO91dyNSec%fengguang.wu@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   9477ec75947f2cf0fc47e8ab781a5e9171099be2
commit: c4d5ec2ba1ab268de64dcad7c6544d99a2218999 [212/319] nilfs2: integrate sysfs support into driver
reproduce: make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> fs/nilfs2/sysfs.c:256:1: sparse: symbol 'nilfs_sysfs_create_mounted_snapshots_group' was not declared. Should it be static?
>> fs/nilfs2/sysfs.c:369:1: sparse: symbol 'nilfs_sysfs_create_checkpoints_group' was not declared. Should it be static?
>> fs/nilfs2/sysfs.c:458:1: sparse: symbol 'nilfs_sysfs_create_segments_group' was not declared. Should it be static?
>> fs/nilfs2/sysfs.c:720:1: sparse: symbol 'nilfs_sysfs_create_segctor_group' was not declared. Should it be static?
>> fs/nilfs2/sysfs.c:846:1: sparse: symbol 'nilfs_sysfs_create_superblock_group' was not declared. Should it be static?

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[-- Attachment #2: make-it-static-c4d5ec2ba1ab268de64dcad7c6544d99a2218999.diff --]
[-- Type: text/x-diff, Size: 2706 bytes --]

From: Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH mmotm] nilfs2: nilfs_sysfs_create_mounted_snapshots_group can be static
TO: Vyacheslav Dubeyko <Vyacheslav.Dubeyko@hgst.com>
CC: Johannes Weiner <hannes@cmpxchg.org>
CC: linux-nilfs@vger.kernel.org 
CC: linux-kernel@vger.kernel.org 

CC: Vyacheslav Dubeyko <Vyacheslav.Dubeyko@hgst.com>
CC: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 sysfs.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c
index 0f6148c..46ca55b 100644
--- a/fs/nilfs2/sysfs.c
+++ b/fs/nilfs2/sysfs.c
@@ -253,7 +253,7 @@ static struct attribute *nilfs_mounted_snapshots_attrs[] = {
 
 NILFS_DEV_INT_GROUP_OPS(mounted_snapshots, dev);
 NILFS_DEV_INT_GROUP_TYPE(mounted_snapshots, dev);
-NILFS_DEV_INT_GROUP_FNS(mounted_snapshots, dev);
+static NILFS_DEV_INT_GROUP_FNS(mounted_snapshots, dev);
 
 /************************************************************************
  *                      NILFS checkpoints attrs                         *
@@ -366,7 +366,7 @@ static struct attribute *nilfs_checkpoints_attrs[] = {
 
 NILFS_DEV_INT_GROUP_OPS(checkpoints, dev);
 NILFS_DEV_INT_GROUP_TYPE(checkpoints, dev);
-NILFS_DEV_INT_GROUP_FNS(checkpoints, dev);
+static NILFS_DEV_INT_GROUP_FNS(checkpoints, dev);
 
 /************************************************************************
  *                        NILFS segments attrs                          *
@@ -455,7 +455,7 @@ static struct attribute *nilfs_segments_attrs[] = {
 
 NILFS_DEV_INT_GROUP_OPS(segments, dev);
 NILFS_DEV_INT_GROUP_TYPE(segments, dev);
-NILFS_DEV_INT_GROUP_FNS(segments, dev);
+static NILFS_DEV_INT_GROUP_FNS(segments, dev);
 
 /************************************************************************
  *                        NILFS segctor attrs                           *
@@ -717,7 +717,7 @@ static struct attribute *nilfs_segctor_attrs[] = {
 
 NILFS_DEV_INT_GROUP_OPS(segctor, dev);
 NILFS_DEV_INT_GROUP_TYPE(segctor, dev);
-NILFS_DEV_INT_GROUP_FNS(segctor, dev);
+static NILFS_DEV_INT_GROUP_FNS(segctor, dev);
 
 /************************************************************************
  *                        NILFS superblock attrs                        *
@@ -843,7 +843,7 @@ static struct attribute *nilfs_superblock_attrs[] = {
 
 NILFS_DEV_INT_GROUP_OPS(superblock, dev);
 NILFS_DEV_INT_GROUP_TYPE(superblock, dev);
-NILFS_DEV_INT_GROUP_FNS(superblock, dev);
+static NILFS_DEV_INT_GROUP_FNS(superblock, dev);
 
 /************************************************************************
  *                        NILFS device attrs                            *

             reply	other threads:[~2014-06-26  8:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-26  8:38 kbuild test robot [this message]
2014-06-26 12:59 ` Vyacheslav Dubeyko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53abdbf7.4djbeHCO91dyNSec%fengguang.wu@intel.com \
    --to=fengguang.wu@intel.com \
    --cc=Vyacheslav.Dubeyko@hgst.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox