linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: Dan Streetman <ddstreet@ieee.org>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	kbuild-all@01.org
Subject: [mmotm:master 144/319] mm/zsmalloc.c:253:6: sparse: symbol 'zs_zpool_destroy' was not declared. Should it be static?
Date: Thu, 26 Jun 2014 14:19:21 +0800	[thread overview]
Message-ID: <53abbb69.1g8q3OIP0CYmy0aT%fengguang.wu@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   9477ec75947f2cf0fc47e8ab781a5e9171099be2
commit: b03c0167d85a990598c69922fa6a290cba5b5ec8 [144/319] mm/zpool: update zswap to use zpool
reproduce: make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> mm/zsmalloc.c:253:6: sparse: symbol 'zs_zpool_destroy' was not declared. Should it be static?
>> mm/zsmalloc.c:258:5: sparse: symbol 'zs_zpool_malloc' was not declared. Should it be static?
>> mm/zsmalloc.c:263:6: sparse: symbol 'zs_zpool_free' was not declared. Should it be static?
>> mm/zsmalloc.c:268:5: sparse: symbol 'zs_zpool_shrink' was not declared. Should it be static?
>> mm/zsmalloc.c:274:6: sparse: symbol 'zs_zpool_map' was not declared. Should it be static?
>> mm/zsmalloc.c:294:6: sparse: symbol 'zs_zpool_unmap' was not declared. Should it be static?
>> mm/zsmalloc.c:299:5: sparse: symbol 'zs_zpool_total_size' was not declared. Should it be static?

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[-- Attachment #2: make-it-static-b03c0167d85a990598c69922fa6a290cba5b5ec8.diff --]
[-- Type: text/x-diff, Size: 1926 bytes --]

From: Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH mmotm] mm/zpool: zs_zpool_destroy() can be static
TO: Dan Streetman <ddstreet@ieee.org>
CC: Johannes Weiner <hannes@cmpxchg.org>
CC: linux-mm@kvack.org 
CC: linux-kernel@vger.kernel.org 

CC: Dan Streetman <ddstreet@ieee.org>
CC: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 zsmalloc.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index feba644..20dc632 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -250,28 +250,28 @@ static void *zs_zpool_create(gfp_t gfp, struct zpool_ops *zpool_ops)
 	return zs_create_pool(gfp);
 }
 
-void zs_zpool_destroy(void *pool)
+static void zs_zpool_destroy(void *pool)
 {
 	zs_destroy_pool(pool);
 }
 
-int zs_zpool_malloc(void *pool, size_t size, unsigned long *handle)
+static int zs_zpool_malloc(void *pool, size_t size, unsigned long *handle)
 {
 	*handle = zs_malloc(pool, size);
 	return *handle ? 0 : -1;
 }
-void zs_zpool_free(void *pool, unsigned long handle)
+static void zs_zpool_free(void *pool, unsigned long handle)
 {
 	zs_free(pool, handle);
 }
 
-int zs_zpool_shrink(void *pool, unsigned int pages,
+static int zs_zpool_shrink(void *pool, unsigned int pages,
 			unsigned int *reclaimed)
 {
 	return -EINVAL;
 }
 
-void *zs_zpool_map(void *pool, unsigned long handle,
+static void *zs_zpool_map(void *pool, unsigned long handle,
 			enum zpool_mapmode mm)
 {
 	enum zs_mapmode zs_mm;
@@ -291,12 +291,12 @@ void *zs_zpool_map(void *pool, unsigned long handle,
 
 	return zs_map_object(pool, handle, zs_mm);
 }
-void zs_zpool_unmap(void *pool, unsigned long handle)
+static void zs_zpool_unmap(void *pool, unsigned long handle)
 {
 	zs_unmap_object(pool, handle);
 }
 
-u64 zs_zpool_total_size(void *pool)
+static u64 zs_zpool_total_size(void *pool)
 {
 	return zs_get_total_size_bytes(pool);
 }

                 reply	other threads:[~2014-06-26  6:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53abbb69.1g8q3OIP0CYmy0aT%fengguang.wu@intel.com \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=ddstreet@ieee.org \
    --cc=hannes@cmpxchg.org \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox