On 08/26/2014 11:18 AM, Boaz Harrosh wrote: > On 08/25/2014 11:10 PM, Ross Zwisler wrote: > <> >> I think we can still have a working probe by instead comparing the passed in >> dev_t against the dev_t we get back from disk_to_dev(prd->prd_disk), but I'd >> really like a use case so I can test this. Until then I think I'm just going >> to stub out prd/pmem_probe() with a BUG() so we can see if anyone hits it. >> >> It seems like this is preferable to just registering NULL for probe, as that >> would cause an oops in kobj_lookup(() when probe() is blindly called without >> checking for NULL. >> > > I have a version I think you will love it removes the probe and bunch of > other stuff. > > I tested it heavily it just works > > Comming soon, I'm preparing trees right now > Thanks > Boaz Ross hi It is getting late around here and I will not be pushing new trees tonight, first thing tomorrow morning. (Your last push caused me lots of extra work, you must not do like you did when working on a rebasing out-off-tree project involving more then one person, but more on the proper procedure tomorrow with the push of the trees) So I hope you are not doing any big changes, do not apply any of my patches just yet, wait for the new trees tomorrow please I have everything all ready on top of the rename to pmem Meanwhile without any explanations, these will come tomorrow, I'm attaching the most interesting bit which you have not seen before. If you want you can inspect a preview of what's to come here: http://git.open-osd.org/gitweb.cgi?p=pmem.git;a=summary I have created a new pmem.git tree just for us. Thanks Boaz